-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](audit-loader) fix invalid token check logic #32095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
TPC-H: Total hot run time: 37245 ms |
TPC-DS: Total hot run time: 187397 ms |
ClickBench: Total hot run time: 30.03 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
zhiqiang-hhhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related: #26278
|
PR approved by anyone and no changes requested. |
|
Check token on local FE is hard to implement, some problems of token synchronization need to be solved. |
mrhhsg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
The check of the token should be forwarded to Master FE. I add a new RPC method `checkToken()` in Frontend for this logic. Otherwise, after enable the audit loader, the log from non-master FE can not be loaded to audit table with `Invalid token` error.
Proposed changes
The check of the token should be forwarded to Master FE.
I add a new RPC method
checkToken()in Frontend for this logic.Otherwise, after enable the audit loader, the log from non-master FE can not be loaded to audit table
with
Invalid tokenerror.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...