-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](function)revert function REPEAT nullable mode #32226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
please add some description to explain why need revert |
|
clang-tidy review says "All clean, LGTM! 👍" |
Description has been added |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38039 ms |
|
TeamCity be ut coverage result: |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a regression-test for > max repeat num, to make sure the behavior is stable.
|
in PR #32219, will report error if greater than max repeat num. |
added in https://github.com/apache/doris/pull/32219/files. we merge both two prs |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38352 ms |
Proposed changes
Issue Number: close #xxx
Previously, due to a mistake on my part, I changed the behaviour of the repeat function, but I didn't realise the problem
You can see that in the case of repeat * size > DEFAULT_MAX_STRING_SIZE we need to output null, but due to an oversight on my part I had defaulted to repeat being less than or equal to repeat_max_num, so I removed this judgement resulting in a change in behaviour
So we need the revert function
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...