Skip to content

Conversation

@vinlee19
Copy link
Contributor

@vinlee19 vinlee19 commented Mar 14, 2024

Proposed changes

When utilizing the flink-connector-doris to read IPv6 addresses, we encounter the following errors: internal failure, with a status code of [INVALID_ARGUMENT] and an error message stating [(xxx.xxx.xxx.xxx)[INVALID_ARGUMENT]Unknown primitive type(0) converted to Arrow type]. This issue arises due to the incompatible conversion between IPv6 datatype and arrow datatype.
Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@vinlee19
Copy link
Contributor Author

@sjyango

Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@sjyango
Copy link
Contributor

sjyango commented Mar 14, 2024

LGTM, Thank you for fixing this issue.

@yiguolei
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.99% (8573/24500)
Line Coverage: 26.73% (69450/259778)
Region Coverage: 26.02% (36076/138673)
Branch Coverage: 22.97% (18419/80196)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8854c6b315dd77dd996e0b85968cb3354335805_e8854c6b315dd77dd996e0b85968cb3354335805/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39605 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e8854c6b315dd77dd996e0b85968cb3354335805, data reload: false

------ Round 1 ----------------------------------
q1	17659	4578	4494	4494
q2	2020	148	143	143
q3	10599	1108	874	874
q4	8141	780	773	773
q5	7500	2741	2920	2741
q6	198	125	122	122
q7	1271	826	792	792
q8	9360	2189	2161	2161
q9	7508	6704	6661	6661
q10	8580	3623	3726	3623
q11	424	218	223	218
q12	774	309	294	294
q13	17840	2844	2862	2844
q14	283	244	243	243
q15	509	459	450	450
q16	532	390	386	386
q17	989	604	556	556
q18	7045	6411	6495	6411
q19	1850	1530	1546	1530
q20	557	281	270	270
q21	6238	3757	3716	3716
q22	386	326	303	303
Total cold run time: 110263 ms
Total hot run time: 39605 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4559	4486	4450	4450
q2	343	232	228	228
q3	3078	2930	2881	2881
q4	1911	1595	1576	1576
q5	5335	5376	5376	5376
q6	212	115	119	115
q7	2271	1830	1851	1830
q8	3371	3511	3545	3511
q9	8658	8574	8584	8574
q10	3804	3756	3783	3756
q11	569	436	428	428
q12	723	546	543	543
q13	16916	2849	2803	2803
q14	276	245	255	245
q15	498	435	454	435
q16	458	397	413	397
q17	1852	1567	1538	1538
q18	7443	7265	7183	7183
q19	1734	1692	1688	1688
q20	1930	1696	1693	1693
q21	7454	4794	4880	4794
q22	558	453	440	440
Total cold run time: 73953 ms
Total hot run time: 54484 ms

@vinlee19
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38496 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e8854c6b315dd77dd996e0b85968cb3354335805, data reload: false

------ Round 1 ----------------------------------
q1	17660	4483	4185	4185
q2	2032	156	157	156
q3	10674	1088	900	900
q4	7106	702	707	702
q5	7494	2819	2724	2724
q6	185	125	123	123
q7	1188	819	806	806
q8	9332	2026	2012	2012
q9	7143	6463	6446	6446
q10	8449	3508	3657	3508
q11	446	215	221	215
q12	688	302	304	302
q13	17784	2839	2911	2839
q14	270	243	250	243
q15	521	446	443	443
q16	504	391	396	391
q17	964	535	619	535
q18	7312	6493	6479	6479
q19	1910	1447	1414	1414
q20	524	294	278	278
q21	6464	3498	3523	3498
q22	359	297	308	297
Total cold run time: 109009 ms
Total hot run time: 38496 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4151	4110	4094	4094
q2	316	226	226	226
q3	2982	2848	2854	2848
q4	1825	1560	1538	1538
q5	5216	5255	5279	5255
q6	198	123	120	120
q7	2235	1861	1864	1861
q8	3177	3302	3272	3272
q9	8565	8546	8591	8546
q10	3723	3742	3655	3655
q11	548	441	446	441
q12	727	535	527	527
q13	16913	2897	2919	2897
q14	278	243	275	243
q15	476	454	451	451
q16	480	410	409	409
q17	1737	1483	1442	1442
q18	7636	7134	7156	7134
q19	1646	1557	1531	1531
q20	1895	1717	1695	1695
q21	4784	4793	4641	4641
q22	548	453	503	453
Total cold run time: 70056 ms
Total hot run time: 53279 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.99% (8573/24501)
Line Coverage: 26.73% (69455/259810)
Region Coverage: 26.01% (36080/138693)
Branch Coverage: 22.97% (18420/80208)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8854c6b315dd77dd996e0b85968cb3354335805_e8854c6b315dd77dd996e0b85968cb3354335805/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants