Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 15, 2024

Proposed changes

Issue imported by #32162
The window funnel mode was enabled from 2.0.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@mrhhsg mrhhsg added the not-merge/2.0 do not merge into 2.0 branch label Mar 15, 2024
@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 15, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg force-pushed the fix_window_funnel branch from 2323c59 to 8c2d040 Compare March 15, 2024 07:16
@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 15, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.95% (8574/24534)
Line Coverage: 26.65% (69473/260728)
Region Coverage: 25.94% (36085/139107)
Branch Coverage: 22.89% (18424/80478)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8c2d04037a72acc5db2a0637a53550e85c4c8d78_8c2d04037a72acc5db2a0637a53550e85c4c8d78/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38267 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8c2d04037a72acc5db2a0637a53550e85c4c8d78, data reload: false

------ Round 1 ----------------------------------
q1	17728	4400	4134	4134
q2	2023	153	143	143
q3	10760	1076	882	882
q4	7525	749	740	740
q5	7469	2649	2621	2621
q6	186	119	118	118
q7	1192	822	790	790
q8	9334	1974	2013	1974
q9	7205	6417	6367	6367
q10	8537	3555	3609	3555
q11	438	227	213	213
q12	580	295	311	295
q13	17793	2827	2823	2823
q14	282	241	256	241
q15	500	464	450	450
q16	519	379	386	379
q17	940	572	562	562
q18	7171	6422	6416	6416
q19	1517	1426	1413	1413
q20	537	284	284	284
q21	6184	3611	3576	3576
q22	341	294	291	291
Total cold run time: 108761 ms
Total hot run time: 38267 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4082	4072	4036	4036
q2	323	228	225	225
q3	2934	2788	2831	2788
q4	1820	1572	1525	1525
q5	5177	5220	5232	5220
q6	189	114	123	114
q7	2198	1837	1839	1837
q8	3143	3292	3278	3278
q9	8516	8513	8501	8501
q10	3675	3633	3667	3633
q11	543	445	441	441
q12	717	535	541	535
q13	16921	2875	2811	2811
q14	269	259	249	249
q15	481	444	443	443
q16	451	423	400	400
q17	1711	1461	1451	1451
q18	7580	7156	7175	7156
q19	1602	1551	1510	1510
q20	1903	1715	1678	1678
q21	4810	4694	4611	4611
q22	548	442	481	442
Total cold run time: 69593 ms
Total hot run time: 52884 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit e4f0c60 into apache:master Mar 16, 2024
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. not-merge/2.0 do not merge into 2.0 branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants