[fix](Nereids): just pull up alias project above join through topn #32305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
jackwener
changed the title
Member
Author
|
run buildall |
TPC-H: Total hot run time: 38028 ms |
jackwener
force-pushed
the
time
branch
2 times, most recently
from
11cc83d to
21d8b8e
Compare
Member
Author
|
run buildall |
Member
Author
|
run buildall |
xzj7019
reviewed
Mar 20, 2024
| @Override | ||
| public Rule build() { | ||
| return logicalLimit(logicalProject().whenNot(p -> p.isAllSlots())) | ||
| return logicalLimit(logicalProject(logicalJoin().when(j -> j.getJoinType().isLeftRightOuterOrCrossJoin())) |
Contributor
There was a problem hiding this comment.
Does it reduce the scope of this rule if adding the join pattern?
xzj7019
reviewed
Mar 20, 2024
|
|
||
| class PullUpProjectUnderTopNTest implements MemoPatternMatchSupported { | ||
| private final LogicalOlapScan scan1 = PlanConstructor.newLogicalOlapScan(0, "t1", 0); | ||
| private final LogicalOlapScan scan2 = PlanConstructor.newLogicalOlapScan(1, "t2", 0); |
Contributor
There was a problem hiding this comment.
why not add a new ut to cover the join with select alias, avoid overwrite the original one?
xzj7019
reviewed
Mar 20, 2024
| new Cast(scan1.getOutput().get(1), VarcharType.SYSTEM_DEFAULT).alias("cast") | ||
| ); | ||
| LogicalPlan limit = new LogicalPlanBuilder(scan1) | ||
| .join(scan2, JoinType.LEFT_OUTER_JOIN, ImmutableList.of()) |
Contributor
There was a problem hiding this comment.
Do we need to cover right outer and cross? since the code handle these two kinds.
xzj7019
reviewed
Mar 20, 2024
| return logicalTopN(logicalProject().whenNot(p -> p.isAllSlots())) | ||
| .whenNot(topN -> topN.child().hasPushedDownToProjectionFunctions()) | ||
| return logicalTopN( | ||
| logicalProject(logicalJoin().when(j -> j.getJoinType().isLeftRightOuterOrCrossJoin())) |
Contributor
There was a problem hiding this comment.
similar question, will it reduce this rule's scope if adding the join pattern judge?
Member
Author
|
run buildall |
xzj7019
approved these changes
Mar 21, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 37532 ms |
TPC-DS: Total hot run time: 181258 ms |
Member
Author
|
run p0 |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 37405 ms |
TPC-DS: Total hot run time: 180783 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Member
Author
|
run buildall |
jackwener
changed the title
TPC-H: Total hot run time: 37405 ms |
TPC-DS: Total hot run time: 180711 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Mar 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Mar 22, 2024
jackwener
added a commit
that referenced
this pull request
Mar 22, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
* [enhancement](Nereids): support more condition Date/DateTime Literal (apache#31858) (cherry picked from commit dbb7573) * [fix](Nereids): slot set in condition can be empty (apache#32169) (cherry picked from commit ca09213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...