Skip to content

[enhance](auth)row policy support catalog and match name instead id #32310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 3 commits into from
Mar 18, 2024
Merged

[enhance](auth)row policy support catalog and match name instead id #32310

morningman merged 3 commits into from
Mar 18, 2024

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Mar 15, 2024 •
edited by morningman
Loading

Proposed changes

Follow up #32137

storage name instead id to meta,Prevent table deletion and reconstruction and causing ID changes

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zddr
Copy link
Contributor Author

zddr commented Mar 15, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

TPC-H: Total hot run time: 38375 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c7c216ee60db6b573d47c52ec715a55aed8a693, data reload: false

------ Round 1 ----------------------------------
q1	17635	4470	4138	4138
q2	2025	153	147	147
q3	10743	1079	886	886
q4	8234	749	728	728
q5	7479	2797	2764	2764
q6	184	129	129	129
q7	1168	827	812	812
q8	9431	2018	1987	1987
q9	7130	6415	6420	6415
q10	8448	3511	3602	3511
q11	436	228	221	221
q12	597	314	289	289
q13	17791	2867	2847	2847
q14	270	241	240	240
q15	497	458	446	446
q16	497	391	389	389
q17	952	532	527	527
q18	7277	6514	6410	6410
q19	1543	1483	1385	1385
q20	558	299	281	281
q21	6380	3523	3544	3523
q22	370	301	300	300
Total cold run time: 109645 ms
Total hot run time: 38375 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4093	4084	4062	4062
q2	318	225	227	225
q3	2975	2836	2843	2836
q4	1842	1542	1537	1537
q5	5252	5244	5250	5244
q6	189	123	115	115
q7	2230	1850	1875	1850
q8	3150	3257	3258	3257
q9	8610	8557	8595	8557
q10	3736	3717	3693	3693
q11	527	430	436	430
q12	723	534	541	534
q13	16897	2859	2841	2841
q14	287	239	267	239
q15	478	444	445	444
q16	460	394	397	394
q17	1743	1484	1451	1451
q18	7554	7200	7167	7167
q19	1754	1564	1524	1524
q20	1929	1734	1710	1710
q21	4858	4726	4769	4726
q22	528	459	460	459
Total cold run time: 70133 ms
Total hot run time: 53295 ms

morningman
morningman previously approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2024

PR approved by anyone and no changes requested.

@zddr
Copy link
Contributor Author

zddr commented Mar 18, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 18, 2024
@doris-robot
Copy link

doris-robot commented Mar 18, 2024

TPC-H: Total hot run time: 38318 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a09a63beefa3c25eec63aed0b2c101a3ac5e432a, data reload: false

------ Round 1 ----------------------------------
q1	17665	4233	4117	4117
q2	2021	159	154	154
q3	10576	1101	903	903
q4	7775	738	721	721
q5	7471	2733	2727	2727
q6	186	125	124	124
q7	1173	832	809	809
q8	9384	2029	2015	2015
q9	7348	6412	6359	6359
q10	8511	3493	3631	3493
q11	446	220	224	220
q12	932	303	300	300
q13	18118	2879	2874	2874
q14	290	238	253	238
q15	503	451	462	451
q16	497	394	393	393
q17	945	500	545	500
q18	7128	6440	6357	6357
q19	1952	1462	1404	1404
q20	589	289	284	284
q21	5946	3590	3575	3575
q22	365	305	300	300
Total cold run time: 109821 ms
Total hot run time: 38318 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4147	4098	4107	4098
q2	318	225	227	225
q3	2956	2807	2868	2807
q4	1810	1539	1560	1539
q5	5255	5286	5233	5233
q6	204	117	116	116
q7	2237	1878	1836	1836
q8	3136	3318	3288	3288
q9	8546	8570	8573	8570
q10	3706	3752	3687	3687
q11	560	440	452	440
q12	712	543	563	543
q13	16913	2824	2880	2824
q14	272	245	250	245
q15	483	440	447	440
q16	447	408	413	408
q17	1744	1484	1457	1457
q18	7525	7110	7096	7096
q19	1625	1546	1578	1546
q20	1889	1711	1710	1710
q21	4813	4583	4680	4583
q22	550	472	472	472
Total cold run time: 69848 ms
Total hot run time: 53163 ms

morningman
morningman previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2024
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 18, 2024
@zddr
Copy link
Contributor Author

zddr commented Mar 18, 2024

run buildall

morningman
morningman approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit c2e155e into apache:master Mar 18, 2024
morningman pushed a commit that referenced this pull request Mar 26, 2024
@zddr @morningman
[enhance](auth)row policy support catalog and match name instead id (#…
0a2d737 
…32310)

Follow up #32137

storage name instead id to meta,Prevent table deletion and reconstruction and causing ID changes
@zddr zddr deleted the row_policy_ctl branch March 28, 2024 02:29
xiaokang pushed a commit that referenced this pull request May 17, 2024
@zddr
[fix](auth)fix show row policy error when table deleted for 2.0 #32310 (
6aaace1 
#35016)
@xiaokang xiaokang mentioned this pull request May 17, 2024
Merged
@xiaokang xiaokang added dev/2.0.11-merged usercase Important user case type label labels May 17, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zddr
[fix](auth)fix show row policy error when table deleted for 2.0 apach…
c7c1b8c 
…e#32310 (apache#35016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.1-merged meta-change reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr @doris-robot @morningman @CalvinKirs @xiaokang