fix the bug that 'username' in broker load is invalid #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HangyuanLiu
reviewed
Apr 1, 2020
| } | ||
| } else { | ||
| throw new BrokerException(TBrokerOperationStatusCode.INVALID_ARGUMENT, | ||
| "invalid authentication."); |
Contributor
There was a problem hiding this comment.
We need to determine whether the authentication method exists
Contributor
Author
There was a problem hiding this comment.
The authentication has been checked before, so this is redundant here.
|
|
||
| conf.set(FS_HDFS_IMPL_DISABLE_CACHE, "true"); | ||
| FileSystem dfsFileSystem = FileSystem.get(pathUri.getUri(), conf); | ||
| FileSystem dfsFileSystem = null; |
Contributor
There was a problem hiding this comment.
Is this method compatible with versions of hdfs?
Contributor
Author
There was a problem hiding this comment.
The version 2.7.3 of package hadoop-common including this method is the same as package hadoop-hdfs.
Contributor
|
Please change to an understandable title |
frwrdt
changed the title
frwrdt
changed the title
HangyuanLiu
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug in issue #3234