Skip to content

[fix](ParquetReader) Fix Parquet Reader to read int96 parquet type problem #32394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Mar 19, 2024
Merged

[fix](ParquetReader) Fix Parquet Reader to read int96 parquet type problem #32394

morningman merged 2 commits into from
Mar 19, 2024

Conversation

@BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Mar 18, 2024 •
edited by morningman
Loading

Proposed changes

Issue Number: #31442

hi - JULIAN_EPOCH_OFFSET_DAYS could be negative, so we can't all use unsigned int.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@BePPPower
Copy link
Contributor Author

BePPPower commented Mar 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 18, 2024

TeamCity be ut coverage result:
Function Coverage: 35.25% (8701/24683)
Line Coverage: 27.08% (71186/262889)
Region Coverage: 26.33% (36921/140249)
Branch Coverage: 23.25% (18888/81256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0a39509b6cf90a1464f969be96f79535040cf7af_0a39509b6cf90a1464f969be96f79535040cf7af/report/index.html

@BePPPower
Copy link
Contributor Author

BePPPower commented Mar 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

TeamCity be ut coverage result:
Function Coverage: 35.25% (8701/24687)
Line Coverage: 27.08% (71185/262910)
Region Coverage: 26.32% (36918/140264)
Branch Coverage: 23.24% (18888/81264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ac510b4335291e0b7a34f7e27ca023143f1a87e6_ac510b4335291e0b7a34f7e27ca023143f1a87e6/report/index.html

@BePPPower
Copy link
Contributor Author

BePPPower commented Mar 19, 2024

run p0

@BePPPower BePPPower force-pushed the fixParuqetReaderTimestamp branch from ac510b4 to 8760b82 Compare March 19, 2024 06:30
@BePPPower
Copy link
Contributor Author

BePPPower commented Mar 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

TeamCity be ut coverage result:
Function Coverage: 35.24% (8699/24687)
Line Coverage: 27.06% (71156/262931)
Region Coverage: 26.31% (36910/140274)
Branch Coverage: 23.23% (18877/81272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8760b82c0d978534be4485b66c4e94455e068574_8760b82c0d978534be4485b66c4e94455e068574/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit d991bcf into apache:master Mar 19, 2024
@morningman morningman mentioned this pull request Mar 19, 2024
Closed
3 tasks
seawinde pushed a commit to seawinde/doris that referenced this pull request Mar 20, 2024
@BePPPower @seawinde
[fix](ParquetReader) Fix Parquet Reader to read int96 parquet type …
0c9baf2 
…problem (apache#32394)

`hi - JULIAN_EPOCH_OFFSET_DAYS` could be negative, so we can't all use unsigned int.
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@BePPPower @Doris-Extras
[fix](ParquetReader) Fix Parquet Reader to read int96 parquet type …
bc02cf2 
…problem (#32394)

`hi - JULIAN_EPOCH_OFFSET_DAYS` could be negative, so we can't all use unsigned int.
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@BePPPower @Doris-Extras
[fix](ParquetReader) Fix Parquet Reader to read int96 parquet type …
f99db38 
…problem (#32394)

`hi - JULIAN_EPOCH_OFFSET_DAYS` could be negative, so we can't all use unsigned int.
@yiguolei yiguolei mentioned this pull request Mar 24, 2024
Closed
@morningman morningman added not-merge/2.0 do not merge into 2.0 branch and removed dev/2.0.x labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@zddr zddr zddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. not-merge/2.0 do not merge into 2.0 branch reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BePPPower @doris-robot @morningman @zddr @xiaokang