[enhancement](nereids)only push having as agg's parent if having just use slots from agg's output #32414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
starocean999
force-pushed
the
nereids_1026
branch
from
1731c94 to
0036799
Compare
Contributor
Author
|
run buildall |
starocean999
force-pushed
the
nereids_1026
branch
from
0036799 to
9b7db6c
Compare
Contributor
Author
|
run buildall |
starocean999
force-pushed
the
nereids_1026
branch
2 times, most recently
from
1d4d0b1 to
c54d4a3
Compare
Contributor
Author
|
run buildall |
morrySnow
reviewed
Mar 21, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/NormalizeAggregate.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/NormalizeAggregate.java
Outdated
Show resolved
Hide resolved
starocean999
force-pushed
the
nereids_1026
branch
from
c54d4a3 to
eeb5805
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38372 ms |
TPC-DS: Total hot run time: 180924 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
…elect list but not in aggregate node's output
starocean999
force-pushed
the
nereids_1026
branch
from
eeb5805 to
216114a
Compare
starocean999
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38251 ms |
TPC-DS: Total hot run time: 181722 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
previously approved these changes
Mar 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38225 ms |
TPC-DS: Total hot run time: 186219 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Mar 26, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
924060929
approved these changes
Mar 26, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 26, 2024
…t use slots from agg's output (#32414) 1. only push having as agg's parent if having just use slots from agg's output 2. show user friendly error message when item in select list but not in aggregate node's output
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…t use slots from agg's output (apache#32847) pick from master apache#32414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...