Skip to content

[Fix](inverted index) fix inappropriate use of macro in inverted inde… #32472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qidaye merged 4 commits into from
Mar 20, 2024
Merged

[Fix](inverted index) fix inappropriate use of macro in inverted inde… #32472

qidaye merged 4 commits into from
Mar 20, 2024

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Mar 19, 2024

…x fs directory error process

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

airborne12 commented Mar 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

qidaye
qidaye previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by anyone and no changes requested.

@airborne12 airborne12 force-pushed the fix-inverted-index-macro branch from f45f1aa to b77cd24 Compare March 19, 2024 09:40
@airborne12
Copy link
Member Author

airborne12 commented Mar 19, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

qidaye
qidaye previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

@airborne12
Copy link
Member Author

airborne12 commented Mar 19, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

qidaye
qidaye previously approved these changes Mar 19, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

yiguolei
yiguolei previously approved these changes Mar 19, 2024
View reviewed changes
@airborne12 airborne12 dismissed stale reviews from yiguolei and qidaye via 4527ee8 March 19, 2024 10:50
@airborne12
Copy link
Member Author

airborne12 commented Mar 19, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
zzzxl1993
zzzxl1993 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaokang
xiaokang previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
Copy link
Member Author

airborne12 commented Mar 19, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

TeamCity be ut coverage result:
Function Coverage: 35.31% (8727/24713)
Line Coverage: 27.13% (71395/263167)
Region Coverage: 26.38% (37045/140449)
Branch Coverage: 23.28% (18942/81362)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5c57f0c45a5e12603ef51f3e0216551e8a5ab98c_5c57f0c45a5e12603ef51f3e0216551e8a5ab98c/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

PR approved by at least one committer and no changes requested.

zzzxl1993
zzzxl1993 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 62ded78 into apache:master Mar 20, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Mar 20, 2024
@airborne12 @seawinde
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
32af834 
…x fs directory error process (apache#32472)
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@airborne12 @Doris-Extras
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
ccf3ab7 
…x fs directory error process (#32472)
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@airborne12 @Doris-Extras
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
4efeb66 
…x fs directory error process (#32472)
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Mar 21, 2024
@airborne12
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
d97b87b 
…x fs directory error process (apache#32472)
xiaokang pushed a commit that referenced this pull request Mar 21, 2024
@airborne12
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
cff185d 
…x fs directory error process (#32472) (#32647)
@xiaokang xiaokang mentioned this pull request Mar 21, 2024
Merged
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@airborne12
[Fix](inverted index) fix inappropriate use of macro in inverted inde…
ebc40a5 
…x fs directory error process (apache#32472) (apache#32647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qidaye qidaye qidaye approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

@xiaokang xiaokang xiaokang left review comments

@yiguolei yiguolei yiguolei left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@airborne12 @doris-robot @xiaokang @yiguolei @qidaye @zzzxl1993