Skip to content

[enhance](S3) Print the oss request id for each error s3 request #32499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 20, 2024
Merged

[enhance](S3) Print the oss request id for each error s3 request #32499

dataroaring merged 1 commit into from
Mar 20, 2024

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Mar 19, 2024

Proposed changes

Issue Number: close #xxx

Sometimes users may need to use the request ID to consult the cloud service provider about a specific S3 operation's request logs, so it is necessary to provide the request ID.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Contributor Author

ByteYue commented Mar 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 19, 2024

TeamCity be ut coverage result:
Function Coverage: 35.32% (8728/24714)
Line Coverage: 27.13% (71405/263212)
Region Coverage: 26.38% (37054/140455)
Branch Coverage: 23.28% (18945/81386)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61151d6db9a7d36b3c911ad5a66b2ce5f65782f0_61151d6db9a7d36b3c911ad5a66b2ce5f65782f0/report/index.html

@ByteYue ByteYue force-pushed the print_request_id_for_oss_request branch from 61151d6 to 45d4dde Compare March 20, 2024 02:31
@ByteYue
Copy link
Contributor Author

ByteYue commented Mar 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.30% (8725/24715)
Line Coverage: 27.10% (71359/263300)
Region Coverage: 26.35% (37028/140538)
Branch Coverage: 23.25% (18933/81418)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45d4dde27d469be45b4d9f602c5341868e04c60b_45d4dde27d469be45b4d9f602c5341868e04c60b/report/index.html

@ByteYue ByteYue force-pushed the print_request_id_for_oss_request branch from 45d4dde to ca0c524 Compare March 20, 2024 13:37
@ByteYue
Copy link
Contributor Author

ByteYue commented Mar 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.27% (8727/24745)
Line Coverage: 27.08% (71422/263751)
Region Coverage: 26.32% (37067/140814)
Branch Coverage: 23.24% (18959/81586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca0c524b368ca9398ddee542fc94137a31225f9d_ca0c524b368ca9398ddee542fc94137a31225f9d/report/index.html

@dataroaring dataroaring merged commit 3eb2eba into apache:master Mar 20, 2024
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue @Doris-Extras
[enhance](S3) Print the oss request id for each error s3 request (#32499
b3ec598 
)
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue @Doris-Extras
[enhance](S3) Print the oss request id for each error s3 request (#32499
02430e6 
)
@ByteYue ByteYue mentioned this pull request Mar 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue
Pick "[enhance](S3) Print the oss request id for each error s3 request …
d77b8ce 
…#32499" (#32607)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@ByteYue
Pick "[enhance](S3) Print the oss request id for each error s3 request …
975575a 
…apache#32499" (apache#32607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ByteYue @doris-robot @Yukang-Lian @dataroaring @xiaokang