Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 19, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 19, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.31% (8727/24713)
Line Coverage: 27.12% (71395/263208)
Region Coverage: 26.38% (37048/140457)
Branch Coverage: 23.28% (18944/81386)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 20, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.30% (8730/24730)
Line Coverage: 27.09% (71404/263536)
Region Coverage: 26.33% (37055/140709)
Branch Coverage: 23.24% (18944/81514)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

Please add test cases in next PR

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 21, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.26% (8728/24750)
Line Coverage: 27.08% (71442/263854)
Region Coverage: 26.32% (37078/140871)
Branch Coverage: 23.23% (18962/81616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants