[compile](fix) fix gcc compile error #32583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
run performance |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
cambyzju
reviewed
Mar 21, 2024
| if constexpr (ShowNull::value) { | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| if (places[i] + offset) { | ||
| if (places[i] || offset) { |
Contributor
Collaborator
Author
There was a problem hiding this comment.
place[i] is a pointer, and offset is an unsigned int, so if placces[i] != null or offset != 0, equals places[i] + offset != null
Contributor
There was a problem hiding this comment.
maybe the correct answer is like: if(places[i] && offset < places[i].size()), check offset != 0 or == 0 is strange here.
Contributor
There was a problem hiding this comment.
here below we use places[i]+offset as an pointer. so maybe places[i] + offset != nullptr is correct and more readable
TPC-H: Total hot run time: 37259 ms |
TPC-DS: Total hot run time: 180519 ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fcc reports error: comparing the result of pointer addition when compile
if (places[i] + offset)Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...