[cherry-pick](function) add error msg if exceeded maximum default value in repeat function (#32219) #32588
Conversation
…n repeat function (apache#32219) add some error msg from repeat function, so the user could know the count is greater than default value.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| static FunctionPtr create() { return std::make_shared<FunctionStringRepeat>(); } | ||
| String get_name() const override { return name; } | ||
| size_t get_number_of_arguments() const override { return 2; } | ||
| std::string error_msg(int default_value, int repeat_value) const { |
There was a problem hiding this comment.
warning: function 'error_msg' should be marked [[nodiscard]] [modernize-use-nodiscard]
| std::string error_msg(int default_value, int repeat_value) const { | |
| [[nodiscard]] std::string error_msg(int default_value, int repeat_value) const { |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
…n repeat function (apache#32219) (apache#32588)
4 participants
cherry-pick from master #32219
add some error msg from repeat function, so the user could know the count is greater than default value.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...