Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Mar 21, 2024

Cherry-pick #32489

…pache#32489)

The standard said that the input parameter `pos` of std::vector::erase
must be valid and dereferenceable, the `end()` iterator cannot be used
as a value of `pos`. I did some tests and the crash only occurs when the
vector is empty. Fortunately `local_files` is usually not empty.
@w41ter
Copy link
Contributor Author

w41ter commented Mar 21, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 50183 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 90e0de78e5e0446528cab569081a6e364426b48f, data reload: false

------ Round 1 ----------------------------------
q1	18128	4465	4377	4377
q2	2096	155	142	142
q3	10271	1960	1943	1943
q4	10108	1226	1318	1226
q5	8450	3973	3999	3973
q6	235	128	124	124
q7	2033	1599	1620	1599
q8	9358	2731	2749	2731
q9	11008	10760	10571	10571
q10	8659	3541	3510	3510
q11	429	243	250	243
q12	460	299	306	299
q13	18365	3999	4042	3999
q14	354	322	337	322
q15	525	474	456	456
q16	703	600	594	594
q17	1131	971	993	971
q18	7304	7000	6758	6758
q19	1681	1557	1539	1539
q20	539	296	296	296
q21	4474	4146	4124	4124
q22	494	389	386	386
Total cold run time: 116805 ms
Total hot run time: 50183 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4341	4331	4326	4326
q2	321	224	223	223
q3	4158	4166	4126	4126
q4	2766	2751	2757	2751
q5	7351	7234	7285	7234
q6	236	121	118	118
q7	3238	2884	2882	2882
q8	4361	4494	4537	4494
q9	17168	17001	16847	16847
q10	4250	4274	4253	4253
q11	780	682	672	672
q12	1044	851	847	847
q13	6645	3764	3716	3716
q14	453	417	413	413
q15	501	452	447	447
q16	754	712	711	711
q17	3863	3886	3839	3839
q18	8893	8923	8712	8712
q19	1707	1702	1650	1650
q20	2390	2194	2165	2165
q21	8595	8532	8510	8510
q22	1026	948	954	948
Total cold run time: 84841 ms
Total hot run time: 79884 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8045/21283)
Line Coverage: 29.46% (65680/222950)
Region Coverage: 28.93% (33807/116838)
Branch Coverage: 24.78% (17355/70034)
Coverage Report: http://coverage.selectdb-in.cc/coverage/90e0de78e5e0446528cab569081a6e364426b48f_90e0de78e5e0446528cab569081a6e364426b48f/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 201667 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 90e0de78e5e0446528cab569081a6e364426b48f, data reload: false

query1	945	389	384	384
query2	6540	2117	2103	2103
query3	6920	210	213	210
query4	20608	17942	17932	17932
query5	19724	6530	6555	6530
query6	274	223	232	223
query7	4152	309	303	303
query8	245	226	237	226
query9	3175	2733	2651	2651
query10	425	302	313	302
query11	11266	10795	10681	10681
query12	124	73	76	73
query13	5574	629	628	628
query14	17882	13614	13383	13383
query15	361	225	236	225
query16	6443	271	265	265
query17	1720	1467	863	863
query18	2305	416	408	408
query19	204	145	150	145
query20	80	80	73	73
query21	189	94	92	92
query22	5323	5109	4974	4974
query23	32584	31920	31990	31920
query24	6860	6493	6547	6493
query25	533	432	420	420
query26	525	162	160	160
query27	1883	296	286	286
query28	6158	2305	2248	2248
query29	2897	2852	2805	2805
query30	247	160	161	160
query31	919	770	724	724
query32	68	59	61	59
query33	393	245	235	235
query34	842	479	507	479
query35	1116	927	897	897
query36	1204	1126	1162	1126
query37	92	61	60	60
query38	3120	2954	2930	2930
query39	1380	1309	1335	1309
query40	205	90	95	90
query41	35	33	32	32
query42	91	87	90	87
query43	631	650	534	534
query44	1135	739	733	733
query45	239	223	227	223
query46	1268	972	969	969
query47	1903	1748	1749	1748
query48	995	679	665	665
query49	619	369	360	360
query50	873	639	605	605
query51	4789	4656	4860	4656
query52	95	76	89	76
query53	441	321	316	316
query54	2641	2483	2424	2424
query55	91	76	81	76
query56	211	209	177	177
query57	1169	1239	1066	1066
query58	215	198	197	197
query59	3398	3402	3314	3314
query60	213	191	189	189
query61	82	79	81	79
query62	890	467	460	460
query63	473	340	337	337
query64	2526	1478	1342	1342
query65	3648	3564	3572	3564
query66	816	376	367	367
query67	15591	15222	15071	15071
query68	8843	662	671	662
query69	579	347	345	345
query70	1507	1464	1408	1408
query71	405	298	308	298
query72	6408	3440	3408	3408
query73	739	329	316	316
query74	6305	5942	5791	5791
query75	5234	3696	3700	3696
query76	5407	1159	1234	1159
query77	909	255	250	250
query78	13276	11912	12460	11912
query79	10047	656	676	656
query80	755	391	380	380
query81	496	231	231	231
query82	1221	98	94	94
query83	158	132	130	130
query84	266	69	66	66
query85	776	297	277	277
query86	318	306	297	297
query87	3225	3073	3005	3005
query88	4774	2347	2344	2344
query89	437	307	292	292
query90	1993	216	202	202
query91	146	116	126	116
query92	62	53	53	53
query93	6059	618	561	561
query94	626	209	205	205
query95	1118	1102	1067	1067
query96	629	336	323	323
query97	6425	6336	6419	6336
query98	187	174	171	171
query99	2657	893	874	874
Total cold run time: 312570 ms
Total hot run time: 201667 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 90e0de78e5e0446528cab569081a6e364426b48f with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.5 seconds inserted 10000000 Rows, about 444K ops/s

@xiaokang xiaokang merged commit ea051cf into apache:branch-2.0 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants