[fix](RF) fix 'Invalid value' error of RF of datetimev2 type for max value #32649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38027 ms |
TPC-DS: Total hot run time: 181620 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
reviewed
Mar 22, 2024
| case TYPE_DATETIMEV2: { | ||
| THROW_IF_ERROR(create_texpr_literal_node<TYPE_DATETIMEV2>(data, &node)); | ||
| THROW_IF_ERROR(create_texpr_literal_node<TYPE_DATETIMEV2>(data, &node, precision, scale)); | ||
| break; |
Contributor
There was a problem hiding this comment.
table1 probe:
2011-11-11 11:11:11.123456
table2 build:
2011-11-11 11:11:11.123455
yiguolei
reviewed
Mar 22, 2024
| @@ -97,11 +97,11 @@ TExprNode create_texpr_node_from(const void* data, const PrimitiveType& type, in | |||
| break; | |||
| } | |||
| case TYPE_DATEV2: { | |||
Contributor
There was a problem hiding this comment.
TODOs:
- verify datev1 and datetimev1 have precision ？？？
- table1 is datev2 and table2 is datev2 ， generate runtime filter。
- table1 is datetimev2 and table2 is datetimev2 ， generate runtime filter。
yiguolei
reviewed
Mar 22, 2024
| """ | ||
| sql """ | ||
| CREATE TABLE `rftest_r` ( | ||
| `k1_char` varchar(64) |
Contributor
There was a problem hiding this comment.
rftest_r （string） ---> build hash table (datetimev2(0)) ---> min max (9999-12-31 23:59:59:999999) --->
consumer: liternal (9999-12-31 23:59:59:999999) (datetimev2(0))
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37983 ms |
TPC-DS: Total hot run time: 181480 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
xiaokang
pushed a commit
that referenced
this pull request
Mar 22, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 22, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
9999-12-31 23:59:59.999999for type DateTimeV2(0) will round and overflow, and will result in errorInvalid value: 9999-12-31 23:59:59.999999 for type DateTimeV2'Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...