[Bug] Avoid compacting recently added rowset #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaodayue
added
kind/fix
imay
reviewed
Apr 7, 2020
Contributor
Contributor
Author
|
@imay that's great, let me rebase |
gaodayue
force-pushed
the
compaction_skip_window_pr
branch
from
64e1cb0 to
57befd2
Compare
Contributor
|
I have run this UT manually, and it is successful. |
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
This CL fixes apache#3270 by skipping recently added version when performing cumulative compaction. A new config named "cumulative_compaction_skip_window_seconds" is added to adjust the time window.
imay
pushed a commit
to StarRocks/starrocks
that referenced
this pull request
Sep 21, 2022
…conds (#11490) cumulative_compaction_skip_window_seconds introduced by apache/doris#3271. At that time, it can not acquire rowset version after compaction, but now we can acquire from _stale_rs_version_map. so that this config is useless now.
mergify bot
pushed a commit
to StarRocks/starrocks
that referenced
this pull request
Oct 24, 2022
…conds (#11490) cumulative_compaction_skip_window_seconds introduced by apache/doris#3271. At that time, it can not acquire rowset version after compaction, but now we can acquire from _stale_rs_version_map. so that this config is useless now. (cherry picked from commit 22af105) # Conflicts: # be/src/storage/base_and_cumulative_compaction_policy.cpp
mergify bot
pushed a commit
to StarRocks/starrocks
that referenced
this pull request
Oct 24, 2022
…conds (#11490) cumulative_compaction_skip_window_seconds introduced by apache/doris#3271. At that time, it can not acquire rowset version after compaction, but now we can acquire from _stale_rs_version_map. so that this config is useless now. (cherry picked from commit 22af105) # Conflicts: # be/src/storage/base_and_cumulative_compaction_policy.cpp
mergify bot
pushed a commit
to StarRocks/starrocks
that referenced
this pull request
Oct 24, 2022
…conds (#11490) cumulative_compaction_skip_window_seconds introduced by apache/doris#3271. At that time, it can not acquire rowset version after compaction, but now we can acquire from _stale_rs_version_map. so that this config is useless now. (cherry picked from commit 22af105) # Conflicts: # be/src/storage/base_and_cumulative_compaction_policy.cpp # be/src/storage/cumulative_compaction.cpp # be/test/storage/cumulative_compaction_test.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes #3270 by skipping recently added version when performing cumulative compaction. A new config named "cumulative_compaction_skip_window_seconds" is added to adjust the time window.