Skip to content

[fix](Nereids) system default decimalv3 scale should be 9 #32754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Mar 26, 2024
Merged

[fix](Nereids) system default decimalv3 scale should be 9 #32754

morrySnow merged 1 commit into from
Mar 26, 2024

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Mar 25, 2024 •
edited
Loading

select round('1.1234', 2) should return 1.12, not 1

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

morrySnow commented Mar 25, 2024

run buildall

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Mar 25, 2024
@morrySnow
[fix](Nereids) system default decimalv3 scale should be 9
11002c3 
pick from master apache#32754
@morrySnow morrySnow added usercase Important user case type label dev/2.0.x labels Mar 25, 2024
@morrySnow morrySnow mentioned this pull request Mar 25, 2024
Merged
@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-H: Total hot run time: 38497 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 28f48817a9e422948b7f556d5bea7e6de73c10e6, data reload: false

------ Round 1 ----------------------------------
q1	17630	4347	4146	4146
q2	2111	158	173	158
q3	10801	1136	1231	1136
q4	10852	849	806	806
q5	7550	3124	3086	3086
q6	212	130	129	129
q7	1072	607	608	607
q8	9657	2027	2045	2027
q9	7390	6746	6747	6746
q10	9179	3481	3564	3481
q11	435	225	220	220
q12	413	200	210	200
q13	17790	2861	2856	2856
q14	230	201	215	201
q15	497	460	455	455
q16	505	374	373	373
q17	970	567	527	527
q18	7264	6559	6408	6408
q19	1580	1500	1441	1441
q20	562	265	250	250
q21	3556	3053	2948	2948
q22	349	296	302	296
Total cold run time: 110605 ms
Total hot run time: 38497 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4124	4094	4068	4068
q2	334	239	241	239
q3	2981	2836	2830	2830
q4	1846	1546	1593	1546
q5	5340	5360	5363	5360
q6	197	118	119	118
q7	2267	1853	1849	1849
q8	3192	3298	3284	3284
q9	8771	9003	8964	8964
q10	3939	3815	3717	3717
q11	544	436	461	436
q12	726	505	553	505
q13	16887	2846	2877	2846
q14	267	245	241	241
q15	505	464	462	462
q16	467	424	422	422
q17	1749	1516	1465	1465
q18	7545	7102	7211	7102
q19	1632	1508	1502	1502
q20	1924	1717	1718	1717
q21	4813	4836	4734	4734
q22	525	433	440	433
Total cold run time: 70575 ms
Total hot run time: 53840 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-DS: Total hot run time: 186281 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 28f48817a9e422948b7f556d5bea7e6de73c10e6, data reload: false

query1	943	373	356	356
query2	7398	2023	1895	1895
query3	6711	211	209	209
query4	32084	21450	21285	21285
query5	4283	400	398	398
query6	269	191	185	185
query7	4627	293	292	292
query8	234	174	180	174
query9	9177	2267	2263	2263
query10	593	251	244	244
query11	15518	14373	14374	14373
query12	140	100	83	83
query13	1640	440	408	408
query14	11730	11340	11487	11340
query15	262	206	197	197
query16	8251	264	264	264
query17	2003	590	548	548
query18	2096	294	290	290
query19	356	158	152	152
query20	93	91	91	91
query21	199	133	126	126
query22	5005	4792	4751	4751
query23	33298	32798	32348	32348
query24	10669	2831	2895	2831
query25	654	390	398	390
query26	1531	153	157	153
query27	2963	342	359	342
query28	7741	1871	1826	1826
query29	957	656	648	648
query30	305	148	147	147
query31	993	738	756	738
query32	94	59	61	59
query33	768	259	254	254
query34	1047	480	474	474
query35	838	612	607	607
query36	1018	899	901	899
query37	128	75	77	75
query38	3571	3470	3451	3451
query39	1486	1450	1416	1416
query40	295	117	112	112
query41	52	49	48	48
query42	103	95	96	95
query43	483	438	449	438
query44	1178	711	708	708
query45	261	259	279	259
query46	1109	732	705	705
query47	1895	1826	1849	1826
query48	442	356	350	350
query49	1220	358	352	352
query50	769	368	362	362
query51	6660	6644	6564	6564
query52	106	94	91	91
query53	342	276	277	276
query54	314	244	255	244
query55	89	80	77	77
query56	255	241	229	229
query57	1209	1152	1135	1135
query58	239	210	207	207
query59	2735	2562	2548	2548
query60	275	251	272	251
query61	118	115	132	115
query62	670	449	454	449
query63	309	281	279	279
query64	6694	3999	3953	3953
query65	3090	3065	3037	3037
query66	1434	352	355	352
query67	15643	14751	14969	14751
query68	8851	531	535	531
query69	622	390	388	388
query70	1220	1168	1162	1162
query71	522	287	275	275
query72	6326	2730	2563	2563
query73	1066	309	313	309
query74	8590	6669	6656	6656
query75	4382	2833	2825	2825
query76	5541	922	888	888
query77	643	272	259	259
query78	10956	10153	10180	10153
query79	12168	515	513	513
query80	1796	381	383	381
query81	513	214	215	214
query82	831	203	203	203
query83	219	148	143	143
query84	284	80	81	80
query85	1463	346	319	319
query86	427	280	306	280
query87	3745	3510	3525	3510
query88	5148	2290	2277	2277
query89	519	363	359	359
query90	2023	177	172	172
query91	169	140	138	138
query92	60	48	47	47
query93	7120	491	472	472
query94	1165	176	172	172
query95	425	319	318	318
query96	599	264	277	264
query97	3088	2882	2899	2882
query98	235	220	203	203
query99	1238	930	961	930
Total cold run time: 321616 ms
Total hot run time: 186281 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 28f48817a9e422948b7f556d5bea7e6de73c10e6 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.9 seconds inserted 10000000 Rows, about 456K ops/s

yiguolei
yiguolei previously approved these changes Mar 25, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow force-pushed the change_default_v3_scale branch from 28f4881 to 7ae8fef Compare March 25, 2024 10:27
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 25, 2024
@morrySnow
Copy link
Contributor Author

morrySnow commented Mar 25, 2024

run buildall

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Mar 25, 2024
@morrySnow
[fix](Nereids) system default decimalv3 scale should be 9
6e6d7c0 
pick from master apache#32754
@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-H: Total hot run time: 38540 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7ae8fef5420f562d8addb83b1f8e293c5731045b, data reload: false

------ Round 1 ----------------------------------
q1	17659	4709	4226	4226
q2	2882	166	160	160
q3	11709	1167	1248	1167
q4	11010	791	761	761
q5	7513	3142	3084	3084
q6	208	132	129	129
q7	1068	611	603	603
q8	9505	2057	2042	2042
q9	7303	6754	6691	6691
q10	8717	3589	3644	3589
q11	553	224	220	220
q12	376	211	201	201
q13	18177	2874	2873	2873
q14	249	206	201	201
q15	513	472	456	456
q16	498	372	369	369
q17	953	586	528	528
q18	7215	6521	6470	6470
q19	1890	1391	1414	1391
q20	537	249	248	248
q21	3581	2833	3000	2833
q22	349	300	298	298
Total cold run time: 112465 ms
Total hot run time: 38540 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4153	4054	4027	4027
q2	326	229	235	229
q3	2989	2892	2861	2861
q4	1867	1533	1587	1533
q5	5322	5364	5326	5326
q6	194	117	116	116
q7	2216	1844	1832	1832
q8	3185	3325	3279	3279
q9	8751	8704	8703	8703
q10	3755	3776	3777	3776
q11	561	440	444	440
q12	706	541	562	541
q13	16889	2851	2856	2851
q14	269	248	255	248
q15	505	455	457	455
q16	464	414	415	414
q17	1717	1500	1473	1473
q18	7367	7147	7140	7140
q19	2108	1524	1562	1524
q20	1891	1723	1707	1707
q21	4775	4736	4694	4694
q22	532	449	429	429
Total cold run time: 70542 ms
Total hot run time: 53598 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-DS: Total hot run time: 186741 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7ae8fef5420f562d8addb83b1f8e293c5731045b, data reload: false

query1	939	371	358	358
query2	6525	1929	1847	1847
query3	6709	208	211	208
query4	31851	21346	21319	21319
query5	4284	397	403	397
query6	280	186	180	180
query7	4629	289	290	289
query8	239	174	199	174
query9	9356	2254	2267	2254
query10	562	255	261	255
query11	14806	14262	14209	14209
query12	133	88	90	88
query13	1629	412	412	412
query14	11822	11641	11904	11641
query15	291	203	196	196
query16	8243	256	254	254
query17	1983	583	555	555
query18	2109	292	283	283
query19	342	166	177	166
query20	96	89	94	89
query21	204	131	129	129
query22	5064	4839	4745	4745
query23	33790	32847	32903	32847
query24	11864	2874	2825	2825
query25	669	388	397	388
query26	1799	156	159	156
query27	3159	360	354	354
query28	7468	1858	1860	1858
query29	1034	651	616	616
query30	302	149	149	149
query31	953	765	762	762
query32	92	60	57	57
query33	773	261	257	257
query34	1128	484	477	477
query35	825	608	614	608
query36	1024	875	893	875
query37	280	83	78	78
query38	3605	3431	3410	3410
query39	1482	1435	1404	1404
query40	287	113	115	113
query41	52	49	48	48
query42	108	98	98	98
query43	475	442	451	442
query44	1177	744	723	723
query45	264	261	261	261
query46	1126	686	694	686
query47	1924	1843	1834	1834
query48	460	359	340	340
query49	1238	340	343	340
query50	759	374	369	369
query51	6685	6618	6699	6618
query52	108	95	92	92
query53	350	277	287	277
query54	324	251	248	248
query55	85	80	75	75
query56	247	234	228	228
query57	1230	1146	1134	1134
query58	237	209	213	209
query59	2757	2706	2484	2484
query60	279	247	260	247
query61	117	112	114	112
query62	661	457	455	455
query63	303	277	283	277
query64	6390	3987	4090	3987
query65	3023	3023	3056	3023
query66	1418	365	347	347
query67	15326	14834	15077	14834
query68	9463	523	521	521
query69	681	400	365	365
query70	1433	1167	1110	1110
query71	510	275	264	264
query72	6625	2718	2557	2557
query73	1625	316	309	309
query74	6909	6455	6416	6416
query75	4857	2841	2856	2841
query76	5753	924	869	869
query77	649	267	267	267
query78	10912	10323	10245	10245
query79	10667	521	518	518
query80	1892	380	371	371
query81	513	221	215	215
query82	344	203	202	202
query83	216	146	138	138
query84	286	79	80	79
query85	1114	324	306	306
query86	367	284	313	284
query87	3749	3609	3541	3541
query88	4868	2277	2283	2277
query89	485	375	364	364
query90	2063	178	175	175
query91	170	136	134	134
query92	59	48	49	48
query93	6608	508	479	479
query94	1632	183	177	177
query95	441	335	329	329
query96	596	274	262	262
query97	3074	2876	2887	2876
query98	233	224	216	216
query99	1205	916	917	916
Total cold run time: 319752 ms
Total hot run time: 186741 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 7ae8fef5420f562d8addb83b1f8e293c5731045b with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

PR approved by at least one committer and no changes requested.

morrySnow added a commit that referenced this pull request Mar 25, 2024
@morrySnow
[fix](Nereids) system default decimalv3 scale should be 9 (#32756)
e930123 
pick from master #32754
@morrySnow morrySnow merged commit ba541c5 into apache:master Mar 26, 2024
@morrySnow morrySnow deleted the change_default_v3_scale branch March 26, 2024 01:51
yiguolei pushed a commit that referenced this pull request Mar 26, 2024
@morrySnow @Doris-Extras
[fix](Nereids) system default decimalv3 scale should be 9 (#32754)
6457a9a 
select round('1.1234', 2) should return 1.12, not 1
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morrySnow
[fix](Nereids) system default decimalv3 scale should be 9 (apache#32756)
79e6893 
pick from master apache#32754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.8-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @doris-robot @yiguolei @starocean999