Skip to content

[fix](planner)the decimal type's precision and scale of set operation node is wrong #32787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 26, 2024
Merged

[fix](planner)the decimal type's precision and scale of set operation node is wrong #32787

yiguolei merged 1 commit into from
Mar 26, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Mar 25, 2024

…

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Mar 25, 2024

run buildall

@starocean999 starocean999 mentioned this pull request Mar 25, 2024
Merged
@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-H: Total hot run time: 38449 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e60fdc4ca323cf8d817ed91c537b00a64e691e1e, data reload: false

------ Round 1 ----------------------------------
q1	17677	4690	4278	4278
q2	2480	159	159	159
q3	11560	1137	1139	1137
q4	10520	848	812	812
q5	7915	3098	3084	3084
q6	206	127	125	125
q7	1082	598	594	594
q8	9482	2045	1985	1985
q9	7487	6801	6723	6723
q10	8609	3480	3570	3480
q11	427	236	222	222
q12	379	206	200	200
q13	17816	2861	2891	2861
q14	224	197	206	197
q15	509	473	459	459
q16	494	380	372	372
q17	966	598	560	560
q18	7313	6531	6385	6385
q19	1577	1383	1462	1383
q20	572	242	260	242
q21	3623	2898	2900	2898
q22	341	294	293	293
Total cold run time: 111259 ms
Total hot run time: 38449 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4104	4048	4077	4048
q2	327	232	232	232
q3	2992	2986	2895	2895
q4	1907	1647	1588	1588
q5	5425	5371	5324	5324
q6	201	115	117	115
q7	2254	1864	1835	1835
q8	3166	3277	3303	3277
q9	8742	8690	8693	8690
q10	3781	3797	3728	3728
q11	548	457	450	450
q12	726	533	565	533
q13	16913	2894	2841	2841
q14	275	254	252	252
q15	512	456	456	456
q16	484	410	416	410
q17	1725	1507	1464	1464
q18	7374	7246	7045	7045
q19	1617	1443	1566	1443
q20	1892	1716	1718	1716
q21	4872	4731	4790	4731
q22	519	446	461	446
Total cold run time: 70356 ms
Total hot run time: 53519 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

TPC-DS: Total hot run time: 186313 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e60fdc4ca323cf8d817ed91c537b00a64e691e1e, data reload: false

query1	950	372	350	350
query2	6534	1933	1826	1826
query3	6712	214	208	208
query4	31723	21428	21371	21371
query5	4328	406	391	391
query6	298	176	183	176
query7	4630	293	284	284
query8	254	172	185	172
query9	9254	2261	2243	2243
query10	573	251	246	246
query11	17154	14278	14384	14278
query12	133	97	83	83
query13	1617	411	415	411
query14	12391	11674	11547	11547
query15	293	194	189	189
query16	8248	262	271	262
query17	1971	580	546	546
query18	2112	290	290	290
query19	341	163	165	163
query20	95	88	88	88
query21	202	132	129	129
query22	5050	4921	4788	4788
query23	33535	32511	32598	32511
query24	11818	2907	2847	2847
query25	648	383	387	383
query26	1778	153	155	153
query27	2973	352	362	352
query28	7568	1872	1843	1843
query29	1045	668	624	624
query30	311	149	149	149
query31	960	751	733	733
query32	98	59	60	59
query33	775	261	250	250
query34	1043	496	484	484
query35	848	612	618	612
query36	989	875	872	872
query37	275	87	80	80
query38	3625	3457	3407	3407
query39	1496	1490	1461	1461
query40	288	121	112	112
query41	51	52	49	49
query42	109	97	100	97
query43	481	445	445	445
query44	1185	742	731	731
query45	288	252	254	252
query46	1121	717	714	714
query47	1912	1832	1861	1832
query48	456	357	347	347
query49	1234	342	344	342
query50	759	372	383	372
query51	6729	6653	6600	6600
query52	105	88	97	88
query53	352	276	284	276
query54	315	232	232	232
query55	95	76	74	74
query56	239	214	214	214
query57	1205	1128	1134	1128
query58	227	197	207	197
query59	2793	2577	2540	2540
query60	250	243	249	243
query61	95	92	92	92
query62	679	449	450	449
query63	309	285	285	285
query64	6756	3979	4035	3979
query65	3071	3019	3058	3019
query66	1409	371	360	360
query67	15293	14759	14790	14759
query68	5454	522	507	507
query69	548	361	378	361
query70	1194	1160	1185	1160
query71	424	263	269	263
query72	6098	2720	2591	2591
query73	703	320	324	320
query74	7529	6357	6411	6357
query75	3597	2791	2909	2791
query76	3521	887	936	887
query77	465	270	258	258
query78	10975	10202	10102	10102
query79	5337	521	527	521
query80	1773	402	395	395
query81	553	222	220	220
query82	941	220	203	203
query83	326	160	156	156
query84	292	84	84	84
query85	1842	384	374	374
query86	510	305	295	295
query87	3732	3539	3524	3524
query88	4649	2293	2272	2272
query89	483	374	371	371
query90	1990	176	178	176
query91	170	135	139	135
query92	66	49	48	48
query93	5060	499	471	471
query94	1254	179	177	177
query95	438	331	331	331
query96	598	263	273	263
query97	3089	2884	2877	2877
query98	231	215	216	215
query99	1216	945	919	919
Total cold run time: 307512 ms
Total hot run time: 186313 ms

@doris-robot
Copy link

doris-robot commented Mar 25, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e60fdc4ca323cf8d817ed91c537b00a64e691e1e with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@starocean999 starocean999 marked this pull request as ready for review March 26, 2024 02:04
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024

PR approved by anyone and no changes requested.

xiaokang pushed a commit that referenced this pull request Mar 26, 2024
@starocean999
[fix](planner)the decimal type's precision and scale of set operation…
c48d4f3 
… node is wrong #32787 (#32788)
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Mar 26, 2024
@starocean999 @Doris-Extras
[fix](planner)the decimal type's precision and scale of set operation…
c9a602a 
… node is wrong apache#32787 (apache#32788)
@yiguolei yiguolei merged commit 099eaa0 into apache:master Mar 26, 2024
yiguolei pushed a commit that referenced this pull request Mar 26, 2024
@starocean999 @Doris-Extras
[fix](planner)the decimal type of's precision and scale setope ration…
2d398df 
… codn is wrong (#32787)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@starocean999
[fix](planner)the decimal type's precision and scale of set operation…
1add7a0 
… node is wrong apache#32787 (apache#32788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.8-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starocean999 @doris-robot @yiguolei @morrySnow @xiaokang