[fix](cooldown) Fix bug in follow cooldowned data #32798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
gavinchou
approved these changes
Mar 25, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
platoneko
force-pushed
the
follow-cooldown
branch
from
964125a to
e21228b
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
|
TeamCity be ut coverage result: |
platoneko
force-pushed
the
follow-cooldown
branch
from
e21228b to
8757cf6
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37748 ms |
TPC-DS: Total hot run time: 181761 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The single replica cooldown protocal in Doris must maintain the invariant that cooldowned rowsets of a replica exactly corresponds to the cooldown meta id, however skipping rowsets with the same version when following cooldowned data would break this invariant. Modifying the code to skip rowsets with the same rowset id can maintain the invariant.
This PR also fix another potential data loss problem.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...