Skip to content

[fix](smooth-upgrade) Fix function now upgrade compatible #32807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 27, 2024
Merged

[fix](smooth-upgrade) Fix function now upgrade compatible #32807

yiguolei merged 1 commit into from
Mar 27, 2024

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Mar 25, 2024

Proposed changes

Issue Number: close #xxx

#22321 was forgotten to pick to branch-2.0 and make upgrade safe.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Mar 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Mar 26, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 26, 2024

TeamCity be ut coverage result:
Function Coverage: 35.26% (8738/24785)
Line Coverage: 27.05% (71543/264525)
Region Coverage: 26.29% (37112/141186)
Branch Coverage: 23.18% (18975/81872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/49eae844db8955e5713b59eb470ae4e3a3d33324_49eae844db8955e5713b59eb470ae4e3a3d33324/report/index.html

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Mar 26, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 26, 2024

TPC-H: Total hot run time: 38002 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 49eae844db8955e5713b59eb470ae4e3a3d33324, data reload: false

------ Round 1 ----------------------------------
q1	17640	4259	4136	4136
q2	2130	167	154	154
q3	10661	1168	1150	1150
q4	10254	792	811	792
q5	7470	3028	3016	3016
q6	202	125	125	125
q7	1055	583	572	572
q8	9338	1986	1987	1986
q9	7152	6593	6543	6543
q10	8420	3441	3547	3441
q11	431	236	225	225
q12	408	202	197	197
q13	17804	2837	2866	2837
q14	251	202	198	198
q15	519	475	474	474
q16	496	373	370	370
q17	959	586	559	559
q18	7176	6560	6408	6408
q19	4659	1452	1468	1452
q20	540	258	251	251
q21	3618	2953	2828	2828
q22	336	291	288	288
Total cold run time: 111519 ms
Total hot run time: 38002 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4131	4065	4084	4065
q2	325	235	230	230
q3	2971	2852	2841	2841
q4	1900	1604	1599	1599
q5	5332	5324	5319	5319
q6	196	117	117	117
q7	2232	1839	1871	1839
q8	3144	3273	3260	3260
q9	8700	8708	8632	8632
q10	3804	3776	3740	3740
q11	543	438	443	438
q12	732	581	516	516
q13	16923	2835	2879	2835
q14	279	256	257	256
q15	507	470	452	452
q16	486	422	414	414
q17	1730	1514	1487	1487
q18	7449	7298	7051	7051
q19	1623	1425	1538	1425
q20	1897	1733	1709	1709
q21	4809	4619	4654	4619
q22	528	452	434	434
Total cold run time: 70241 ms
Total hot run time: 53278 ms

@doris-robot
Copy link

doris-robot commented Mar 26, 2024

TPC-DS: Total hot run time: 181442 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 49eae844db8955e5713b59eb470ae4e3a3d33324, data reload: false

query1	938	372	344	344
query2	6541	1820	1861	1820
query3	6708	222	224	222
query4	31834	21390	21261	21261
query5	4329	403	409	403
query6	273	200	203	200
query7	4632	303	297	297
query8	235	169	174	169
query9	9080	2240	2247	2240
query10	553	247	261	247
query11	17260	14278	14235	14235
query12	142	90	87	87
query13	1613	427	410	410
query14	9800	7925	7730	7730
query15	250	198	193	193
query16	8187	267	267	267
query17	1945	579	551	551
query18	2107	295	278	278
query19	306	158	158	158
query20	91	89	98	89
query21	205	133	124	124
query22	5028	4748	4764	4748
query23	33408	32679	32764	32679
query24	11090	2845	2882	2845
query25	620	386	402	386
query26	1192	157	158	157
query27	2421	352	360	352
query28	7310	1869	1849	1849
query29	913	657	617	617
query30	304	154	149	149
query31	1027	728	735	728
query32	98	60	56	56
query33	760	255	253	253
query34	1005	507	480	480
query35	824	619	607	607
query36	1027	894	876	876
query37	117	62	61	61
query38	3590	3458	3463	3458
query39	1550	1556	1435	1435
query40	205	111	109	109
query41	51	45	45	45
query42	110	92	94	92
query43	474	447	432	432
query44	1152	745	725	725
query45	291	262	255	255
query46	1110	696	704	696
query47	1900	1832	1817	1817
query48	436	390	355	355
query49	1117	338	334	334
query50	762	371	375	371
query51	6729	6624	6660	6624
query52	120	100	90	90
query53	344	282	283	282
query54	299	238	240	238
query55	90	82	79	79
query56	248	220	221	220
query57	1198	1130	1136	1130
query58	229	203	209	203
query59	2894	2547	2612	2547
query60	264	266	249	249
query61	99	97	98	97
query62	669	447	455	447
query63	304	286	284	284
query64	5716	4000	4036	4000
query65	3087	3037	3045	3037
query66	864	365	357	357
query67	15276	14754	14716	14716
query68	5249	523	531	523
query69	567	384	390	384
query70	1207	1190	1137	1137
query71	436	276	271	271
query72	6396	2866	2697	2697
query73	699	331	320	320
query74	7298	6294	6344	6294
query75	2991	2196	2255	2196
query76	3550	911	875	875
query77	424	271	268	268
query78	10819	10142	10100	10100
query79	8584	532	536	532
query80	2182	394	395	394
query81	573	219	229	219
query82	1304	84	86	84
query83	321	146	150	146
query84	292	76	77	76
query85	1963	319	311	311
query86	500	265	293	265
query87	3748	3521	3519	3519
query88	5210	2392	2397	2392
query89	532	372	364	364
query90	1980	177	175	175
query91	173	139	138	138
query92	64	49	49	49
query93	6206	504	482	482
query94	1247	178	175	175
query95	449	336	335	335
query96	601	271	275	271
query97	2661	2467	2446	2446
query98	241	218	205	205
query99	1183	959	907	907
Total cold run time: 305001 ms
Total hot run time: 181442 ms

@doris-robot
Copy link

doris-robot commented Mar 26, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 49eae844db8955e5713b59eb470ae4e3a3d33324 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.2 seconds inserted 10000000 Rows, about 450K ops/s

@doris-robot
Copy link

doris-robot commented Mar 26, 2024

TeamCity be ut coverage result:
Function Coverage: 35.26% (8739/24784)
Line Coverage: 27.04% (71534/264517)
Region Coverage: 26.28% (37116/141221)
Branch Coverage: 23.18% (18976/81874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/49eae844db8955e5713b59eb470ae4e3a3d33324_49eae844db8955e5713b59eb470ae4e3a3d33324/report/index.html

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 26, 2024

run p0

shuke987
shuke987 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 2174912 into apache:master Mar 27, 2024
yiguolei pushed a commit that referenced this pull request Mar 27, 2024
@zclllyybb @Doris-Extras
[fix](smooth-upgrade) Fix function now upgrade compatible #32807
309de6c
@zclllyybb zclllyybb deleted the fix_upgrade branch March 27, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@shuke987 shuke987 shuke987 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zclllyybb @doris-robot @hello-stephen @yiguolei @HappenLee @shuke987