[opt](fqdn) Add DNS Cache for FE and BE #32869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Status::OK(); | ||
| } | ||
|
|
||
| void DNSCache::_refresh_cache() { |
Contributor
There was a problem hiding this comment.
warning: method '_refresh_cache' can be made const [readability-make-member-function-const]
Suggested change
| void DNSCache::_refresh_cache() { | |
| void DNSCache::_refresh_cache() const { |
be/src/util/dns_cache.h:41:
- void _refresh_cache();
+ void _refresh_cache() const;| ~DNSCache(); | ||
|
|
||
| // get ip by hostname | ||
| Status get(const std::string& hostname, std::string* ip); |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'Status' [clang-diagnostic-error]
Status get(const std::string& hostname, std::string* ip);
^|
|
||
| private: | ||
| // update the ip of hostname in cache | ||
| Status _update(const std::string& hostname); |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'Status' [clang-diagnostic-error]
Status _update(const std::string& hostname);
^| // update cache at fix internal | ||
| void _refresh_cache(); | ||
|
|
||
| private: |
Contributor
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
Suggested change
| private: |
Additional context
be/src/util/dns_cache.h:35: previously declared here
private:
^
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
| // update cache at fix internal | ||
| void _refresh_cache(); | ||
|
|
||
| private: |
Contributor
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
Suggested change
| private: |
Additional context
be/src/util/dns_cache.h:40: previously declared here
private:
^
TPC-H: Total hot run time: 38073 ms |
TPC-DS: Total hot run time: 181357 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38355 ms |
TPC-DS: Total hot run time: 181392 ms |
|
TeamCity be ut coverage result: |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 28, 2024
In previously, when enabling FQDN, Doris will call dns resolver to get IP from hostname
each time when 1) FE gets BE's grpc client. 2) BE gets other BE's brpc client.
So when in high concurrency case, the dns resolver be overloaded and failed to resolve hostname.
This PR mainly changes:
1. Add DNSCache for both FE and BE.
The DNSCache will run on every FE and BE node. It has a cache, key is hostname and value is IP.
Caller can get IP by hostname from this cache, and if hostname does not exist, it will try to resolve it
and update the cache.
In addition, DNSCache has a daemon thread to refresh the cache every 1 min, in case that the IP may
be changed at anytime.
There are other implements of this dns cache:
1. kaka11chen@36fed13
This is for BE side, but it does not handle the IP change case.
3. apache#28479
This is for FE side, but it can only work with Master FE. Other FE node will not be aware of the IP change.
And there are a bunch of BackendServiceProxy, this PR only handle cache in one of them.
morningman
added a commit
that referenced
this pull request
Mar 29, 2024
|
|
||
| DNSCache::DNSCache() { | ||
| refresh_thread = std::thread(&DNSCache::_refresh_cache, this); | ||
| refresh_thread.detach(); |
Contributor
There was a problem hiding this comment.
the detached thread can not be join by main thread
|
|
||
| DNSCache::~DNSCache() { | ||
| stop_refresh = true; | ||
| if (refresh_thread.joinable()) { |
Contributor
There was a problem hiding this comment.
not joinable, so DNECache will be destoried immediately
| std::unordered_set<std::string> keys; | ||
| { | ||
| std::shared_lock<std::shared_mutex> lock(mutex); | ||
| std::transform(cache.begin(), cache.end(), std::inserter(keys, keys.end()), |
Contributor
There was a problem hiding this comment.
it is very likely that object cache has already been destroyed, if main thread has already exited with --grace enabled.
| void DNSCache::_refresh_cache() { | ||
| while (!stop_refresh) { | ||
| // refresh every 1 min | ||
| std::this_thread::sleep_for(std::chrono::minutes(1)); |
Contributor
There was a problem hiding this comment.
btw, after _refresh_cache thread is joinable, when we stop BE with grace enabled, we will wait at least 1 min ...
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 7, 2024
In previously, when enabling FQDN, Doris will call dns resolver to get IP from hostname
each time when 1) FE gets BE's grpc client. 2) BE gets other BE's brpc client.
So when in high concurrency case, the dns resolver be overloaded and failed to resolve hostname.
This PR mainly changes:
1. Add DNSCache for both FE and BE.
The DNSCache will run on every FE and BE node. It has a cache, key is hostname and value is IP.
Caller can get IP by hostname from this cache, and if hostname does not exist, it will try to resolve it
and update the cache.
In addition, DNSCache has a daemon thread to refresh the cache every 1 min, in case that the IP may
be changed at anytime.
There are other implements of this dns cache:
1. kaka11chen@36fed13
This is for BE side, but it does not handle the IP change case.
3. apache#28479
This is for FE side, but it can only work with Master FE. Other FE node will not be aware of the IP change.
And there are a bunch of BackendServiceProxy, this PR only handle cache in one of them.
Closed
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In previously, when enabling FQDN, Doris will call dns resolver to get IP from hostname
each time when 1) FE gets BE's grpc client. 2) BE gets other BE's brpc client.
So when in high concurrency case, the dns resolver be overloaded and failed to resolve hostname.
This PR mainly changes:
The DNSCache will run on every FE and BE node. It has a cache, key is hostname and value is IP.
Caller can get IP by hostname from this cache, and if hostname does not exist, it will try to resolve it
and update the cache.
In addition, DNSCache has a daemon thread to refresh the cache every 1 min, in case that the IP may
be changed at anytime.
There are other implements of this dns cache:
kaka11chen@36fed13
This is for BE side, but it does not handle the IP change case.
[fix](proxy) Fix getProxy frequently parse hostname to ip #28479
This is for FE side, but it can only work with Master FE. Other FE node will not be aware of the IP change.
And there are a bunch of BackendServiceProxy, this PR only handle cache in one of them.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...