Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

The default delete bitmap cache is set to 100MB, which can be insufficient and cause performance issues when the amount of user data is large. To mitigate the problem of an inadequate cache, we will take the larger of 5% of the total memory and 100MB as the delete bitmap cache size.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.62% (8838/24815)
Line Coverage: 27.32% (72412/265029)
Region Coverage: 26.55% (37559/141448)
Branch Coverage: 23.36% (19155/82008)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d55c6ca553420591b368693ad74d343b198ce619_d55c6ca553420591b368693ad74d343b198ce619/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 37874 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d55c6ca553420591b368693ad74d343b198ce619, data reload: false

------ Round 1 ----------------------------------
q1	18451	4136	4205	4136
q2	2121	160	158	158
q3	10575	1163	1227	1163
q4	10238	746	769	746
q5	7479	2937	2920	2920
q6	207	126	128	126
q7	1061	581	573	573
q8	9341	2035	2013	2013
q9	6906	6344	6350	6344
q10	8417	3456	3603	3456
q11	430	213	228	213
q12	371	207	199	199
q13	17806	2867	2863	2863
q14	228	202	203	202
q15	529	471	462	462
q16	494	374	369	369
q17	956	538	608	538
q18	7172	6600	6555	6555
q19	1541	1449	1400	1400
q20	545	270	250	250
q21	3637	2960	2895	2895
q22	339	293	295	293
Total cold run time: 108844 ms
Total hot run time: 37874 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4097	4067	4075	4067
q2	328	230	223	223
q3	2984	2810	2862	2810
q4	1829	1571	1536	1536
q5	5197	5204	5252	5204
q6	194	116	116	116
q7	2205	1789	1854	1789
q8	3153	3272	3291	3272
q9	8348	8391	8386	8386
q10	3804	3827	3794	3794
q11	546	442	435	435
q12	719	544	588	544
q13	16905	2863	2873	2863
q14	287	254	257	254
q15	508	450	458	450
q16	474	402	431	402
q17	1731	1500	1502	1500
q18	7330	7153	7256	7153
q19	1600	1568	1522	1522
q20	1925	1742	1697	1697
q21	4642	4576	4659	4576
q22	544	473	436	436
Total cold run time: 69350 ms
Total hot run time: 53029 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181616 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d55c6ca553420591b368693ad74d343b198ce619, data reload: false

query1	935	370	354	354
query2	6556	1898	1940	1898
query3	6710	222	218	218
query4	31595	21329	21500	21329
query5	4322	406	403	403
query6	273	197	185	185
query7	4640	305	296	296
query8	230	180	178	178
query9	9604	2298	2322	2298
query10	561	258	265	258
query11	17238	14195	14252	14195
query12	141	98	91	91
query13	1633	431	428	428
query14	10061	7967	7640	7640
query15	329	183	184	183
query16	8241	266	258	258
query17	2057	574	553	553
query18	2117	295	282	282
query19	352	163	165	163
query20	101	92	88	88
query21	205	131	126	126
query22	4991	4797	4806	4797
query23	33767	32579	32727	32579
query24	11357	2915	2858	2858
query25	623	388	393	388
query26	1593	158	158	158
query27	2945	326	326	326
query28	7920	1916	1851	1851
query29	977	640	615	615
query30	305	150	149	149
query31	991	754	727	727
query32	96	59	59	59
query33	773	267	272	267
query34	1010	485	508	485
query35	920	694	686	686
query36	1048	924	900	900
query37	110	68	63	63
query38	3535	3451	3426	3426
query39	1593	1571	1581	1571
query40	287	109	111	109
query41	50	49	47	47
query42	103	95	95	95
query43	468	462	451	451
query44	1209	759	761	759
query45	289	265	250	250
query46	1100	715	699	699
query47	1952	1867	1866	1866
query48	462	358	363	358
query49	1190	350	340	340
query50	770	374	369	369
query51	6682	6601	6530	6530
query52	112	92	94	92
query53	345	273	279	273
query54	344	244	243	243
query55	93	78	86	78
query56	280	250	236	236
query57	1238	1146	1143	1143
query58	230	216	221	216
query59	2797	2616	2451	2451
query60	271	245	253	245
query61	118	115	117	115
query62	659	434	456	434
query63	300	279	278	278
query64	6338	4104	4093	4093
query65	3093	3042	3039	3039
query66	1407	392	358	358
query67	15535	14996	14802	14802
query68	9021	553	547	547
query69	641	381	399	381
query70	1389	1167	1070	1070
query71	522	259	264	259
query72	6590	2538	2377	2377
query73	1593	327	329	327
query74	6886	6424	6456	6424
query75	3958	2200	2226	2200
query76	5506	902	833	833
query77	640	260	274	260
query78	11094	10343	10196	10196
query79	9964	529	535	529
query80	1567	388	373	373
query81	512	211	218	211
query82	677	89	86	86
query83	212	146	142	142
query84	285	77	80	77
query85	1273	315	303	303
query86	391	285	297	285
query87	3716	3579	3527	3527
query88	4629	2412	2393	2393
query89	517	375	369	369
query90	2071	177	179	177
query91	173	131	139	131
query92	58	48	50	48
query93	6497	499	485	485
query94	1230	178	174	174
query95	401	308	316	308
query96	613	287	281	281
query97	2649	2498	2484	2484
query98	235	221	206	206
query99	1139	872	855	855
Total cold run time: 316826 ms
Total hot run time: 181616 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d55c6ca553420591b368693ad74d343b198ce619, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.09
query5	0.50	0.49	0.50
query6	1.14	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.50
query10	0.56	0.55	0.56
query11	0.12	0.08	0.09
query12	0.12	0.09	0.10
query13	0.58	0.58	0.57
query14	0.76	0.77	0.79
query15	0.81	0.79	0.79
query16	0.39	0.38	0.37
query17	1.00	0.95	0.94
query18	0.22	0.25	0.23
query19	1.78	1.62	1.69
query20	0.01	0.02	0.02
query21	15.55	0.59	0.56
query22	3.01	1.67	1.24
query23	17.05	0.80	0.76
query24	3.34	2.15	1.52
query25	0.26	0.41	0.10
query26	0.49	0.12	0.12
query27	0.03	0.04	0.04
query28	9.52	0.86	0.87
query29	12.51	3.15	3.24
query30	0.28	0.10	0.08
query31	2.81	0.35	0.34
query32	3.34	0.44	0.44
query33	2.77	2.78	2.84
query34	16.08	4.39	4.39
query35	4.44	4.47	4.44
query36	0.65	0.47	0.49
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 103.15 s
Total hot run time: 29.52 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d55c6ca553420591b368693ad74d343b198ce619 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.2 seconds inserted 10000000 Rows, about 704K ops/s

@zhannngchen zhannngchen changed the title [Enhancement](delete bitmap) Support dynamic delete bitmap cache [Enhancement](merge-on-write) Support dynamic delete bitmap cache Mar 29, 2024
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.56% (8841/24864)
Line Coverage: 27.29% (72489/265607)
Region Coverage: 26.50% (37521/141565)
Branch Coverage: 23.31% (19131/82060)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5822511ccbc5fbbdc815507757476451914d4f36_5822511ccbc5fbbdc815507757476451914d4f36/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38319 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5822511ccbc5fbbdc815507757476451914d4f36, data reload: false

------ Round 1 ----------------------------------
q1	17600	4452	4254	4254
q2	2063	188	186	186
q3	10441	1209	1150	1150
q4	10206	798	820	798
q5	7448	2749	2793	2749
q6	214	137	133	133
q7	1040	607	612	607
q8	9222	2025	2075	2025
q9	7378	6576	6477	6477
q10	8465	3420	3586	3420
q11	457	228	230	228
q12	451	212	211	211
q13	17776	2954	3024	2954
q14	284	235	245	235
q15	514	468	460	460
q16	563	390	385	385
q17	973	645	585	585
q18	7517	6764	6709	6709
q19	8023	1440	1452	1440
q20	668	307	308	307
q21	3497	2734	2714	2714
q22	348	292	306	292
Total cold run time: 115148 ms
Total hot run time: 38319 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4342	4188	4304	4188
q2	383	275	281	275
q3	3003	2705	2653	2653
q4	1872	1534	1519	1519
q5	5297	5231	5259	5231
q6	210	123	124	123
q7	2247	1866	1866	1866
q8	3262	3316	3331	3316
q9	8522	8597	8638	8597
q10	4029	3853	3894	3853
q11	606	524	498	498
q12	800	633	616	616
q13	17771	3238	3120	3120
q14	311	301	286	286
q15	521	469	488	469
q16	538	474	456	456
q17	1805	1454	1487	1454
q18	8203	8087	7913	7913
q19	1624	1527	1581	1527
q20	2041	1867	1798	1798
q21	9985	4895	4923	4895
q22	551	462	479	462
Total cold run time: 77923 ms
Total hot run time: 55115 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183043 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5822511ccbc5fbbdc815507757476451914d4f36, data reload: false

query1	1254	1124	1127	1124
query2	6594	2214	1897	1897
query3	6663	226	211	211
query4	23489	21427	21399	21399
query5	4131	405	401	401
query6	277	194	183	183
query7	4610	296	302	296
query8	242	185	175	175
query9	8468	2282	2270	2270
query10	407	235	230	230
query11	14937	14199	14211	14199
query12	136	89	89	89
query13	1626	358	371	358
query14	8802	6829	7006	6829
query15	213	173	171	171
query16	7207	281	265	265
query17	1026	583	570	570
query18	1908	298	277	277
query19	214	160	157	157
query20	95	90	94	90
query21	200	132	135	132
query22	4992	4897	4857	4857
query23	33248	32762	32733	32733
query24	11714	2990	2972	2972
query25	611	406	425	406
query26	723	169	158	158
query27	3208	380	379	379
query28	6222	1921	1908	1908
query29	925	657	627	627
query30	324	166	159	159
query31	1009	736	734	734
query32	96	65	62	62
query33	637	274	291	274
query34	898	484	500	484
query35	858	722	722	722
query36	1078	929	935	929
query37	109	76	68	68
query38	3852	3684	3635	3635
query39	1643	1618	1591	1591
query40	187	131	130	130
query41	48	46	51	46
query42	107	110	101	101
query43	524	468	460	460
query44	1146	742	742	742
query45	278	283	286	283
query46	1113	708	706	706
query47	2034	1928	1936	1928
query48	394	310	333	310
query49	885	382	372	372
query50	801	401	420	401
query51	6827	6721	6692	6692
query52	118	95	98	95
query53	357	285	289	285
query54	285	258	240	240
query55	80	76	81	76
query56	247	218	220	218
query57	1188	1147	1119	1119
query58	213	197	203	197
query59	2761	2741	2518	2518
query60	259	231	232	231
query61	92	86	93	86
query62	603	443	433	433
query63	301	274	272	272
query64	5168	4089	4082	4082
query65	3105	3058	3036	3036
query66	866	333	341	333
query67	15509	15063	15142	15063
query68	8550	530	538	530
query69	552	317	303	303
query70	1234	1219	1169	1169
query71	467	273	281	273
query72	6665	2615	2426	2426
query73	739	317	322	317
query74	6995	6539	6481	6481
query75	3565	2299	2331	2299
query76	4643	943	1057	943
query77	636	247	252	247
query78	10946	10241	10194	10194
query79	12082	522	516	516
query80	2002	416	429	416
query81	505	219	218	218
query82	836	92	97	92
query83	209	165	163	163
query84	251	83	82	82
query85	1264	263	260	260
query86	443	302	289	289
query87	3725	3512	3554	3512
query88	6035	2403	2378	2378
query89	522	374	359	359
query90	1933	175	175	175
query91	120	97	94	94
query92	66	48	48	48
query93	7177	504	495	495
query94	1178	184	177	177
query95	404	316	311	311
query96	596	272	270	270
query97	2686	2475	2504	2475
query98	235	216	219	216
query99	1152	839	871	839
Total cold run time: 298555 ms
Total hot run time: 183043 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5822511ccbc5fbbdc815507757476451914d4f36, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.23	0.05	0.04
query4	1.68	0.07	0.07
query5	0.48	0.48	0.50
query6	1.13	0.66	0.66
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.50
query10	0.56	0.56	0.56
query11	0.16	0.09	0.11
query12	0.14	0.11	0.11
query13	0.59	0.59	0.58
query14	0.80	0.77	0.78
query15	0.85	0.82	0.80
query16	0.34	0.37	0.36
query17	0.93	0.99	0.99
query18	0.23	0.24	0.24
query19	1.85	1.77	1.66
query20	0.02	0.01	0.02
query21	15.56	0.65	0.64
query22	2.57	2.38	2.41
query23	17.14	1.02	0.77
query24	1.11	0.20	0.22
query25	0.09	0.08	0.08
query26	0.24	0.17	0.16
query27	0.08	0.08	0.08
query28	14.11	0.94	0.93
query29	12.60	3.25	3.22
query30	0.28	0.09	0.09
query31	2.83	0.39	0.38
query32	3.26	0.45	0.45
query33	2.79	2.82	2.83
query34	16.66	4.42	4.45
query35	4.47	4.48	4.46
query36	0.60	0.46	0.47
query37	0.18	0.15	0.15
query38	0.15	0.14	0.14
query39	0.06	0.04	0.04
query40	0.18	0.15	0.14
query41	0.09	0.04	0.04
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 105.88 s
Total hot run time: 30.17 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 5822511ccbc5fbbdc815507757476451914d4f36 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.8 seconds inserted 10000000 Rows, about 724K ops/s

@Yukang-Lian
Copy link
Collaborator Author

run p0

2 similar comments
@Yukang-Lian
Copy link
Collaborator Author

run p0

@zhannngchen
Copy link
Contributor

run p0

…cient and cause performance issues when the amount of user data is large. To mitigate the problem of an inadequate cache, we will take the larger of 5% of the total memory and 100MB as the delete bitmap cache size.
@Yukang-Lian Yukang-Lian force-pushed the Dynamic_Delete_Bitmap_Mem branch from 5822511 to 87e2bcc Compare April 1, 2024 07:03
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38971 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87e2bcc34b5a16501699ad6b2bf5353a46767b4a, data reload: false

------ Round 1 ----------------------------------
q1	17614	4510	4094	4094
q2	2018	186	179	179
q3	10485	1297	1406	1297
q4	10211	919	1054	919
q5	7469	2990	2937	2937
q6	222	133	132	132
q7	1113	632	607	607
q8	9405	2100	2085	2085
q9	6720	6240	6151	6151
q10	8459	3521	3531	3521
q11	421	242	239	239
q12	380	216	212	212
q13	17784	2903	2931	2903
q14	279	248	246	246
q15	534	493	485	485
q16	512	407	387	387
q17	975	940	918	918
q18	7331	6481	6453	6453
q19	1630	1540	1705	1540
q20	596	319	320	319
q21	3617	3070	3039	3039
q22	368	316	308	308
Total cold run time: 108143 ms
Total hot run time: 38971 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4112	4078	4046	4046
q2	335	222	224	222
q3	2960	2977	2951	2951
q4	1876	1859	1856	1856
q5	5253	5231	5257	5231
q6	210	124	125	124
q7	2247	1835	1826	1826
q8	3239	3313	3303	3303
q9	8561	8479	8498	8479
q10	3777	4025	4027	4025
q11	574	456	505	456
q12	746	612	649	612
q13	16263	3184	3130	3130
q14	311	286	293	286
q15	547	479	509	479
q16	481	413	464	413
q17	1743	1786	1777	1777
q18	8366	7730	7592	7592
q19	1733	1724	1722	1722
q20	1991	1731	1760	1731
q21	5231	4967	4912	4912
q22	495	441	439	439
Total cold run time: 71051 ms
Total hot run time: 55612 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.56% (8843/24868)
Line Coverage: 27.28% (72504/265797)
Region Coverage: 26.48% (37523/141692)
Branch Coverage: 23.29% (19132/82150)
Coverage Report: http://coverage.selectdb-in.cc/coverage/87e2bcc34b5a16501699ad6b2bf5353a46767b4a_87e2bcc34b5a16501699ad6b2bf5353a46767b4a/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 182029 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87e2bcc34b5a16501699ad6b2bf5353a46767b4a, data reload: false

query1	1211	1115	1106	1106
query2	6211	2010	1968	1968
query3	6664	204	206	204
query4	24006	21324	21569	21324
query5	4219	400	391	391
query6	263	188	181	181
query7	4597	301	309	301
query8	233	181	186	181
query9	8455	2318	2307	2307
query10	452	265	264	264
query11	14955	14502	14399	14399
query12	143	91	101	91
query13	1615	378	379	378
query14	8484	7052	6914	6914
query15	207	174	186	174
query16	6781	272	265	265
query17	1011	627	578	578
query18	1859	292	284	284
query19	205	167	182	167
query20	101	95	106	95
query21	199	135	135	135
query22	4915	4723	4825	4723
query23	33878	32550	32747	32550
query24	12655	3192	3214	3192
query25	716	439	458	439
query26	1923	172	162	162
query27	3266	385	393	385
query28	6997	1974	1927	1927
query29	1247	633	608	608
query30	318	156	1074	156
query31	1031	770	759	759
query32	109	68	64	64
query33	751	269	250	250
query34	1447	508	529	508
query35	873	744	735	735
query36	1027	884	864	864
query37	166	85	81	81
query38	3701	3629	3552	3552
query39	1632	1751	1598	1598
query40	249	150	140	140
query41	52	47	47	47
query42	118	118	110	110
query43	448	415	412	412
query44	1165	747	742	742
query45	289	266	265	265
query46	1113	827	776	776
query47	1995	1878	1895	1878
query48	388	304	321	304
query49	893	380	378	378
query50	826	404	429	404
query51	7020	6880	6851	6851
query52	115	108	105	105
query53	375	301	303	301
query54	325	270	244	244
query55	95	82	82	82
query56	257	236	227	227
query57	1316	1194	1185	1185
query58	243	227	241	227
query59	2644	2397	2271	2271
query60	249	240	232	232
query61	94	90	91	90
query62	656	441	474	441
query63	305	279	285	279
query64	5833	3330	3118	3118
query65	3067	2994	3004	2994
query66	1311	317	309	309
query67	15546	15119	14825	14825
query68	9559	577	589	577
query69	617	332	318	318
query70	1386	1071	1083	1071
query71	503	271	270	270
query72	6960	2610	2425	2425
query73	1644	328	328	328
query74	6842	6363	6392	6363
query75	4048	2329	2259	2259
query76	6306	1086	1172	1086
query77	586	244	249	244
query78	11007	10214	10145	10145
query79	11848	525	528	525
query80	1673	420	418	418
query81	504	228	220	220
query82	374	102	104	102
query83	213	159	155	155
query84	263	91	87	87
query85	977	295	291	291
query86	374	309	284	284
query87	3696	3462	3554	3462
query88	4303	2375	2381	2375
query89	540	367	372	367
query90	1945	182	174	174
query91	132	107	105	105
query92	60	56	50	50
query93	6691	521	527	521
query94	1254	200	193	193
query95	434	326	334	326
query96	619	281	273	273
query97	2656	2497	2485	2485
query98	228	212	213	212
query99	1243	830	821	821
Total cold run time: 304995 ms
Total hot run time: 182029 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87e2bcc34b5a16501699ad6b2bf5353a46767b4a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.04	0.05
query4	1.68	0.08	0.08
query5	0.47	0.49	0.49
query6	1.15	0.66	0.65
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.50	0.50
query10	0.56	0.58	0.56
query11	0.14	0.11	0.11
query12	0.13	0.11	0.12
query13	0.60	0.59	0.61
query14	0.77	0.78	0.79
query15	0.86	0.85	0.84
query16	0.35	0.36	0.35
query17	0.99	0.99	0.99
query18	0.24	0.24	0.26
query19	1.86	1.72	1.74
query20	0.02	0.01	0.01
query21	15.40	0.74	0.73
query22	3.44	5.73	2.01
query23	17.73	1.38	1.10
query24	1.45	0.22	0.21
query25	0.14	0.10	0.09
query26	0.28	0.16	0.18
query27	0.09	0.08	0.08
query28	13.85	1.00	0.94
query29	12.73	3.28	3.30
query30	0.26	0.06	0.06
query31	2.85	0.38	0.38
query32	3.28	0.48	0.47
query33	2.88	2.87	2.93
query34	15.49	4.32	4.33
query35	4.38	4.38	4.39
query36	0.68	0.47	0.48
query37	0.21	0.18	0.19
query38	0.17	0.17	0.15
query39	0.05	0.04	0.04
query40	0.18	0.15	0.17
query41	0.10	0.05	0.05
query42	0.05	0.06	0.05
query43	0.05	0.05	0.04
Total cold run time: 106.55 s
Total hot run time: 30.39 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 87e2bcc34b5a16501699ad6b2bf5353a46767b4a with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       17.3 seconds inserted 10000000 Rows, about 578K ops/s

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39280 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 067975ee3b4a196a2df2b9cdcdd0c715ce28fe48, data reload: false

------ Round 1 ----------------------------------
q1	18006	4261	4227	4227
q2	2253	195	186	186
q3	11174	1367	1464	1367
q4	10778	939	1093	939
q5	7836	3023	3010	3010
q6	228	137	134	134
q7	1156	651	653	651
q8	9791	2049	2055	2049
q9	6650	6173	6180	6173
q10	8416	3534	3514	3514
q11	413	248	238	238
q12	381	218	212	212
q13	17768	2902	2875	2875
q14	282	250	235	235
q15	532	493	491	491
q16	489	383	375	375
q17	974	914	893	893
q18	7938	6616	6483	6483
q19	1581	1555	1530	1530
q20	607	310	310	310
q21	3560	3132	3086	3086
q22	365	302	314	302
Total cold run time: 111178 ms
Total hot run time: 39280 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4112	4066	4052	4052
q2	338	214	219	214
q3	2967	2956	2982	2956
q4	1869	1851	1833	1833
q5	5256	5250	5214	5214
q6	208	124	126	124
q7	2251	1837	1814	1814
q8	3215	3304	3305	3304
q9	8505	8453	8463	8453
q10	3778	3844	3869	3844
q11	539	454	474	454
q12	726	580	542	542
q13	8525	2871	2895	2871
q14	305	247	282	247
q15	504	473	474	473
q16	467	401	393	393
q17	1718	1718	1689	1689
q18	7744	7290	7244	7244
q19	1634	1633	1636	1633
q20	1959	1739	1731	1731
q21	5026	4726	4808	4726
q22	494	418	415	415
Total cold run time: 62140 ms
Total hot run time: 54226 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182559 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 067975ee3b4a196a2df2b9cdcdd0c715ce28fe48, data reload: false

query1	1227	1117	1125	1117
query2	6474	1935	1865	1865
query3	6670	213	226	213
query4	24092	21534	21422	21422
query5	4197	419	392	392
query6	267	196	177	177
query7	4600	312	297	297
query8	233	176	182	176
query9	8468	2326	2346	2326
query10	584	265	273	265
query11	14862	14598	14389	14389
query12	140	96	93	93
query13	1633	404	379	379
query14	8571	6682	6773	6682
query15	206	173	182	173
query16	7160	286	275	275
query17	995	614	581	581
query18	1902	288	292	288
query19	211	159	163	159
query20	96	97	94	94
query21	206	130	132	130
query22	5088	4914	4905	4905
query23	33316	32825	32757	32757
query24	12548	3134	3193	3134
query25	702	396	405	396
query26	1925	167	160	160
query27	3001	332	333	332
query28	6742	1898	1881	1881
query29	1397	599	594	594
query30	305	149	157	149
query31	983	736	746	736
query32	97	61	58	58
query33	713	268	253	253
query34	1017	501	491	491
query35	815	711	713	711
query36	974	888	863	863
query37	283	80	73	73
query38	3525	3416	3427	3416
query39	1582	1550	1530	1530
query40	293	139	143	139
query41	50	45	48	45
query42	111	106	103	103
query43	444	408	398	398
query44	1086	717	716	716
query45	288	260	262	260
query46	1066	817	785	785
query47	1888	1835	1789	1789
query48	395	317	320	317
query49	1155	383	362	362
query50	790	396	398	396
query51	6856	6773	6770	6770
query52	109	104	100	100
query53	361	296	287	287
query54	323	252	243	243
query55	89	86	82	82
query56	238	228	228	228
query57	1218	1132	1104	1104
query58	256	241	234	234
query59	2591	2682	2418	2418
query60	255	246	252	246
query61	117	112	112	112
query62	711	447	439	439
query63	309	287	288	287
query64	6450	3217	3189	3189
query65	3081	3009	3028	3009
query66	1459	341	331	331
query67	15673	14962	14965	14962
query68	9128	578	598	578
query69	568	335	337	335
query70	1403	1131	1098	1098
query71	501	269	277	269
query72	6427	2580	2399	2399
query73	1572	331	329	329
query74	6755	6414	6305	6305
query75	3544	2281	2289	2281
query76	5387	1076	1208	1076
query77	604	253	248	248
query78	10811	10116	10245	10116
query79	8480	534	525	525
query80	1422	438	415	415
query81	496	1068	219	219
query82	382	114	105	105
query83	219	165	160	160
query84	271	88	91	88
query85	1023	288	289	288
query86	366	320	282	282
query87	3737	3518	3472	3472
query88	3838	2377	2377	2377
query89	557	375	392	375
query90	2034	173	180	173
query91	134	106	104	104
query92	57	50	57	50
query93	6581	545	540	540
query94	1263	192	188	188
query95	1094	1092	1092	1092
query96	611	272	275	272
query97	2647	2487	2477	2477
query98	240	220	218	218
query99	1235	825	822	822
Total cold run time: 298856 ms
Total hot run time: 182559 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.56% (8843/24870)
Line Coverage: 27.29% (72534/265772)
Region Coverage: 26.49% (37547/141722)
Branch Coverage: 23.30% (19144/82166)
Coverage Report: http://coverage.selectdb-in.cc/coverage/067975ee3b4a196a2df2b9cdcdd0c715ce28fe48_067975ee3b4a196a2df2b9cdcdd0c715ce28fe48/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 31.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 067975ee3b4a196a2df2b9cdcdd0c715ce28fe48, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.69	0.07	0.06
query5	0.48	0.48	0.49
query6	1.16	0.66	0.65
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.55	0.49	0.51
query10	0.57	0.57	0.56
query11	0.15	0.11	0.11
query12	0.13	0.11	0.12
query13	0.62	0.59	0.59
query14	0.77	0.79	0.79
query15	0.87	0.85	0.85
query16	0.36	0.35	0.35
query17	0.96	0.98	1.01
query18	0.26	0.26	0.26
query19	1.79	1.70	1.72
query20	0.01	0.01	0.02
query21	15.41	0.79	0.67
query22	2.77	5.62	3.38
query23	17.65	1.26	1.12
query24	1.91	0.22	0.22
query25	0.13	0.09	0.08
query26	0.28	0.17	0.18
query27	0.08	0.09	0.08
query28	13.38	0.94	0.93
query29	12.76	3.29	3.30
query30	0.24	0.05	0.06
query31	2.88	0.39	0.40
query32	3.26	0.48	0.47
query33	2.85	2.91	2.95
query34	15.48	4.37	4.32
query35	4.37	4.35	4.37
query36	0.68	0.48	0.48
query37	0.20	0.17	0.18
query38	0.16	0.16	0.15
query39	0.05	0.05	0.04
query40	0.18	0.15	0.15
query41	0.10	0.05	0.06
query42	0.05	0.05	0.06
query43	0.04	0.05	0.04
Total cold run time: 105.69 s
Total hot run time: 31.72 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 067975ee3b4a196a2df2b9cdcdd0c715ce28fe48 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       16.2 seconds inserted 10000000 Rows, about 617K ops/s

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2517cea into apache:master Apr 1, 2024
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
…2991)

* The default delete bitmap cache is set to 100MB, which can be insufficient and cause performance issues when the amount of user data is large. To mitigate the problem of an inadequate cache, we will take the larger of 5% of the total memory and 100MB as the delete bitmap cache size.
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
…2991)

* The default delete bitmap cache is set to 100MB, which can be insufficient and cause performance issues when the amount of user data is large. To mitigate the problem of an inadequate cache, we will take the larger of 5% of the total memory and 100MB as the delete bitmap cache size.
@yiguolei yiguolei mentioned this pull request Apr 26, 2024
1 task
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Jul 10, 2024
…ache#32991)

* The default delete bitmap cache is set to 100MB, which can be insufficient and cause performance issues when the amount of user data is large. To mitigate the problem of an inadequate cache, we will take the larger of 5% of the total memory and 100MB as the delete bitmap cache size.
dataroaring pushed a commit that referenced this pull request Jul 13, 2024
… dynamic delete bitmap cache (#32991)" (#37602)

The default delete bitmap cache is set to 100MB, which can be
insufficient and cause performance issues when the amount of user data
is large. To mitigate the problem of an inadequate cache, we will take
the larger of 5% of the total memory and 100MB as the delete bitmap
cache size.

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
… dynamic delete bitmap cache (apache#32991)" (apache#37602)

The default delete bitmap cache is set to 100MB, which can be
insufficient and cause performance issues when the amount of user data
is large. To mitigate the problem of an inadequate cache, we will take
the larger of 5% of the total memory and 100MB as the delete bitmap
cache size.

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.13-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants