Skip to content

[fix](load) skip cancel rpc if stub is not initialized #33006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaijchen wants to merge 1 commit into from
Closed

[fix](load) skip cancel rpc if stub is not initialized #33006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions be/src/vec/sink/vtablet_sink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,10 @@ void VNodeChannel::cancel(const std::string& cancel_msg) {
// But do we need brpc::StartCancel(call_id)?
_cancel_with_msg(cancel_msg);

if (_stub == nullptr) {
Copy link
Contributor

@cambyzju cambyzju Mar 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_stub is created in VNodeChannel::init, if _stub is null, it will set _is_closed to true.
We should not reach here normally.

If we do not find the root cause, please add some comments and logs here.

Copy link
Member Author

@kaijchen kaijchen Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was initially fixed in #30915 and later changed in #33006.
There is no more additional information in the latest Jira CIR-8301.

Copy link
Contributor

@liaoxin01 liaoxin01 Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @cambyzju. We should not reach here.

Copy link
Member Author

@kaijchen kaijchen May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancel() could be called when _inited = false, see #34897 (fixed in that PR)

return;
}

PTabletWriterCancelRequest request;
request.set_allocated_id(&_parent->_load_id);
request.set_index_id(_index_channel->_index_id);
Expand Down