-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](parquet)Skip page with offset index #33082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](parquet)Skip page with offset index #33082
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
can you add some test case in UT or Regression? |
7362f16 to
7a6808a
Compare
bc447bc to
d609254
Compare
|
LGTM |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
ed38bbc to
ee402f1
Compare
|
run buildall |
ClickBench: Total hot run time: 31.32 s |
|
run buildall |
1 similar comment
|
run buildall |
acadd36 to
0e2294f
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Need to add some test methods |
Make skip_page() in ColumnChunkReader more efficient. No more reading page headers if there are pagelocations in chunk.
Proposed changes
Make skip_page() in ColumnChunkReader more efficient. No more reading page headers if there are pagelocations in chunk.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...