Skip to content

[Bug] Use equals() method to judge whether "type" are equal #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 5 commits into from
Apr 15, 2020
Merged

[Bug] Use equals() method to judge whether "type" are equal #3310

morningman merged 5 commits into from
Apr 15, 2020

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 13, 2020 •
edited
Loading

I don't why, but I found that sometimes when I use "==" to judge the equality of type,
it return false, even if the types are exactly same.

ISSUE: #3309

This CL only changes == to equals() to solve the problem, but the reason is still unknown.

@morningman
[Bug] Use equals() method to judge whether "type" are equal
275be1b 
I don't why, but I found that sometimes when I use "==" to judge the equality of type,
it return false, even if the types are exactly same.
@imay
Copy link
Contributor

imay commented Apr 13, 2020

@morningman
I think we should replace all == compare with equals. == returns true only when the two sides refer the same object. I think all the type compare means to test if they are the same type, not the same object.

@morningman
Copy link
Contributor Author

morningman commented Apr 13, 2020

@morningman
I think we should replace all == compare with equals. == returns true only when the two sides refer the same object. I think all the type compare means to test if they are the same type, not the same object.

I agree. I am just puzzled why they are not the same object. I think they should be....

@imay
Copy link
Contributor

imay commented Apr 13, 2020

I agree. I am just puzzled why they are not the same object. I think they should be....

Without knowing why, we can still make Doris work in the right way.
So we can move it to another issue to investigate later on.

@morningman
Copy link
Contributor Author

morningman commented Apr 13, 2020

I agree. I am just puzzled why they are not the same object. I think they should be....

Without knowing why, we can still make Doris work in the right way.
So we can move it to another issue to investigate later on.

OK, I will try to find out all == and change them to equals()

@morningman morningman linked an issue Apr 14, 2020 that may be closed by this pull request
[Bug] errCode = 2, detailMessage = errCode = 2, detailMessage = date literal [2020-03-06] is invalid #3309
Closed
@kangpinghuang
Copy link
Contributor

kangpinghuang commented Apr 14, 2020

I think we should add some unit tests.

@morningman
Copy link
Contributor Author

morningman commented Apr 14, 2020

I think we should add some unit tests.

OK, I added a case described in #3309

kangkaisen
kangkaisen approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM

kangpinghuang
kangpinghuang approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@kangpinghuang kangpinghuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,LGTM

@morningman morningman merged commit e617937 into apache:master Apr 15, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
@morningman @WingsGo
[Bug] Use equals() method to judge whether "type" are equal (apache#3310
5b82e75 
)

I don't why, but I found that sometimes when I use "==" to judge the equality of type,
it return false, even if the types are exactly same.

ISSUE: apache#3309

This CL only changes == to equals() to solve the problem, but the reason is still unknown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@kangpinghuang kangpinghuang kangpinghuang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] errCode = 2, detailMessage = errCode = 2, detailMessage = date literal [2020-03-06] is invalid

4 participants

@morningman @imay @kangpinghuang @kangkaisen