Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Apr 1, 2024

Proposed changes

support

begin;
delete from t1 where ...;
delete from t2 using ...;
insert into t3 select ...;
commit;

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Apr 1, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38542 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4baa249bcbda4707f5d21288b7d802bd0da58639, data reload: false

------ Round 1 ----------------------------------
q1	17680	4082	4061	4061
q2	2033	188	190	188
q3	10475	1247	1414	1247
q4	10204	843	1067	843
q5	7473	2963	2901	2901
q6	216	133	133	133
q7	1110	617	631	617
q8	9413	2053	2020	2020
q9	6663	6195	6124	6124
q10	8471	3509	3492	3492
q11	429	244	246	244
q12	377	216	223	216
q13	17784	2882	2935	2882
q14	276	236	244	236
q15	538	487	488	487
q16	514	397	383	383
q17	952	923	894	894
q18	7179	6412	6386	6386
q19	1586	1531	1527	1527
q20	585	327	309	309
q21	3551	3156	3054	3054
q22	360	304	298	298
Total cold run time: 107869 ms
Total hot run time: 38542 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4075	4029	4035	4029
q2	328	218	237	218
q3	2953	2936	2949	2936
q4	1838	1821	1833	1821
q5	5212	5189	5195	5189
q6	208	125	122	122
q7	2264	1807	1784	1784
q8	3195	3276	3270	3270
q9	8500	8466	8451	8451
q10	3736	3930	3996	3930
q11	547	482	467	467
q12	750	614	564	564
q13	16946	3063	3100	3063
q14	300	276	296	276
q15	542	523	497	497
q16	514	463	461	461
q17	1768	1732	1725	1725
q18	8190	7695	7500	7500
q19	1680	1681	1684	1681
q20	2027	1819	1837	1819
q21	5215	4911	4964	4911
q22	485	422	448	422
Total cold run time: 71273 ms
Total hot run time: 55136 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181279 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4baa249bcbda4707f5d21288b7d802bd0da58639, data reload: false

query1	872	1127	1116	1116
query2	6336	1992	1898	1898
query3	6648	210	209	209
query4	24792	21508	21476	21476
query5	4182	394	395	394
query6	273	185	182	182
query7	4601	302	304	302
query8	237	190	181	181
query9	8463	2217	2213	2213
query10	428	251	256	251
query11	14907	14529	14533	14529
query12	141	101	98	98
query13	1615	374	380	374
query14	8571	6816	6884	6816
query15	213	192	183	183
query16	6850	284	279	279
query17	974	612	581	581
query18	1862	289	278	278
query19	213	162	171	162
query20	109	88	96	88
query21	193	136	130	130
query22	4919	4751	4751	4751
query23	33421	33086	32454	32454
query24	12481	3240	3188	3188
query25	698	439	446	439
query26	1927	171	178	171
query27	3186	387	383	383
query28	6880	1894	1866	1866
query29	1485	611	622	611
query30	309	164	156	156
query31	1036	768	748	748
query32	93	65	70	65
query33	716	273	252	252
query34	1032	499	514	499
query35	901	745	735	735
query36	999	909	872	872
query37	275	79	81	79
query38	3798	3576	3628	3576
query39	1092	1072	1072	1072
query40	237	146	141	141
query41	49	53	45	45
query42	113	119	105	105
query43	457	433	417	417
query44	1102	726	728	726
query45	286	269	282	269
query46	1120	840	799	799
query47	1978	1919	1856	1856
query48	395	318	327	318
query49	983	364	390	364
query50	832	407	434	407
query51	7055	6849	6859	6849
query52	108	102	102	102
query53	386	302	303	302
query54	301	255	244	244
query55	87	77	88	77
query56	263	244	234	234
query57	1277	1177	1181	1177
query58	238	238	231	231
query59	2699	2457	2628	2457
query60	247	224	235	224
query61	88	101	87	87
query62	656	465	446	446
query63	306	285	290	285
query64	5873	3046	3342	3046
query65	3018	3042	3015	3015
query66	1310	315	313	313
query67	15476	14771	14757	14757
query68	8892	572	575	572
query69	557	326	330	326
query70	1198	1118	1068	1068
query71	513	274	292	274
query72	6266	2596	2412	2412
query73	797	319	322	319
query74	6782	6283	6299	6283
query75	3432	2294	2325	2294
query76	5400	1123	1213	1123
query77	565	246	247	246
query78	10787	10138	10104	10104
query79	9223	528	534	528
query80	1785	423	415	415
query81	496	1068	221	221
query82	294	102	102	102
query83	196	162	160	160
query84	275	90	92	90
query85	926	290	281	281
query86	354	278	300	278
query87	3701	3520	3439	3439
query88	3645	2266	2280	2266
query89	545	382	382	382
query90	2054	175	182	175
query91	131	104	105	104
query92	56	55	52	52
query93	6734	525	534	525
query94	1195	193	196	193
query95	448	343	335	335
query96	594	278	269	269
query97	2647	2455	2460	2455
query98	240	214	209	209
query99	1173	829	830	829
Total cold run time: 296569 ms
Total hot run time: 181279 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4baa249bcbda4707f5d21288b7d802bd0da58639, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.48	0.49	0.48
query6	1.15	0.65	0.65
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.56	0.51	0.52
query10	0.57	0.57	0.55
query11	0.15	0.11	0.11
query12	0.13	0.11	0.11
query13	0.61	0.59	0.59
query14	0.77	0.79	0.78
query15	0.86	0.84	0.84
query16	0.36	0.36	0.36
query17	0.97	0.98	0.99
query18	0.26	0.26	0.26
query19	1.85	1.76	1.74
query20	0.01	0.01	0.02
query21	15.40	0.74	0.67
query22	3.00	4.67	2.47
query23	18.00	1.33	1.14
query24	1.36	0.28	0.24
query25	0.12	0.09	0.08
query26	0.28	0.17	0.19
query27	0.08	0.08	0.08
query28	13.71	0.95	0.94
query29	12.63	3.50	3.26
query30	0.25	0.06	0.05
query31	2.87	0.39	0.39
query32	3.28	0.48	0.47
query33	2.84	2.89	2.92
query34	15.48	4.32	4.31
query35	4.37	4.35	4.37
query36	0.65	0.46	0.47
query37	0.22	0.17	0.17
query38	0.15	0.17	0.16
query39	0.04	0.04	0.05
query40	0.18	0.16	0.15
query41	0.10	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 105.95 s
Total hot run time: 30.84 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4baa249bcbda4707f5d21288b7d802bd0da58639 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       16.2 seconds inserted 10000000 Rows, about 617K ops/s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Apr 1, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38645 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 33a9327b38dbbf490c99fce33079b21c93e3e60c, data reload: false

------ Round 1 ----------------------------------
q1	17679	4103	4029	4029
q2	2008	189	183	183
q3	10474	1249	1387	1249
q4	10211	889	1043	889
q5	7521	2964	2917	2917
q6	218	134	131	131
q7	1122	651	620	620
q8	9406	2054	2027	2027
q9	6612	6140	6121	6121
q10	8439	3501	3522	3501
q11	419	241	238	238
q12	379	219	213	213
q13	17779	2911	2935	2911
q14	269	245	243	243
q15	539	492	482	482
q16	509	379	370	370
q17	943	924	887	887
q18	7179	6468	6395	6395
q19	1604	1522	1534	1522
q20	609	314	314	314
q21	3507	3090	3135	3090
q22	367	322	313	313
Total cold run time: 107793 ms
Total hot run time: 38645 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4069	4056	4020	4020
q2	335	230	222	222
q3	2963	2957	2968	2957
q4	1844	1839	1834	1834
q5	5253	5201	5212	5201
q6	208	127	125	125
q7	2264	1813	1817	1813
q8	3199	3258	3256	3256
q9	8440	8466	8524	8466
q10	3777	3998	4020	3998
q11	581	469	458	458
q12	770	616	621	616
q13	16821	3129	3130	3129
q14	327	279	310	279
q15	541	527	515	515
q16	518	442	456	442
q17	1771	1738	1710	1710
q18	8239	7857	7697	7697
q19	1733	1710	1686	1686
q20	2053	1872	1854	1854
q21	5132	4990	5005	4990
q22	539	443	476	443
Total cold run time: 71377 ms
Total hot run time: 55711 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182726 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 33a9327b38dbbf490c99fce33079b21c93e3e60c, data reload: false

query1	2449	1122	1121	1121
query2	7553	1911	2031	1911
query3	8294	232	241	232
query4	27376	21672	21429	21429
query5	4159	404	411	404
query6	293	200	185	185
query7	4600	327	302	302
query8	228	176	178	176
query9	8439	2188	2192	2188
query10	407	243	242	242
query11	15064	14460	14352	14352
query12	143	94	96	94
query13	1614	370	381	370
query14	8881	7103	6953	6953
query15	197	173	174	173
query16	7322	282	272	272
query17	1482	605	578	578
query18	1523	301	292	292
query19	209	161	165	161
query20	96	94	94	94
query21	198	132	129	129
query22	5065	4937	4831	4831
query23	33384	32741	32719	32719
query24	8903	3125	3164	3125
query25	607	401	397	397
query26	795	163	165	163
query27	2761	357	372	357
query28	4860	1837	1811	1811
query29	957	607	605	605
query30	301	152	155	152
query31	978	745	755	745
query32	100	67	71	67
query33	569	244	267	244
query34	930	499	535	499
query35	848	717	761	717
query36	988	900	857	857
query37	120	79	80	79
query38	3692	3558	3554	3554
query39	1539	1489	1624	1489
query40	229	144	143	143
query41	49	47	46	46
query42	111	106	110	106
query43	459	428	421	421
query44	1113	742	726	726
query45	293	280	276	276
query46	1114	848	854	848
query47	2041	1939	1909	1909
query48	389	312	326	312
query49	959	370	387	370
query50	839	417	434	417
query51	6982	6865	6835	6835
query52	111	100	96	96
query53	359	286	297	286
query54	257	242	258	242
query55	94	83	73	73
query56	255	224	236	224
query57	1274	1197	1242	1197
query58	243	229	234	229
query59	2937	2735	2558	2558
query60	260	248	251	248
query61	129	89	92	89
query62	646	452	478	452
query63	313	303	294	294
query64	4192	3530	3439	3439
query65	3049	3023	3004	3004
query66	734	314	310	310
query67	15619	14922	14837	14837
query68	9010	571	598	571
query69	553	352	324	324
query70	1189	1072	1089	1072
query71	482	271	263	263
query72	6337	2602	2478	2478
query73	912	332	328	328
query74	6776	6507	6384	6384
query75	3355	2356	2274	2274
query76	5416	1102	1214	1102
query77	602	246	252	246
query78	11051	10198	10279	10198
query79	8685	532	531	531
query80	1390	441	440	440
query81	488	223	228	223
query82	751	106	109	106
query83	207	169	164	164
query84	273	98	93	93
query85	1199	287	295	287
query86	424	290	298	290
query87	3617	3508	3469	3469
query88	4057	2277	2278	2277
query89	552	371	363	363
query90	1904	174	177	174
query91	131	104	103	103
query92	59	50	52	50
query93	6551	538	532	532
query94	1024	194	196	194
query95	436	332	351	332
query96	610	268	268	268
query97	2680	2487	2531	2487
query98	239	218	215	215
query99	1322	832	846	832
Total cold run time: 295256 ms
Total hot run time: 182726 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 33a9327b38dbbf490c99fce33079b21c93e3e60c, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.07	0.07
query5	0.55	0.49	0.49
query6	1.12	0.66	0.66
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.55	0.57	0.56
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.62	0.59	0.60
query14	0.77	0.79	0.77
query15	0.86	0.84	0.83
query16	0.35	0.36	0.34
query17	1.01	0.98	1.00
query18	0.25	0.24	0.24
query19	1.82	1.77	1.74
query20	0.01	0.01	0.01
query21	15.40	0.76	0.71
query22	3.04	5.52	2.24
query23	17.67	1.36	1.05
query24	1.39	0.26	0.22
query25	0.13	0.09	0.08
query26	0.28	0.18	0.18
query27	0.08	0.09	0.08
query28	13.90	0.98	0.95
query29	12.61	3.32	3.35
query30	0.25	0.08	0.05
query31	2.84	0.38	0.38
query32	3.30	0.46	0.47
query33	2.78	2.90	2.85
query34	15.51	4.32	4.33
query35	4.36	4.36	4.36
query36	0.67	0.48	0.47
query37	0.19	0.18	0.17
query38	0.19	0.16	0.17
query39	0.05	0.04	0.04
query40	0.18	0.15	0.15
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 105.86 s
Total hot run time: 30.53 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 33a9327b38dbbf490c99fce33079b21c93e3e60c with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       17.1 seconds inserted 10000000 Rows, about 584K ops/s

dataroaring
dataroaring previously approved these changes Apr 1, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by anyone and no changes requested.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Apr 2, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 2, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 38797 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c94e031d527a3a405dded357e294bfa972a5ac2, data reload: false

------ Round 1 ----------------------------------
q1	17642	4123	4073	4073
q2	2020	192	184	184
q3	10641	1336	1397	1336
q4	10367	874	1035	874
q5	7478	3007	2938	2938
q6	221	134	135	134
q7	1113	633	604	604
q8	9413	2055	2028	2028
q9	6603	6216	6132	6132
q10	8397	3509	3501	3501
q11	414	238	235	235
q12	380	222	213	213
q13	17778	2903	2946	2903
q14	278	242	241	241
q15	547	484	477	477
q16	497	375	379	375
q17	960	916	915	915
q18	7663	6613	6403	6403
q19	1612	1546	1523	1523
q20	616	313	304	304
q21	3549	3090	3102	3090
q22	368	314	316	314
Total cold run time: 108557 ms
Total hot run time: 38797 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4056	4038	4038	4038
q2	335	220	220	220
q3	2962	2930	2951	2930
q4	1846	1858	1840	1840
q5	5259	5230	5218	5218
q6	207	125	125	125
q7	2261	1837	1821	1821
q8	3213	3292	3289	3289
q9	8476	8445	8464	8445
q10	3722	4004	3997	3997
q11	558	468	479	468
q12	756	623	649	623
q13	12084	3178	3110	3110
q14	306	293	288	288
q15	518	479	504	479
q16	514	413	449	413
q17	1785	1779	1769	1769
q18	8131	7757	7713	7713
q19	1686	1730	1714	1714
q20	2048	1750	1750	1750
q21	5270	4989	5115	4989
q22	513	451	450	450
Total cold run time: 66506 ms
Total hot run time: 55689 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182525 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c94e031d527a3a405dded357e294bfa972a5ac2, data reload: false

query1	893	1123	1118	1118
query2	6215	1922	1815	1815
query3	6657	230	210	210
query4	25082	21463	21494	21463
query5	4182	404	401	401
query6	293	195	212	195
query7	4597	303	308	303
query8	245	180	183	180
query9	8468	2274	2272	2272
query10	446	260	253	253
query11	15221	14603	14472	14472
query12	148	99	96	96
query13	1629	385	377	377
query14	8495	6838	6980	6838
query15	211	180	186	180
query16	6775	284	291	284
query17	953	596	594	594
query18	1840	284	284	284
query19	211	162	165	162
query20	102	93	97	93
query21	198	133	134	133
query22	5030	4797	4775	4775
query23	33384	32638	32648	32638
query24	12708	3277	3305	3277
query25	744	418	427	418
query26	1926	174	171	171
query27	3162	394	382	382
query28	7093	1942	1905	1905
query29	1373	629	647	629
query30	308	164	181	164
query31	1037	753	746	746
query32	105	67	65	65
query33	737	270	256	256
query34	1417	512	539	512
query35	863	735	749	735
query36	979	862	860	860
query37	276	85	85	85
query38	3741	3608	3543	3543
query39	1718	1654	1614	1614
query40	237	149	147	147
query41	48	46	47	46
query42	117	114	108	108
query43	454	417	422	417
query44	1210	736	735	735
query45	281	276	272	272
query46	1109	818	805	805
query47	1959	1896	1906	1896
query48	385	313	333	313
query49	965	391	377	377
query50	839	420	413	413
query51	7164	6920	6855	6855
query52	119	102	112	102
query53	369	314	300	300
query54	328	250	242	242
query55	91	77	83	77
query56	300	258	234	234
query57	1292	1187	1171	1171
query58	255	232	242	232
query59	2645	2307	2407	2307
query60	248	230	241	230
query61	89	84	89	84
query62	634	454	442	442
query63	313	281	283	281
query64	5814	3238	3292	3238
query65	3114	3027	3043	3027
query66	1300	313	308	308
query67	15674	15198	14807	14807
query68	9230	561	594	561
query69	571	328	329	328
query70	1408	1094	1095	1094
query71	490	270	280	270
query72	6291	2555	2419	2419
query73	1581	327	332	327
query74	6833	6372	6354	6354
query75	3489	2246	2295	2246
query76	5306	1167	1287	1167
query77	576	246	239	239
query78	10859	10181	10063	10063
query79	8986	528	530	528
query80	1442	450	431	431
query81	485	218	225	218
query82	375	108	105	105
query83	214	171	166	166
query84	271	91	89	89
query85	942	295	294	294
query86	357	290	301	290
query87	3696	3460	3502	3460
query88	3886	2353	2368	2353
query89	559	366	367	366
query90	2059	184	181	181
query91	133	110	110	110
query92	62	52	50	50
query93	6500	530	533	530
query94	1253	198	200	198
query95	443	334	337	334
query96	608	271	274	271
query97	2681	2480	2493	2480
query98	227	218	211	211
query99	1234	828	835	828
Total cold run time: 299862 ms
Total hot run time: 182525 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5c94e031d527a3a405dded357e294bfa972a5ac2, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.24	0.05	0.04
query4	1.67	0.06	0.06
query5	0.48	0.47	0.48
query6	1.12	0.65	0.65
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.51	0.52
query10	0.57	0.58	0.58
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.61	0.61	0.61
query14	0.78	0.79	0.79
query15	0.86	0.84	0.84
query16	0.36	0.36	0.36
query17	0.97	0.99	1.00
query18	0.25	0.25	0.26
query19	1.85	1.71	1.75
query20	0.01	0.01	0.01
query21	15.40	0.76	0.73
query22	3.07	5.55	1.79
query23	17.97	1.32	1.01
query24	1.46	0.28	0.23
query25	0.13	0.09	0.09
query26	0.27	0.18	0.19
query27	0.08	0.09	0.08
query28	13.65	0.96	0.93
query29	12.54	3.34	3.47
query30	0.27	0.06	0.05
query31	2.86	0.38	0.38
query32	3.28	0.47	0.47
query33	2.87	2.82	2.89
query34	15.49	4.34	4.34
query35	4.35	4.36	4.41
query36	0.67	0.48	0.49
query37	0.19	0.17	0.17
query38	0.18	0.15	0.16
query39	0.04	0.04	0.04
query40	0.18	0.15	0.14
query41	0.09	0.06	0.06
query42	0.07	0.05	0.06
query43	0.04	0.04	0.04
Total cold run time: 105.95 s
Total hot run time: 30.14 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 5c94e031d527a3a405dded357e294bfa972a5ac2 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       17.4 seconds inserted 10000000 Rows, about 574K ops/s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 0149013 into apache:master Apr 4, 2024
dataroaring pushed a commit that referenced this pull request Jun 5, 2024
## Proposed changes

### Purpose

The user doc:
https://doris.apache.org/zh-CN/docs/dev/data-operate/import/transaction-load-manual

We have supported insert into
select(#31666),
update(#33034) and
delete(#33100) in transaction load.

#32980 implements one txn write to
one partition more than one rowsets.

This pr implements to cloud mode of
#32980

### Implementation

#### sub_txn_id

see #32980

#### Meta service supports commit txn

This process is generally the same as commit_txn, the difference is that
he partitions version will plus 1 in multi sub txns.

One example:
Suppose the table, partition, tablet and version info is:
```
--------------------------------------------
| table | partition | tablet    | version |
--------------------------------------------
| t1    | t1_p1     | t1_p1.1   | 1       |
| t1    | t1_p1     | t1_p1.2   | 1       |
| t1    | t1_p2     | t1_p2.1   | 2       |
| t2    | t2_p3     | t2_p3.1   | 3       |
| t2    | t2_p4     | t2_p4.1   | 4       |
--------------------------------------------
```

Now we commit a txn with 3 sub txns and the tablets are:
 *  sub_txn1: t1_p1.1, t1_p1.2, t1_p2.1
 *  sub_txn2: t2_p3.1
 *  sub_txn3: t1_p1.1, t1_p1.2

When commit, the partitions version will be:
 *  sub_txn1: t1_p1(1 -> 2), t1_p2(2 -> 3)
 *  sub_txn2: t2_p3(3 -> 4)
 *  sub_txn3: t1_p1(2 -> 3)

After commit, the partitions version will be:
 *  t1: t1_p1(3), t1_p2(3)
 *  t2: t2_p3(4), t2_p4(4)

#### Meta service support generate sub_txn_id by `begin_sub_txn`
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
## Proposed changes

### Purpose

The user doc:
https://doris.apache.org/zh-CN/docs/dev/data-operate/import/transaction-load-manual

We have supported insert into
select(#31666),
update(#33034) and
delete(#33100) in transaction load.

#32980 implements one txn write to
one partition more than one rowsets.

This pr implements to cloud mode of
#32980

### Implementation

#### sub_txn_id

see #32980

#### Meta service supports commit txn

This process is generally the same as commit_txn, the difference is that
he partitions version will plus 1 in multi sub txns.

One example:
Suppose the table, partition, tablet and version info is:
```
--------------------------------------------
| table | partition | tablet    | version |
--------------------------------------------
| t1    | t1_p1     | t1_p1.1   | 1       |
| t1    | t1_p1     | t1_p1.2   | 1       |
| t1    | t1_p2     | t1_p2.1   | 2       |
| t2    | t2_p3     | t2_p3.1   | 3       |
| t2    | t2_p4     | t2_p4.1   | 4       |
--------------------------------------------
```

Now we commit a txn with 3 sub txns and the tablets are:
 *  sub_txn1: t1_p1.1, t1_p1.2, t1_p2.1
 *  sub_txn2: t2_p3.1
 *  sub_txn3: t1_p1.1, t1_p1.2

When commit, the partitions version will be:
 *  sub_txn1: t1_p1(1 -> 2), t1_p2(2 -> 3)
 *  sub_txn2: t2_p3(3 -> 4)
 *  sub_txn3: t1_p1(2 -> 3)

After commit, the partitions version will be:
 *  t1: t1_p1(3), t1_p2(3)
 *  t2: t2_p3(4), t2_p4(4)

#### Meta service support generate sub_txn_id by `begin_sub_txn`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants