[Fix](core) Fix wal mgr heap use after free when stop doris #33131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38934 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
mymeiyi
approved these changes
Apr 2, 2024
gavinchou
reviewed
Apr 2, 2024
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39193 ms |
TPC-DS: Total hot run time: 181459 ms |
ClickBench: Total hot run time: 30.16 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Yukang-Lian
force-pushed
the
Fix_Wal_Manager_Init_Use_After_Free
branch
from
da2877e to
ca8109b
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38350 ms |
TPC-DS: Total hot run time: 181579 ms |
ClickBench: Total hot run time: 29.69 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Collaborator
Author
|
run p0 |
Collaborator
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Yukang-Lian
force-pushed
the
Fix_Wal_Manager_Init_Use_After_Free
branch
from
7c0e15f to
d9946a8
Compare
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39722 ms |
TPC-DS: Total hot run time: 190245 ms |
ClickBench: Total hot run time: 31.18 s |
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 39610 ms |
TPC-DS: Total hot run time: 186658 ms |
ClickBench: Total hot run time: 32.13 s |
Collaborator
Author
|
run cloud_p0 |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
Problem: When the process stops, there is a heap use after free error with the WAL manager. Reason: During the startup process, if the storage engine does not initialize successfully and the main program directly returns 0, the WAL manager, which was created during initialization and started a thread to periodically check disk space, will encounter an issue. When the program exits and returns 0, local variables are destroyed first before the thread is properly terminated. If the thread attempts to access those local variables at this point, it leads to a heap use after free error. Solution: Ensure that the thread for periodically checking disk space is only started after the storage engine has been successfully initialized. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
Yukang-Lian
added a commit
to Yukang-Lian/doris
that referenced
this pull request
Aug 19, 2024
…3131) Problem: When the process stops, there is a heap use after free error with the WAL manager. Reason: During the startup process, if the storage engine does not initialize successfully and the main program directly returns 0, the WAL manager, which was created during initialization and started a thread to periodically check disk space, will encounter an issue. When the program exits and returns 0, local variables are destroyed first before the thread is properly terminated. If the thread attempts to access those local variables at this point, it leads to a heap use after free error. Solution: Ensure that the thread for periodically checking disk space is only started after the storage engine has been successfully initialized. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When the process stops, there is a heap use after free error with the WAL manager.
Reason: During the startup process, if the storage engine does not initialize successfully and the main program directly returns 0, the WAL manager, which was created during initialization and started a thread to periodically check disk space, will encounter an issue. When the program exits and returns 0, local variables are destroyed first before the thread is properly terminated. If the thread attempts to access those local variables at this point, it leads to a heap use after free error.
Solution: Ensure that the thread for periodically checking disk space is only started after the storage engine has been successfully initialized.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...