[enhancement](function truncate) truncate can use column as scale argument #33157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument (apache#32746) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
github-actions
bot
added
area/nereids
area/planner
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public: | ||
| static FunctionPtr create() { return std::make_shared<FunctionTruncate>(); } | ||
|
|
||
| ColumnNumbers get_arguments_that_are_always_constant() const override { return {}; } |
Contributor
There was a problem hiding this comment.
warning: function 'get_arguments_that_are_always_constant' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| ColumnNumbers get_arguments_that_are_always_constant() const override { return {}; } | |
| [[nodiscard]] ColumnNumbers get_arguments_that_are_always_constant() const override { return {}; } |
| ColumnNumbers get_arguments_that_are_always_constant() const override { return {}; } | ||
| // SELECT number, truncate(123.345, 1) FROM number("numbers"="10") | ||
| // should NOT behave like two column arguments, so we can not use const column default implementation | ||
| bool use_default_implementation_for_constants() const override { return false; } |
Contributor
There was a problem hiding this comment.
warning: function 'use_default_implementation_for_constants' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool use_default_implementation_for_constants() const override { return false; } | |
| [[nodiscard]] bool use_default_implementation_for_constants() const override { return false; } |
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include <gtest/gtest-message.h> |
Contributor
There was a problem hiding this comment.
warning: 'gtest/gtest-message.h' file not found [clang-diagnostic-error]
#include <gtest/gtest-message.h>
^
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49618 ms |
TPC-DS: Total hot run time: 200160 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.86 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49539 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 201841 ms |
ClickBench: Total hot run time: 30.36 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49738 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 201073 ms |
ClickBench: Total hot run time: 30.99 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #32746