[Improvement](agg) Improve count distinct distribute keys #33167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #pragma once | ||
|
|
||
| #include <stddef.h> |
Contributor
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
Suggested change
| #include <stddef.h> | |
| #include <cstddef> |
| #include <stddef.h> | ||
|
|
||
| #include <algorithm> | ||
| #include <boost/iterator/iterator_facade.hpp> |
Contributor
There was a problem hiding this comment.
warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error]
#include <boost/iterator/iterator_facade.hpp>
^
Comment on lines
44
to
45
| namespace doris { | ||
| namespace vectorized { |
Contributor
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Suggested change
| namespace doris { | |
| namespace vectorized { | |
| namespace doris::vectorized { |
be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h:48:
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris| auto data = reinterpret_cast<const UInt64*>( | ||
| assert_cast<const ColumnFixedLengthObject&>(column).get_data().data()); | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| auto rhs_place = places + sizeof(Data) * i; |
Contributor
There was a problem hiding this comment.
warning: 'auto rhs_place' can be declared as 'auto *rhs_place' [readability-qualified-auto]
Suggested change
| auto rhs_place = places + sizeof(Data) * i; | |
| auto *rhs_place = places + sizeof(Data) * i; |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.27 s |
be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h
Outdated
Show resolved
Hide resolved
be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h
Outdated
Show resolved
Hide resolved
BiteTheDDDDt
previously approved these changes
Apr 23, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
|
|
||
| #pragma once | ||
|
|
||
| #include <stddef.h> |
Contributor
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
Suggested change
| #include <stddef.h> | |
| #include <cstddef> |
| #include <stddef.h> | ||
|
|
||
| #include <algorithm> | ||
| #include <boost/iterator/iterator_facade.hpp> |
Contributor
There was a problem hiding this comment.
warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error]
#include <boost/iterator/iterator_facade.hpp>
^
Comment on lines
+44
to
+45
| namespace doris { | ||
| namespace vectorized { |
Contributor
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Suggested change
| namespace doris { | |
| namespace vectorized { | |
| namespace doris::vectorized { |
be/src/vec/aggregate_functions/aggregate_function_uniq_distribute_key.h:48:
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris| auto data = reinterpret_cast<const UInt64*>( | ||
| assert_cast<const ColumnFixedLengthObject&>(column).get_data().data()); | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| auto rhs_place = places + sizeof(Data) * i; |
Contributor
There was a problem hiding this comment.
warning: 'auto rhs_place' can be declared as 'auto *rhs_place' [readability-qualified-auto]
Suggested change
| auto rhs_place = places + sizeof(Data) * i; | |
| auto *rhs_place = places + sizeof(Data) * i; |
zhangstar333
approved these changes
Apr 26, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40813 ms |
TPC-DS: Total hot run time: 186747 ms |
BiteTheDDDDt
approved these changes
Apr 26, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement another count distinct function.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...