Skip to content

[improve](function) the offset params in lead/lag function could use 0 #33174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Apr 4, 2024
Merged

[improve](function) the offset params in lead/lag function could use 0 #33174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void checkLegalityBeforeTypeCoercion() {
if (children().size() >= 2) {
checkValidParams(getOffset(), true);
if (getOffset() instanceof Literal) {
if (((Literal) getOffset()).getDouble() <= 0) {
if (((Literal) getOffset()).getDouble() < 0) {
throw new AnalysisException(
"The offset parameter of LAG must be a constant positive integer: " + this.toSql());
}
Expand Down
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lead.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public void checkLegalityBeforeTypeCoercion() {
if (children().size() >= 2) {
checkValidParams(getOffset(), true);
if (getOffset() instanceof Literal) {
if (((Literal) getOffset()).getDouble() <= 0) {
if (((Literal) getOffset()).getDouble() < 0) {
throw new AnalysisException(
"The offset parameter of LEAD must be a constant positive integer: " + this.toSql());
}
Expand Down
12 changes: 12 additions & 0 deletions regression-test/data/correctness_p0/test_always_nullable_window_function.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,15 @@
24 02-24-10-21 1 \N \N \N \N \N \N \N \N
24 02-24-10-21 1 1 1 1 1.0 1 1 \N \N

-- !select_lead_lag --
1 1 1 04-21-11 21
1 1 1 04-21-11 21
0 0 0 04-22-10-21 22
0 0 0 04-22-10-21 22
1 1 1 04-22-10-21 22
1 1 1 04-22-10-21 22
1 1 1 04-23-10 23
1 1 1 04-23-10 23
1 1 1 02-24-10-21 24
1 1 1 02-24-10-21 24

8 changes: 7 additions & 1 deletion regression-test/suites/correctness_p0/test_always_nullable_window_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,5 +172,11 @@ suite("test_always_nullable_window_function") {
lead(state, 2, null) over (partition by myday order by time_col) lead_value
from ${nullableTableName} order by myday, time_col, state;
"""

sql "set enable_nereids_planner = true"
qt_select_lead_lag """
select lag(state, 0, 22) over (partition by myday order by time_col) lag_value,
lead(state, 0, 33) over (partition by myday order by time_col) lead_value,
state,time_col,myday
from ${nullableTableName} order by myday, time_col, state;
"""
}