Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

fix wrong result when salias name same with base slot on mv

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38466 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01097a8d6c14e911b9472b197e56c6d8446c7169, data reload: false

------ Round 1 ----------------------------------
q1	17621	4129	4042	4042
q2	2020	187	185	185
q3	10472	1207	1384	1207
q4	10212	874	1009	874
q5	7472	2953	2899	2899
q6	214	129	130	129
q7	1104	616	605	605
q8	9389	2031	2024	2024
q9	6710	6167	6098	6098
q10	8431	3494	3469	3469
q11	417	238	239	238
q12	375	219	208	208
q13	17786	2929	2913	2913
q14	274	238	255	238
q15	543	488	482	482
q16	488	393	380	380
q17	942	912	914	912
q18	7188	6400	6397	6397
q19	1593	1534	1513	1513
q20	599	326	300	300
q21	3506	3106	3051	3051
q22	362	302	310	302
Total cold run time: 107718 ms
Total hot run time: 38466 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4095	4016	4024	4016
q2	328	218	225	218
q3	2961	2945	2931	2931
q4	1884	1846	1829	1829
q5	5232	5208	5203	5203
q6	205	126	123	123
q7	2223	1786	1802	1786
q8	3221	3264	3281	3264
q9	8450	8401	8443	8401
q10	3716	3891	3991	3891
q11	573	461	480	461
q12	751	614	615	614
q13	16806	3094	3127	3094
q14	293	283	293	283
q15	551	492	494	492
q16	513	449	447	447
q17	1763	1720	1775	1720
q18	8266	7651	7589	7589
q19	1685	1668	1665	1665
q20	2034	1806	1872	1806
q21	5115	4998	5006	4998
q22	489	448	440	440
Total cold run time: 71154 ms
Total hot run time: 55271 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181277 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01097a8d6c14e911b9472b197e56c6d8446c7169, data reload: false

query1	1207	364	1102	364
query2	6369	1959	1947	1947
query3	6675	211	214	211
query4	25072	21248	21494	21248
query5	4223	399	400	399
query6	275	216	186	186
query7	4599	312	304	304
query8	232	184	181	181
query9	8455	2267	2270	2267
query10	451	245	266	245
query11	14956	14345	14669	14345
query12	146	101	96	96
query13	1646	382	389	382
query14	8478	6868	6893	6868
query15	212	180	178	178
query16	6848	266	267	266
query17	997	591	574	574
query18	1831	272	271	271
query19	206	159	158	158
query20	92	95	94	94
query21	197	128	127	127
query22	5065	4892	4770	4770
query23	33423	32603	32634	32603
query24	11792	3236	3147	3147
query25	682	431	440	431
query26	1771	170	170	170
query27	3223	388	389	388
query28	6933	1929	1919	1919
query29	1199	650	630	630
query30	322	174	167	167
query31	1017	754	752	752
query32	100	67	73	67
query33	711	251	252	251
query34	1127	518	537	518
query35	852	730	732	730
query36	1032	869	875	869
query37	149	77	86	77
query38	3650	3539	3608	3539
query39	1706	1614	1620	1614
query40	255	152	144	144
query41	48	46	45	45
query42	119	111	108	108
query43	445	400	416	400
query44	1173	738	726	726
query45	290	281	271	271
query46	1138	834	813	813
query47	2063	1888	1906	1888
query48	398	310	326	310
query49	1023	378	363	363
query50	826	419	398	398
query51	6930	6718	6834	6718
query52	119	103	103	103
query53	374	308	302	302
query54	314	257	250	250
query55	87	78	82	78
query56	258	236	234	234
query57	1273	1154	1170	1154
query58	266	253	241	241
query59	2646	2498	2308	2308
query60	250	226	240	226
query61	94	87	87	87
query62	662	444	444	444
query63	314	281	281	281
query64	5966	3098	3109	3098
query65	3018	2961	3014	2961
query66	1017	311	309	309
query67	15351	15093	14636	14636
query68	9064	574	571	571
query69	553	331	324	324
query70	1226	1113	1039	1039
query71	519	272	272	272
query72	6330	2603	2416	2416
query73	835	318	322	318
query74	6658	6453	6283	6283
query75	3456	2306	2273	2273
query76	5326	1084	1223	1084
query77	571	244	269	244
query78	10872	10169	10050	10050
query79	7813	532	533	532
query80	1235	423	416	416
query81	487	245	247	245
query82	654	112	105	105
query83	208	160	160	160
query84	268	87	88	87
query85	1306	285	290	285
query86	405	278	287	278
query87	3636	3559	3486	3486
query88	3545	2260	2266	2260
query89	545	379	367	367
query90	1924	179	183	179
query91	132	107	104	104
query92	59	50	50	50
query93	6514	535	529	529
query94	958	193	196	193
query95	1094	1090	1097	1090
query96	612	281	276	276
query97	2717	2476	2499	2476
query98	222	212	216	212
query99	1319	824	845	824
Total cold run time: 295701 ms
Total hot run time: 181277 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01097a8d6c14e911b9472b197e56c6d8446c7169, data reload: false

query1	0.04	0.04	0.02
query2	0.08	0.04	0.04
query3	0.22	0.05	0.07
query4	1.67	0.08	0.07
query5	0.48	0.48	0.47
query6	1.13	0.66	0.65
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.54	0.52
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	0.78	0.77	0.79
query15	0.85	0.83	0.82
query16	0.36	0.36	0.35
query17	0.98	0.96	1.00
query18	0.24	0.25	0.26
query19	1.88	1.75	1.69
query20	0.01	0.01	0.01
query21	15.41	0.74	0.72
query22	3.13	5.41	2.01
query23	17.79	1.42	1.09
query24	1.77	0.23	0.23
query25	0.13	0.09	0.08
query26	0.28	0.17	0.20
query27	0.08	0.09	0.08
query28	13.54	0.97	0.92
query29	12.68	3.53	3.45
query30	0.26	0.06	0.06
query31	2.86	0.38	0.38
query32	3.28	0.48	0.47
query33	2.88	2.83	2.85
query34	15.52	4.32	4.34
query35	4.39	4.40	4.37
query36	0.67	0.47	0.48
query37	0.20	0.17	0.18
query38	0.17	0.16	0.16
query39	0.05	0.04	0.04
query40	0.19	0.15	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 106.28 s
Total hot run time: 30.39 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 01097a8d6c14e911b9472b197e56c6d8446c7169 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       16.2 seconds inserted 10000000 Rows, about 617K ops/s

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39171 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69137f5104728e705d2db0d4ab0befde567db1ab, data reload: false

------ Round 1 ----------------------------------
q1	18230	4292	4194	4194
q2	2643	214	188	188
q3	11407	1344	1442	1344
q4	10567	997	1064	997
q5	7846	2968	2919	2919
q6	218	133	132	132
q7	1091	636	611	611
q8	9407	2047	2042	2042
q9	6754	6191	6173	6173
q10	8402	3514	3525	3514
q11	413	240	230	230
q12	383	220	214	214
q13	17762	2875	2931	2875
q14	273	239	245	239
q15	520	493	480	480
q16	489	401	381	381
q17	971	917	931	917
q18	7289	6487	6609	6487
q19	1607	1561	1529	1529
q20	598	323	303	303
q21	3560	3170	3089	3089
q22	371	313	313	313
Total cold run time: 110801 ms
Total hot run time: 39171 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4040	4046	4031	4031
q2	334	211	216	211
q3	2975	2946	2942	2942
q4	1881	1872	1862	1862
q5	5246	5203	5201	5201
q6	208	126	121	121
q7	2236	1812	1775	1775
q8	3225	3302	3289	3289
q9	8510	8456	8474	8456
q10	3749	3817	3829	3817
q11	542	452	439	439
q12	714	572	561	561
q13	16757	2868	2887	2868
q14	291	263	261	261
q15	516	475	476	475
q16	454	401	416	401
q17	1717	1695	1682	1682
q18	7684	7254	7254	7254
q19	1645	1638	1642	1638
q20	1946	1728	1737	1728
q21	4934	4794	4762	4762
q22	499	433	423	423
Total cold run time: 70103 ms
Total hot run time: 54197 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181137 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69137f5104728e705d2db0d4ab0befde567db1ab, data reload: false

query1	1212	1117	1104	1104
query2	6502	1846	1870	1846
query3	6672	212	215	212
query4	24595	21613	21433	21433
query5	4221	396	408	396
query6	280	188	179	179
query7	4602	300	299	299
query8	235	183	171	171
query9	8436	2324	2352	2324
query10	587	259	270	259
query11	14923	14443	14410	14410
query12	144	96	96	96
query13	1655	387	376	376
query14	8655	6800	6780	6780
query15	220	169	179	169
query16	7154	277	275	275
query17	1006	615	569	569
query18	1912	296	281	281
query19	207	167	167	167
query20	97	96	98	96
query21	196	133	127	127
query22	5006	4813	4782	4782
query23	33610	32884	32811	32811
query24	12583	3130	3132	3130
query25	677	388	393	388
query26	1904	161	164	161
query27	3042	327	342	327
query28	6787	1853	1865	1853
query29	1348	574	571	571
query30	320	170	161	161
query31	993	703	724	703
query32	99	56	61	56
query33	701	264	246	246
query34	1033	479	502	479
query35	834	691	699	691
query36	1018	867	847	847
query37	294	77	74	74
query38	3515	3418	3346	3346
query39	1579	1531	1525	1525
query40	296	128	137	128
query41	46	50	46	46
query42	118	105	102	102
query43	435	391	404	391
query44	1090	714	696	696
query45	273	261	227	227
query46	1061	785	782	782
query47	1919	1814	1795	1795
query48	374	309	309	309
query49	1162	355	355	355
query50	795	394	391	391
query51	6617	6461	6584	6461
query52	109	96	97	96
query53	354	292	286	286
query54	304	257	248	248
query55	87	79	79	79
query56	245	221	217	217
query57	1215	1100	1116	1100
query58	256	218	226	218
query59	2454	2372	2249	2249
query60	265	247	261	247
query61	110	113	107	107
query62	722	448	462	448
query63	312	283	283	283
query64	6538	3447	3230	3230
query65	3078	3007	2984	2984
query66	1458	336	332	332
query67	15252	15298	14975	14975
query68	5164	556	565	556
query69	498	342	327	327
query70	1158	1091	1125	1091
query71	399	287	271	271
query72	6295	2711	2548	2548
query73	714	341	340	340
query74	6712	6319	6338	6319
query75	2981	2244	2258	2244
query76	2835	1107	1182	1107
query77	400	254	253	253
query78	10745	10227	10124	10124
query79	8827	530	537	530
query80	1879	422	419	419
query81	524	246	241	241
query82	1271	105	105	105
query83	306	164	161	161
query84	270	89	87	87
query85	1973	305	278	278
query86	481	269	270	269
query87	3689	3577	3483	3483
query88	4333	2353	2354	2353
query89	571	366	370	366
query90	1964	176	183	176
query91	132	105	105	105
query92	58	51	53	51
query93	6262	548	525	525
query94	1224	194	201	194
query95	437	333	332	332
query96	614	270	270	270
query97	2662	2482	2483	2482
query98	229	215	215	215
query99	1274	844	813	813
Total cold run time: 292680 ms
Total hot run time: 181137 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69137f5104728e705d2db0d4ab0befde567db1ab, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.04
query4	1.67	0.07	0.06
query5	0.49	0.48	0.49
query6	1.14	0.65	0.65
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.56	0.57	0.57
query11	0.15	0.10	0.12
query12	0.14	0.12	0.12
query13	0.61	0.59	0.60
query14	0.78	0.78	0.80
query15	0.88	0.83	0.85
query16	0.36	0.35	0.36
query17	0.96	1.01	0.96
query18	0.24	0.25	0.26
query19	1.78	1.67	1.71
query20	0.02	0.01	0.01
query21	15.47	0.75	0.73
query22	2.91	5.56	2.05
query23	17.71	1.23	1.03
query24	1.40	0.30	0.23
query25	0.15	0.09	0.08
query26	0.28	0.17	0.18
query27	0.08	0.08	0.09
query28	13.66	0.99	0.95
query29	12.74	3.42	3.46
query30	0.26	0.06	0.07
query31	2.85	0.38	0.37
query32	3.28	0.47	0.47
query33	2.82	2.83	2.85
query34	15.53	4.35	4.30
query35	4.36	4.37	4.36
query36	0.66	0.47	0.47
query37	0.19	0.18	0.17
query38	0.18	0.15	0.16
query39	0.05	0.05	0.04
query40	0.18	0.15	0.14
query41	0.10	0.06	0.05
query42	0.07	0.05	0.06
query43	0.05	0.04	0.04
Total cold run time: 105.75 s
Total hot run time: 30.34 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 69137f5104728e705d2db0d4ab0befde567db1ab with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       15.6 seconds inserted 10000000 Rows, about 641K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit 7977976 into apache:master Apr 7, 2024
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Apr 8, 2024
…base slot on mv (apache#33198)

fix wrong result when salias name same with base slot on mv
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Apr 8, 2024
…base slot on mv (apache#33198)

fix wrong result when salias name same with base slot on mv
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
…base slot on mv (#33198)

fix wrong result when salias name same with base slot on mv
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
…base slot on mv (apache#33198)

fix wrong result when salias name same with base slot on mv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.9-merged p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants