Skip to content

[bugfix](stop) should skip the loop when graceful stop #33212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Apr 3, 2024
Merged

[bugfix](stop) should skip the loop when graceful stop #33212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion be/src/olap/olap_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,8 @@ void StorageEngine::_update_replica_infos_callback() {

int start = 0;
int tablet_size = all_tablets.size();
while (start < tablet_size) {
// The while loop may take a long time, we should skip it when stop
while (start < tablet_size && _stop_background_threads_latch.count() > 0) {
int batch_size = std::min(100, tablet_size - start);
int end = start + batch_size;
TGetTabletReplicaInfosRequest request;
Expand Down