Skip to content

[cherry-pick](function) the offset params in lead/lag function could use 0 (#33174) #33301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangstar333 merged 1 commit into from
Apr 10, 2024
Merged

[cherry-pick](function) the offset params in lead/lag function could use 0 (#33174) #33301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void checkLegalityBeforeTypeCoercion() {
if (children().size() >= 2) {
checkValidParams(getOffset(), true);
if (getOffset() instanceof Literal) {
if (((Literal) getOffset()).getDouble() <= 0) {
if (((Literal) getOffset()).getDouble() < 0) {
throw new AnalysisException(
"The offset parameter of LAG must be a constant positive integer: " + this.toSql());
}
Expand Down
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lead.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public void checkLegalityBeforeTypeCoercion() {
if (children().size() >= 2) {
checkValidParams(getOffset(), true);
if (getOffset() instanceof Literal) {
if (((Literal) getOffset()).getDouble() <= 0) {
if (((Literal) getOffset()).getDouble() < 0) {
throw new AnalysisException(
"The offset parameter of LEAD must be a constant positive integer: " + this.toSql());
}
Expand Down
32 changes: 32 additions & 0 deletions regression-test/data/nereids_syntax_p0/window_function.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,3 +359,35 @@
1.0
1.5

-- !select_lead --
1
2
1
2
1
2
1
2
1
2
2
1
1
1

-- !select_lag --
1
2
1
2
1
2
1
2
1
2
2
1
1
1

3 changes: 3 additions & 0 deletions regression-test/suites/nereids_syntax_p0/window_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,7 @@ suite("window_function") {
left join adj_nullable_2 on c1 = c4
where c6 is not null;
"""

qt_select_lead "SELECT lead(c1, 0, 111) over(partition by c3 order by c2) FROM window_test"
qt_select_lag "SELECT lag(c1, 0, 222) over(partition by c3 order by c2) FROM window_test"
}