Skip to content

[fix](jdbc catalog) fix db2 test connection sql #33335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 8, 2024
Merged

[fix](jdbc catalog) fix db2 test connection sql #33335

yiguolei merged 1 commit into from
Apr 8, 2024

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Apr 7, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

When creating the db2 catalog, you need to provide a special select 1 statement to test the connection

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Apr 7, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Apr 7, 2024

TPC-H: Total hot run time: 38645 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5f4beb00ae7ffe4d8023dc2b8e34d061326b70b8, data reload: false

------ Round 1 ----------------------------------
q1	18040	4044	4081	4044
q2	2013	185	176	176
q3	10506	1214	1298	1214
q4	10524	836	951	836
q5	7552	2973	2953	2953
q6	218	136	129	129
q7	998	554	528	528
q8	9398	2089	2044	2044
q9	6757	6224	6133	6133
q10	8460	3498	3498	3498
q11	408	227	229	227
q12	379	214	208	208
q13	17764	2874	2940	2874
q14	277	232	244	232
q15	524	484	473	473
q16	474	386	375	375
q17	950	906	896	896
q18	7610	6616	6552	6552
q19	1626	1540	1535	1535
q20	579	320	315	315
q21	3523	3124	3107	3107
q22	371	316	296	296
Total cold run time: 108951 ms
Total hot run time: 38645 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4054	4016	4049	4016
q2	331	227	215	215
q3	2955	2946	2929	2929
q4	1925	1864	1860	1860
q5	5260	5260	5226	5226
q6	211	124	122	122
q7	1769	1344	1364	1344
q8	3243	3278	3286	3278
q9	8558	8532	8522	8522
q10	3774	3850	3819	3819
q11	551	452	464	452
q12	701	525	558	525
q13	11001	2889	2894	2889
q14	290	258	260	258
q15	511	467	472	467
q16	441	406	409	406
q17	1723	1680	1689	1680
q18	7557	7154	7146	7146
q19	1639	1634	1645	1634
q20	1944	1730	1751	1730
q21	5021	4770	4739	4739
q22	494	422	421	421
Total cold run time: 63953 ms
Total hot run time: 53678 ms

@doris-robot
Copy link

doris-robot commented Apr 7, 2024

TPC-DS: Total hot run time: 180310 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f4beb00ae7ffe4d8023dc2b8e34d061326b70b8, data reload: false

query1	1215	357	1106	357
query2	6493	1859	1820	1820
query3	6669	219	217	217
query4	25377	21560	21370	21370
query5	4190	411	402	402
query6	273	183	183	183
query7	4614	301	295	295
query8	226	177	170	170
query9	8455	2207	2209	2207
query10	598	252	253	252
query11	14944	14595	14488	14488
query12	155	88	89	88
query13	1650	397	378	378
query14	8706	6797	6756	6756
query15	208	179	178	178
query16	7135	270	258	258
query17	1022	587	551	551
query18	1892	281	270	270
query19	199	147	147	147
query20	91	88	89	88
query21	205	122	122	122
query22	4972	4768	4832	4768
query23	33289	32891	32878	32878
query24	10985	3162	3071	3071
query25	697	394	398	394
query26	1892	158	156	156
query27	3055	320	325	320
query28	6716	1831	1809	1809
query29	1348	596	603	596
query30	300	168	166	166
query31	981	704	703	703
query32	93	55	55	55
query33	642	252	247	247
query34	939	473	483	473
query35	834	676	682	676
query36	999	883	862	862
query37	295	72	75	72
query38	3526	3371	3384	3371
query39	1561	1526	1525	1525
query40	290	128	130	128
query41	51	46	46	46
query42	110	101	100	100
query43	437	413	412	412
query44	1151	714	719	714
query45	281	254	265	254
query46	1088	801	775	775
query47	1864	1788	1785	1785
query48	378	308	306	306
query49	1168	387	372	372
query50	795	387	387	387
query51	6683	6720	6620	6620
query52	108	96	97	96
query53	364	285	285	285
query54	308	232	234	232
query55	91	77	80	77
query56	242	226	224	224
query57	1205	1109	1096	1096
query58	252	215	215	215
query59	2461	2334	2344	2334
query60	257	235	249	235
query61	113	110	110	110
query62	706	435	470	435
query63	310	282	289	282
query64	6472	3171	3269	3171
query65	3053	3002	2988	2988
query66	1482	337	337	337
query67	15578	14991	15090	14991
query68	6425	569	572	569
query69	523	301	308	301
query70	1236	1125	1110	1110
query71	509	300	276	276
query72	6512	2572	2407	2407
query73	804	324	317	317
query74	6707	6338	6324	6324
query75	3342	2280	2271	2271
query76	4364	1198	1221	1198
query77	603	245	244	244
query78	10854	10242	10167	10167
query79	8946	532	520	520
query80	1678	416	413	413
query81	525	233	241	233
query82	736	105	91	91
query83	197	166	167	166
query84	265	85	88	85
query85	1495	282	290	282
query86	472	311	313	311
query87	3627	3485	3524	3485
query88	4280	2329	2323	2323
query89	581	369	370	369
query90	1968	181	178	178
query91	130	105	102	102
query92	56	49	50	49
query93	7222	542	528	528
query94	1117	180	172	172
query95	424	314	307	307
query96	616	267	267	267
query97	2644	2487	2476	2476
query98	228	221	213	213
query99	1314	810	850	810
Total cold run time: 295139 ms
Total hot run time: 180310 ms

@doris-robot
Copy link

doris-robot commented Apr 7, 2024

ClickBench: Total hot run time: 29.47 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f4beb00ae7ffe4d8023dc2b8e34d061326b70b8, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.06	0.07
query5	0.49	0.48	0.48
query6	1.14	0.64	0.64
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.50
query10	0.58	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.59	0.60
query14	0.77	0.78	0.78
query15	0.88	0.84	0.84
query16	0.35	0.36	0.35
query17	0.96	0.97	0.99
query18	0.25	0.26	0.26
query19	1.86	1.74	1.71
query20	0.01	0.01	0.01
query21	15.42	0.65	0.64
query22	3.84	8.63	1.19
query23	17.78	1.37	1.26
query24	1.58	0.19	0.18
query25	0.16	0.07	0.08
query26	0.26	0.17	0.17
query27	0.08	0.08	0.07
query28	13.86	0.97	0.95
query29	12.50	3.30	3.23
query30	0.26	0.06	0.06
query31	2.85	0.40	0.39
query32	3.27	0.48	0.48
query33	2.83	2.87	2.84
query34	15.52	4.33	4.33
query35	4.38	4.37	4.40
query36	0.67	0.47	0.48
query37	0.18	0.16	0.15
query38	0.16	0.14	0.14
query39	0.04	0.04	0.04
query40	0.18	0.15	0.16
query41	0.10	0.05	0.05
query42	0.05	0.05	0.06
query43	0.05	0.04	0.04
Total cold run time: 106.89 s
Total hot run time: 29.47 s

@doris-robot
Copy link

doris-robot commented Apr 7, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 5f4beb00ae7ffe4d8023dc2b8e34d061326b70b8 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       16.3 seconds inserted 10000000 Rows, about 613K ops/s

morningman
morningman approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 6f4b426 into apache:master Apr 8, 2024
yiguolei pushed a commit that referenced this pull request Apr 8, 2024
@zy-kkk @Doris-Extras
[fix](jdbc catalog) fix db2 test connection sql (#33335)
1f3ab4f
@yiguolei yiguolei mentioned this pull request Apr 8, 2024
Closed
@zy-kkk zy-kkk deleted the fix_db2_test_conn branch April 8, 2024 02:03
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
@zy-kkk @seawinde
[fix](jdbc catalog) fix db2 test connection sql (apache#33335)
28c3826
@zy-kkk zy-kkk removed the dev/2.0.x label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk @doris-robot @morningman @yiguolei @xiaokang