[Fix](Nereids) fix leading hint should have all tables in one query block #33517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
reviewed
Apr 11, 2024
| } | ||
| if (getTablelist().size() < inputRelationSets.size()) { | ||
| this.setStatus(HintStatus.SYNTAX_ERROR); | ||
| this.setErrorMessage("leading should have all tables in query block"); |
Contributor
There was a problem hiding this comment.
list missing table here?
| Long totalBitmap = 0L; | ||
| if (hasSameName()) { | ||
| this.setStatus(HintStatus.SYNTAX_ERROR); | ||
| this.setErrorMessage("duplicated table"); |
Contributor
There was a problem hiding this comment.
list duplicated table name?
LiBinfeng-01
force-pushed
the
fix_leading_all_tables
branch
from
c1c781d to
491e6ca
Compare
Contributor
Author
|
run buildall |
englefly
approved these changes
Apr 12, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Apr 12, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 12, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 13, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 13, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 15, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 17, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Apr 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
May 23, 2024
xiaokang
pushed a commit
that referenced
this pull request
May 23, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
example: when one query block have t1 join t2 join t3, leading should have these three tables together
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...