[fix](schema change) CastStringConverter is compiled failed in g++

[AshinGau]

Proposed changes

follow #32873, CastStringConverter is compiled failed in g++ for uninitialized value, which is ok in clang:

FAILED: src/vec/CMakeFiles/Vec.dir/exec/format/column_type_convert.cpp.o
ccache /var/local/ldb-toolchain/bin/g++ -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -DBOOST_STACKTRACE_USE_BACKTRACE -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX=1 -DBRPC_ENABLE_CPU_PROFILER -DENABLE_STACKTRACE -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H -DS2_USE_GFLAGS -DS2_USE_GLOG -DUSE_HADOOP_HDFS -DUSE_JEMALLOC -DUSE_MEM_TRACKER -DUSE_UNWIND -D__STDC_FORMAT_MACROS -I/root/doris/be/src/apache-orc/c++/include -I/root/doris/be/build_release/src/apache-orc/c++/include -I/root/doris/be/build_release/src/clucene/src/shared -I/root/doris/be/src/clucene/src/core -I/root/doris/be/src/clucene/src/shared -I/root/doris/be/src/clucene/src/contribs-lib -I/root/doris/be/src -I/root/doris/be/test -I/usr/lib/jvm/jdk-17.0.2/include -I/usr/lib/jvm/jdk-17.0.2/include/linux -isystem /root/doris/be/../gensrc/build -isystem /var/local/thirdparty/installed/include -isystem /var/local/thirdparty/installed/gperftools/include -O3 -DNDEBUG -O3 -O3 -DNDEBUG   -D OS_LINUX -g -Wall -Wextra -Werror -pthread -fstrict-aliasing -fno-omit-frame-pointer -Wnon-virtual-dtor -Wno-unused-parameter -Wno-sign-compare -fdiagnostics-color=always -Wno-nonnull -Wno-stringop-overread -Wno-stringop-overflow -Wno-array-bounds -msse4.2 -mavx2 -std=gnu++20 -MD -MT src/vec/CMakeFiles/Vec.dir/exec/format/column_type_convert.cpp.o -MF src/vec/CMakeFiles/Vec.dir/exec/format/column_type_convert.cpp.o.d -o src/vec/CMakeFiles/Vec.dir/exec/format/column_type_convert.cpp.o -c /root/doris/be/src/vec/exec/format/column_type_convert.cpp
In file included from /root/doris/be/src/vec/exec/format/column_type_convert.h:25,
from /root/doris/be/src/vec/exec/format/column_type_convert.cpp:18:
In function 'bool doris::vectorized::read_datetime_text_impl(T&, ReadBuffer&) [with T = long int]',
inlined from 'static bool doris::vectorized::converter::SafeCastString<doris::TYPE_DATETIME>::safe_cast_string(const char*, int, doris::vectorized::ColumnVector<long int>::value_type*)' at /root/doris/be/src/vec/exec/format/column_type_convert.h:316:46,
inlined from 'doris::Status doris::vectorized::converter::CastStringConverter<DstPrimitiveType>::convert(doris::vectorized::ColumnPtr&, doris::vectorized::MutableColumnPtr&) [with doris::PrimitiveType DstPrimitiveType = doris::TYPE_DATETIME]' at /root/doris/be/src/vec/exec/format/column_type_convert.h:398:78:
/root/doris/be/src/vec/io/io_helper.h:319:51: error: 'value' may be used uninitialized [-Werror=maybe-uninitialized]
    319 |     auto dv = binary_cast<Int64, VecDateTimeValue>(x);
        |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
  /root/doris/be/src/vec/exec/format/column_type_convert.h: In member function 'doris::Status doris::vectorized::converter::CastStringConverter<DstPrimitiveType>::convert(doris::vectorized::ColumnPtr&, doris::vectorized::MutableColumnPtr&) [with doris::PrimitiveType DstPrimitiveType = doris::TYPE_DATETIME]':
  /root/doris/be/src/vec/exec/format/column_type_convert.h:387:24: note: 'value' was declared here
    387 |             DstCppType value;
        |                        ^~~~~

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

[doris-robot]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[AshinGau]

run buildall

[doris-robot]

TeamCity be ut coverage result:
Function Coverage: 35.58% (8903/25020)
Line Coverage: 27.30% (73105/267774)
Region Coverage: 26.42% (37812/143133)
Branch Coverage: 23.19% (19270/83080)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b4fb73569669adfdaf230b1cfeff0169aceb4f68_b4fb73569669adfdaf230b1cfeff0169aceb4f68/report/index.html

[github-actions]

PR approved by at least one committer and no changes requested.

[github-actions]

PR approved by anyone and no changes requested.

[doris-robot]

TPC-H: Total hot run time: 38580 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b4fb73569669adfdaf230b1cfeff0169aceb4f68, data reload: false

------ Round 1 ----------------------------------
q1	17990	4604	4252	4252
q2	2015	188	181	181
q3	10547	1195	1208	1195
q4	10249	825	722	722
q5	7483	2727	2670	2670
q6	218	131	134	131
q7	1033	629	585	585
q8	9212	2066	2042	2042
q9	7930	6609	6554	6554
q10	8609	3564	3484	3484
q11	453	231	230	230
q12	455	221	221	221
q13	17765	2970	2965	2965
q14	268	233	226	226
q15	512	481	469	469
q16	529	375	371	371
q17	973	725	735	725
q18	7569	6679	6797	6679
q19	7159	1537	1502	1502
q20	694	323	310	310
q21	3582	2937	2771	2771
q22	351	295	298	295
Total cold run time: 115596 ms
Total hot run time: 38580 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4392	4198	4229	4198
q2	365	277	257	257
q3	2964	2740	2790	2740
q4	1857	1543	1598	1543
q5	5343	5363	5315	5315
q6	214	123	124	123
q7	2248	1870	1852	1852
q8	3197	3369	3331	3331
q9	8597	8591	8699	8591
q10	4029	3865	4011	3865
q11	602	509	511	509
q12	803	646	621	621
q13	16132	3284	3217	3217
q14	321	283	280	280
q15	554	475	503	475
q16	497	450	437	437
q17	1848	1541	1505	1505
q18	8081	8099	7867	7867
q19	1680	1496	1577	1496
q20	1971	1848	1843	1843
q21	5148	4954	4938	4938
q22	554	484	493	484
Total cold run time: 71397 ms
Total hot run time: 55487 ms

[doris-robot]

TPC-DS: Total hot run time: 183002 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b4fb73569669adfdaf230b1cfeff0169aceb4f68, data reload: false

query1	869	370	351	351
query2	6863	2762	2405	2405
query3	6653	208	203	203
query4	37005	21622	21290	21290
query5	4125	378	390	378
query6	233	188	183	183
query7	4044	279	276	276
query8	226	168	163	163
query9	5753	2248	2250	2248
query10	365	231	239	231
query11	14750	14167	14206	14167
query12	135	84	84	84
query13	981	344	350	344
query14	9909	7097	6849	6849
query15	202	176	178	176
query16	6782	262	251	251
query17	1675	582	552	552
query18	1385	290	268	268
query19	201	154	155	154
query20	88	84	84	84
query21	198	130	127	127
query22	5083	4965	4866	4866
query23	33472	32978	33187	32978
query24	12558	3045	3024	3024
query25	564	402	399	399
query26	1696	152	155	152
query27	3375	353	358	353
query28	7650	2101	2076	2076
query29	883	617	606	606
query30	284	174	172	172
query31	980	724	742	724
query32	64	54	52	52
query33	588	256	247	247
query34	966	489	508	489
query35	857	706	731	706
query36	1040	942	928	928
query37	223	69	71	69
query38	3645	3608	3568	3568
query39	1646	1586	1554	1554
query40	230	136	127	127
query41	54	43	46	43
query42	111	97	96	96
query43	573	542	516	516
query44	1332	721	740	721
query45	298	269	289	269
query46	1083	708	761	708
query47	2043	1980	1999	1980
query48	389	305	299	299
query49	944	374	384	374
query50	785	389	390	389
query51	6900	6806	6715	6715
query52	117	83	89	83
query53	348	273	274	273
query54	247	238	228	228
query55	71	70	70	70
query56	231	219	224	219
query57	1202	1154	1203	1154
query58	205	194	191	191
query59	3649	3751	3303	3303
query60	240	228	229	228
query61	89	85	107	85
query62	601	429	434	429
query63	302	271	280	271
query64	4942	3909	3860	3860
query65	3126	3056	3069	3056
query66	1257	314	304	304
query67	15751	14994	15010	14994
query68	10699	542	532	532
query69	616	300	293	293
query70	1435	1191	1164	1164
query71	554	269	259	259
query72	6555	2608	2440	2440
query73	1911	311	311	311
query74	6994	6291	6343	6291
query75	3759	2339	2299	2299
query76	6715	1158	1136	1136
query77	587	241	247	241
query78	11097	10286	10113	10113
query79	10567	508	510	508
query80	1774	418	419	418
query81	534	225	235	225
query82	241	92	90	90
query83	210	161	158	158
query84	258	76	84	76
query85	1034	266	259	259
query86	355	304	290	290
query87	3696	3517	3474	3474
query88	5820	2357	2286	2286
query89	505	373	388	373
query90	2270	177	179	177
query91	121	94	91	91
query92	64	45	46	45
query93	5637	497	509	497
query94	1473	177	176	176
query95	392	294	286	286
query96	609	260	266	260
query97	2646	2502	2470	2470
query98	221	210	219	210
query99	1094	822	847	822
Total cold run time: 315579 ms
Total hot run time: 183002 ms

[doris-robot]

ClickBench: Total hot run time: 30.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b4fb73569669adfdaf230b1cfeff0169aceb4f68, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.47	0.48
query6	1.14	0.65	0.66
query7	0.02	0.01	0.01
query8	0.05	0.03	0.04
query9	0.57	0.50	0.50
query10	0.54	0.55	0.55
query11	0.14	0.11	0.11
query12	0.14	0.12	0.12
query13	0.61	0.59	0.58
query14	0.78	0.78	0.79
query15	0.82	0.80	0.80
query16	0.36	0.37	0.37
query17	0.91	0.93	0.92
query18	0.22	0.22	0.25
query19	1.77	1.69	1.71
query20	0.01	0.01	0.01
query21	15.43	0.66	0.66
query22	4.14	7.12	2.41
query23	18.30	1.33	1.26
query24	1.81	0.21	0.24
query25	0.15	0.08	0.08
query26	0.25	0.16	0.16
query27	0.09	0.07	0.08
query28	13.46	1.00	0.98
query29	12.62	3.32	3.32
query30	0.26	0.07	0.06
query31	2.88	0.38	0.38
query32	3.28	0.47	0.46
query33	2.80	2.84	2.89
query34	16.97	4.43	4.40
query35	4.47	4.44	4.49
query36	0.64	0.47	0.47
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.10	0.04	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.89 s
Total hot run time: 30.78 s

[doris-robot]

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit b4fb73569669adfdaf230b1cfeff0169aceb4f68 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      34 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.4 seconds inserted 10000000 Rows, about 746K ops/s

[AshinGau]

run buildall

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[doris-robot]

TeamCity be ut coverage result:
Function Coverage: 35.60% (8905/25016)
Line Coverage: 27.32% (73123/267667)
Region Coverage: 26.45% (37819/142981)
Branch Coverage: 23.20% (19270/83060)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eb8b7f8195f649c721d9c3bb62012b00bbab219d_eb8b7f8195f649c721d9c3bb62012b00bbab219d/report/index.html

[doris-robot]

TPC-H: Total hot run time: 38623 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eb8b7f8195f649c721d9c3bb62012b00bbab219d, data reload: false

------ Round 1 ----------------------------------
q1	17615	4451	4287	4287
q2	2004	190	180	180
q3	10467	1144	1146	1144
q4	10185	753	876	753
q5	7518	2699	2691	2691
q6	213	129	132	129
q7	989	611	577	577
q8	9222	2076	2049	2049
q9	7885	6563	6525	6525
q10	8649	3537	3527	3527
q11	476	237	236	236
q12	445	229	225	225
q13	18685	2990	2981	2981
q14	270	261	236	236
q15	530	479	476	476
q16	523	399	387	387
q17	965	749	725	725
q18	7406	6831	6593	6593
q19	5676	1511	1528	1511
q20	689	312	316	312
q21	3605	2802	2780	2780
q22	376	299	301	299
Total cold run time: 114393 ms
Total hot run time: 38623 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4373	4255	4257	4255
q2	373	264	265	264
q3	2941	2766	2731	2731
q4	1876	1562	1640	1562
q5	5321	5369	5365	5365
q6	210	123	123	123
q7	2252	1880	1903	1880
q8	3215	3362	3341	3341
q9	8611	8625	8716	8625
q10	4096	3913	4069	3913
q11	616	502	486	486
q12	823	668	625	625
q13	16064	3263	3161	3161
q14	313	287	289	287
q15	504	483	497	483
q16	508	445	439	439
q17	1816	1584	1507	1507
q18	8039	7999	7774	7774
q19	1703	1600	1609	1600
q20	1974	1860	1869	1860
q21	8335	4887	4880	4880
q22	550	458	484	458
Total cold run time: 74513 ms
Total hot run time: 55619 ms

[doris-robot]

TPC-DS: Total hot run time: 184635 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eb8b7f8195f649c721d9c3bb62012b00bbab219d, data reload: false

query1	890	1114	1103	1103
query2	6189	2739	2530	2530
query3	6676	202	195	195
query4	36640	21672	21570	21570
query5	4143	394	399	394
query6	244	191	183	183
query7	4049	284	285	284
query8	222	178	168	168
query9	5787	2302	2324	2302
query10	359	227	239	227
query11	14848	14192	14264	14192
query12	138	94	90	90
query13	1001	359	345	345
query14	9271	6934	7024	6934
query15	218	175	192	175
query16	6739	256	258	256
query17	1669	588	562	562
query18	1383	298	273	273
query19	192	154	154	154
query20	94	86	88	86
query21	192	132	129	129
query22	4997	4817	4775	4775
query23	33396	33077	32980	32980
query24	6797	3082	3067	3067
query25	493	405	405	405
query26	755	169	171	169
query27	2821	358	390	358
query28	4742	2106	2105	2105
query29	885	652	663	652
query30	331	181	183	181
query31	941	720	757	720
query32	66	55	52	52
query33	478	268	239	239
query34	918	490	497	490
query35	818	724	719	719
query36	1097	959	951	951
query37	108	71	72	71
query38	3738	3713	3608	3608
query39	1626	1582	1591	1582
query40	186	135	132	132
query41	48	49	49	49
query42	103	99	97	97
query43	600	596	567	567
query44	1124	741	757	741
query45	311	288	266	266
query46	1083	744	722	722
query47	2032	1926	1962	1926
query48	395	293	314	293
query49	744	382	369	369
query50	783	391	395	391
query51	6850	6749	6811	6749
query52	105	88	97	88
query53	357	282	291	282
query54	269	249	241	241
query55	81	74	74	74
query56	249	220	229	220
query57	1290	1211	1203	1203
query58	244	217	204	204
query59	3615	3245	3061	3061
query60	254	223	235	223
query61	92	91	89	89
query62	570	424	441	424
query63	299	276	271	271
query64	4262	3973	3951	3951
query65	3082	3053	3006	3006
query66	740	312	308	308
query67	15510	15078	14842	14842
query68	10684	558	555	555
query69	620	306	299	299
query70	1288	1153	1183	1153
query71	521	268	271	268
query72	6533	2595	2462	2462
query73	1632	317	316	316
query74	6976	6336	6431	6336
query75	3641	2357	2354	2354
query76	6456	1141	1112	1112
query77	638	246	239	239
query78	10956	10267	10149	10149
query79	11688	528	517	517
query80	2321	422	420	420
query81	569	231	235	231
query82	237	91	94	91
query83	215	163	166	163
query84	267	86	81	81
query85	1088	263	262	262
query86	352	308	301	301
query87	3772	3568	3519	3519
query88	6157	2260	2274	2260
query89	507	375	367	367
query90	2364	179	176	176
query91	122	95	98	95
query92	60	47	47	47
query93	6567	500	508	500
query94	1581	185	176	176
query95	384	288	293	288
query96	609	266	260	260
query97	2641	2527	2510	2510
query98	220	217	213	213
query99	1068	859	850	850
Total cold run time: 303963 ms
Total hot run time: 184635 ms

[doris-robot]

ClickBench: Total hot run time: 30.09 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eb8b7f8195f649c721d9c3bb62012b00bbab219d, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.49	0.48
query6	1.13	0.65	0.66
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.51	0.51
query10	0.55	0.56	0.57
query11	0.16	0.12	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.59
query14	0.76	0.78	0.80
query15	0.82	0.81	0.80
query16	0.38	0.37	0.37
query17	0.95	1.05	1.01
query18	0.23	0.23	0.23
query19	1.80	1.67	1.80
query20	0.02	0.01	0.01
query21	15.42	0.66	0.65
query22	4.76	7.21	1.65
query23	18.29	1.37	1.31
query24	2.04	0.22	0.19
query25	0.15	0.08	0.08
query26	0.28	0.16	0.17
query27	0.08	0.08	0.07
query28	13.33	1.00	0.97
query29	12.61	3.27	3.32
query30	0.26	0.06	0.06
query31	2.86	0.38	0.37
query32	3.30	0.47	0.46
query33	2.84	2.83	2.82
query34	16.96	4.39	4.41
query35	4.44	4.49	4.48
query36	0.64	0.48	0.46
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.05	0.03	0.04
query40	0.19	0.14	0.16
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.72 s
Total hot run time: 30.09 s

[doris-robot]

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit eb8b7f8195f649c721d9c3bb62012b00bbab219d with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      34 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.4 seconds inserted 10000000 Rows, about 746K ops/s