Skip to content

[SegmentV2] Fix bloom filter bits buffer not initialize as 0 #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 2 commits into from
Apr 22, 2020
Merged

[SegmentV2] Fix bloom filter bits buffer not initialize as 0 #3372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56fbe17
[SegmentV2] Fix bloom filter bits buffer not initialize as 0
acelyc111 Apr 17, 2020
a86ff47
update ut
acelyc111 Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions be/src/olap/rowset/segment_v2/bloom_filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class BloomFilter {
_size = _num_bytes + 1;
// reserve last byte for null flag
_data = new char[_size];
memset(_data, 0, _size);
_has_null = (bool*)(_data + _num_bytes);
*_has_null = false;
return Status::OK();
Expand Down
38 changes: 27 additions & 11 deletions be/test/olap/rowset/segment_v2/block_bloom_filter_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,27 +103,43 @@ TEST_F(BlockBloomFilterTest, SP) {
ASSERT_TRUE(st.ok());
ASSERT_TRUE(bf2->size() > 0);

int num = 1024;
int32_t values[1024];
for (int32_t i = 0; i < 1024; ++i) {
int num = _expected_num;
int32_t values[num];
for (int32_t i = 0; i < num; ++i) {
values[i] = i * 10 + 1;
}
for (int i = 0; i < num; ++i) {
bf->add_bytes((char*)&values[i], sizeof(int32_t));
}

int32_t values2[1024];
for (int32_t i = 0; i < 1024; ++i) {
int32_t values2[num];
for (int32_t i = 0; i < num; ++i) {
values2[i] = 15360 + i * 10 + 1;
bf2->add_bytes((char*)&values2[i], sizeof(int32_t));
}

// true test
for (int i = 0; i < num; ++i) {
bf2->add_bytes((char*)&values2[i], sizeof(int32_t));
ASSERT_TRUE(bf->test_bytes((char*)&values[i], 4));
ASSERT_TRUE(bf2->test_bytes((char*)&values2[i], 4));
}

int32_t to_check = 101;
ASSERT_TRUE(bf->test_bytes((char*)&to_check, 4));
ASSERT_FALSE(bf2->test_bytes((char*)&to_check, 4));
// false test
int false_count1 = 0;
int false_count2 = 0;
for (int i = 0; i < num; ++i) {
int32_t to_check1 = values[i];
for (int j = 1; j < 10; ++j) {
++to_check1;
false_count1 += bf->test_bytes((char*)&to_check1, 4);
}

int32_t to_check2 = values2[i];
for (int j = 1; j < 10; ++j) {
++to_check2;
false_count2 += bf2->test_bytes((char*)&to_check2, 4);
}
}
ASSERT_LE((double)false_count1 / (num * 9), _fpp);
ASSERT_LE((double)false_count2 / (num * 9), _fpp);
}

// Test for slice
Expand Down