Skip to content

[Fix](Variant) VariantRootColumnIterator::read_by_rowids with wrong null map size #33734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Apr 18, 2024
Merged

[Fix](Variant) VariantRootColumnIterator::read_by_rowids with wrong null map size #33734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions be/src/olap/rowset/segment_v2/column_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ Status VariantRootColumnIterator::read_by_rowids(const rowid_t* rowids, const si
RETURN_IF_ERROR(_inner_iter->read_by_rowids(rowids, count, root_column));
obj.incr_num_rows(count);
for (auto& entry : obj.get_subcolumns()) {
if (entry->data.size() != size + count) {
if (entry->data.size() != (size + count)) {
entry->data.insertManyDefaults(count);
}
}
Expand All @@ -1547,7 +1547,8 @@ Status VariantRootColumnIterator::read_by_rowids(const rowid_t* rowids, const si
assert_cast<vectorized::ColumnNullable&>(*dst).get_null_map_column();
vectorized::ColumnUInt8& src_null_map =
assert_cast<vectorized::ColumnNullable&>(*root_column).get_null_map_column();
dst_null_map.insert_range_from(src_null_map, 0, src_null_map.size());
DCHECK_EQ(src_null_map.size() - size, count);
dst_null_map.insert_range_from(src_null_map, size, count);
}
#ifndef NDEBUG
obj.check_consistency();
Expand Down
14 changes: 14 additions & 0 deletions regression-test/data/variant_p0/topn_opt_read_by_rowids.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !sql --
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N

-- !sql --
2024-04-09T09:02:31 1712624495211 004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser1":"Chrome 123.0.0.0","browserFlag1":"a8ba48f1849c2423","browserName4":"Chrome","browserVersion7":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.033.53.19, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:03:32 1712624474153 0014.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser2":"Chrome 123.0.0.0","browserFlag2":"a8ba48f1849c2423","browserName5":"Chrome","browserVersion8":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:04:33 1712624474959 0024.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser3":"Chrome 123.0.0.0","browserFlag3":"a8ba48f1849c2423","browserName6":"Chrome","browserVersion9":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N
2024-04-09T09:01:39 1712624474952 0004.00 740lp sit-iniwork-lcd-designer.qm.cn \N \N 630beed604d0513c 0000.0 \N https://sit-iniwork-lcd-designer.qm.cn/designer 1544512389907021826 https://sit-iniwork-lcd-designer.qm.cn/designer?caseName=44&caseCode=d4&appId=3fec598d32b10d26958d1d9119519c64&token=eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiI3NDBscCIsImNyZWF0ZWQiOjE3MTI1NDEzMTU0MzUsImlkbWlkIjpudWxsLCJleHAiOjE3MTMxNDYxMTUsInVwa2lkIjoiMTU0NDUxMjM4OTkwNzAyMTgyNiJ9.j8sJbrgrJzwPh5Ee1AoodqIJ7KsMT_qfUhZlyon6rRsMClRI5WpUYpSWkC7P-axolUUnWJi2Llw89hO_KyL_gg&formId=8f4f75e0c0aa93fcd0a4eae843114527&tenantId=YQJT&systemId=202203A-015&subType=0 202203A-015_APP_DES 20240409090114952 未知 {"browser":"Chrome 123.0.0.0","browserFlag":"a8ba48f1849c2423","browserName":"Chrome","browserVersion":"123.0.0.0","clientStr":"10.133.53.99","headerClient":"{X-Original-Forwarded-For=10.133.53.99, X-Forwarded-For=10.140.199.9, RemoteAddr=10.133.53.99, X-Real-IP=10.140.199.9}","os":"Windows 10","osName":"Windows","osVersion":"10","res":"1920x1080","type":"Computer"} 1712624474952 1712624475992 \N \N

Loading