Skip to content

[fix](regression test) fix test_schema_change_fail #33753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Apr 17, 2024
Merged

[fix](regression test) fix test_schema_change_fail #33753

yiguolei merged 2 commits into from
Apr 17, 2024

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Apr 17, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Contributor Author

yujun777 commented Apr 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TeamCity be ut coverage result:
Function Coverage: 35.49% (8907/25096)
Line Coverage: 27.22% (73151/268759)
Region Coverage: 26.35% (37828/143571)
Branch Coverage: 23.13% (19271/83328)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9958cd07cb94004d187ed53d0279499c73d196e8_9958cd07cb94004d187ed53d0279499c73d196e8/report/index.html

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-H: Total hot run time: 38927 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9958cd07cb94004d187ed53d0279499c73d196e8, data reload: false

------ Round 1 ----------------------------------
q1	17625	4424	4327	4327
q2	2476	195	190	190
q3	11094	1206	1203	1203
q4	11276	829	818	818
q5	7674	2779	2676	2676
q6	220	133	142	133
q7	1068	627	629	627
q8	9498	2098	2077	2077
q9	7498	6594	6564	6564
q10	8426	3503	3514	3503
q11	430	239	229	229
q12	385	226	220	220
q13	18764	2936	2950	2936
q14	275	237	223	223
q15	531	488	491	488
q16	517	400	386	386
q17	950	708	677	677
q18	7530	6790	6762	6762
q19	6530	1530	1520	1520
q20	655	323	304	304
q21	3490	2759	2884	2759
q22	354	314	305	305
Total cold run time: 117266 ms
Total hot run time: 38927 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4414	4232	4203	4203
q2	373	273	263	263
q3	2966	2739	2786	2739
q4	1910	1597	1583	1583
q5	5289	5315	5316	5315
q6	209	123	123	123
q7	2228	1885	1866	1866
q8	3212	3323	3334	3323
q9	8603	8571	8614	8571
q10	3870	3714	3659	3659
q11	590	477	478	477
q12	788	571	594	571
q13	16310	2964	2917	2917
q14	299	290	260	260
q15	519	476	461	461
q16	483	441	425	425
q17	1762	1469	1467	1467
q18	7613	7462	7479	7462
q19	1640	1545	1555	1545
q20	1947	1766	1733	1733
q21	4890	4660	4706	4660
q22	548	461	464	461
Total cold run time: 70463 ms
Total hot run time: 54084 ms

@Lchangliang
Copy link
Contributor

Lchangliang commented Apr 17, 2024

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-DS: Total hot run time: 183941 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9958cd07cb94004d187ed53d0279499c73d196e8, data reload: false

query1	907	370	362	362
query2	6483	2440	2310	2310
query3	6651	203	204	203
query4	22803	21246	21264	21246
query5	4186	400	397	397
query6	271	194	175	175
query7	4576	294	283	283
query8	228	172	168	168
query9	8546	2375	2365	2365
query10	580	248	255	248
query11	14685	14458	14175	14175
query12	141	92	90	90
query13	1638	373	375	373
query14	10036	7832	7527	7527
query15	276	185	185	185
query16	8183	267	262	262
query17	1917	587	552	552
query18	2111	280	278	278
query19	308	190	154	154
query20	91	84	87	84
query21	207	126	124	124
query22	4973	4790	4793	4790
query23	33803	33063	33124	33063
query24	11802	2915	2897	2897
query25	658	364	370	364
query26	1728	152	150	150
query27	2907	318	313	313
query28	7505	2023	2000	2000
query29	1022	612	585	585
query30	288	171	171	171
query31	971	739	722	722
query32	84	53	53	53
query33	749	258	243	243
query34	1030	496	488	488
query35	843	687	684	684
query36	1047	932	937	932
query37	275	69	70	69
query38	3408	3207	3148	3148
query39	1578	1530	1530	1530
query40	274	126	122	122
query41	47	42	44	42
query42	103	95	93	93
query43	577	517	541	517
query44	1258	721	718	718
query45	280	266	269	266
query46	1069	720	722	720
query47	1905	1843	1849	1843
query48	362	297	298	297
query49	1165	371	387	371
query50	750	386	405	386
query51	6617	6551	6621	6551
query52	103	89	91	89
query53	340	271	276	271
query54	305	243	226	226
query55	77	73	70	70
query56	241	225	223	223
query57	1218	1107	1147	1107
query58	219	202	197	197
query59	3576	2986	3238	2986
query60	254	230	236	230
query61	101	88	100	88
query62	655	439	456	439
query63	302	279	283	279
query64	6361	3835	3816	3816
query65	3134	3046	3024	3024
query66	1372	334	326	326
query67	15186	15204	14938	14938
query68	5211	535	544	535
query69	515	295	299	295
query70	1250	1196	1181	1181
query71	1392	1270	1260	1260
query72	6336	2636	2412	2412
query73	704	325	323	323
query74	6792	6419	6346	6346
query75	3470	2645	2611	2611
query76	3373	984	960	960
query77	405	263	256	256
query78	10857	10254	10179	10179
query79	2897	528	525	525
query80	1921	426	425	425
query81	519	242	235	235
query82	844	94	95	94
query83	265	166	171	166
query84	263	87	87	87
query85	2161	309	257	257
query86	485	316	288	288
query87	3444	3251	3217	3217
query88	4460	2425	2430	2425
query89	495	360	371	360
query90	2041	181	177	177
query91	124	101	103	101
query92	59	49	47	47
query93	4913	515	505	505
query94	1273	175	178	175
query95	392	306	297	297
query96	598	273	266	266
query97	3139	2912	2960	2912
query98	232	220	212	212
query99	1216	841	814	814
Total cold run time: 289392 ms
Total hot run time: 183941 ms

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9958cd07cb94004d187ed53d0279499c73d196e8, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.03	0.04
query3	0.22	0.04	0.04
query4	1.69	0.07	0.08
query5	0.49	0.49	0.48
query6	1.48	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.50	0.51
query10	0.54	0.54	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.60	0.58	0.58
query14	0.76	0.77	0.76
query15	0.82	0.80	0.79
query16	0.34	0.35	0.38
query17	0.93	0.95	0.98
query18	0.22	0.22	0.26
query19	1.72	1.68	1.75
query20	0.02	0.01	0.00
query21	15.43	0.65	0.65
query22	4.60	7.48	1.95
query23	18.30	1.38	1.33
query24	1.65	0.34	0.22
query25	0.15	0.09	0.08
query26	0.28	0.18	0.17
query27	0.08	0.08	0.08
query28	13.30	0.98	0.98
query29	12.56	3.30	3.30
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.29	0.47	0.46
query33	2.80	2.84	2.82
query34	17.06	4.43	4.44
query35	4.61	4.51	4.50
query36	0.65	0.46	0.46
query37	0.18	0.15	0.16
query38	0.14	0.14	0.16
query39	0.05	0.04	0.04
query40	0.16	0.14	0.16
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.45 s
Total hot run time: 30.49 s

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9958cd07cb94004d187ed53d0279499c73d196e8 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

@yujun777
Copy link
Contributor Author

yujun777 commented Apr 17, 2024

run p0

dataroaring
dataroaring previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 17, 2024
@yujun777
Copy link
Contributor Author

yujun777 commented Apr 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TeamCity be ut coverage result:
Function Coverage: 35.46% (8908/25122)
Line Coverage: 27.16% (73144/269323)
Region Coverage: 26.29% (37816/143866)
Branch Coverage: 23.08% (19272/83484)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a9f7b1c652970f4a8c0f1895d4d80f2ecb1e3a7a_a9f7b1c652970f4a8c0f1895d4d80f2ecb1e3a7a/report/index.html

yiguolei
yiguolei approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 1e324b5 into apache:master Apr 17, 2024
@yujun777 yujun777 mentioned this pull request Apr 17, 2024
Merged
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@yujun777
[branch-2.1](regression-test) fix test_chema_change_fail (#33753) #33788
e9e4699
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@yujun777 @Doris-Extras
[branch-2.1](regression-test) fix test_chema_change_fail (#33753) #33788
11f7d11
dataroaring pushed a commit that referenced this pull request Apr 24, 2024
@yujun777 @dataroaring
[fix](regression test) fix test_schema_change_fail (#33753)
48d888e 
* fix test_schema_change_fail

* update
@yujun777 yujun777 removed the dev/2.0.x label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring dataroaring left review comments

+1 more reviewer

@Lchangliang Lchangliang Lchangliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yujun777 @doris-robot @Lchangliang @yiguolei @dataroaring @xiaokang