Skip to content

[fix](conf) make be conf disable_storage_page_cache modifiable #33773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 17, 2024
Merged

[fix](conf) make be conf disable_storage_page_cache modifiable #33773

dataroaring merged 1 commit into from
Apr 17, 2024

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Apr 17, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@freemandealer
[fix](conf) make be conf disable_storage_page_cache modifiable
d3ac1af 
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@freemandealer
Copy link
Contributor Author

freemandealer commented Apr 17, 2024

run buildall

dataroaring
dataroaring approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TeamCity be ut coverage result:
Function Coverage: 35.45% (8908/25125)
Line Coverage: 27.14% (73150/269486)
Region Coverage: 26.28% (37817/143903)
Branch Coverage: 23.08% (19270/83502)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d3ac1af82de89561a984d314fa6caed5cbc6b1a8_d3ac1af82de89561a984d314fa6caed5cbc6b1a8/report/index.html

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-H: Total hot run time: 38262 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d3ac1af82de89561a984d314fa6caed5cbc6b1a8, data reload: false

------ Round 1 ----------------------------------
q1	17619	4440	4225	4225
q2	2013	194	187	187
q3	10456	1146	1217	1146
q4	10192	833	767	767
q5	7493	2714	2649	2649
q6	219	131	132	131
q7	1010	597	581	581
q8	9223	2077	2055	2055
q9	7234	6621	6579	6579
q10	8486	3543	3505	3505
q11	480	231	223	223
q12	429	219	212	212
q13	17757	2928	2981	2928
q14	270	225	229	225
q15	535	488	479	479
q16	530	385	377	377
q17	975	654	700	654
q18	7516	6775	6631	6631
q19	7712	1453	1500	1453
q20	653	315	302	302
q21	3438	2655	2868	2655
q22	363	298	313	298
Total cold run time: 114603 ms
Total hot run time: 38262 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4393	4256	4266	4256
q2	371	278	267	267
q3	2973	2747	2662	2662
q4	1884	1580	1578	1578
q5	5323	5314	5310	5310
q6	214	126	127	126
q7	2253	1879	1858	1858
q8	3240	3383	3395	3383
q9	8578	8537	8671	8537
q10	4050	3872	4005	3872
q11	614	494	498	494
q12	792	619	644	619
q13	17268	3258	3162	3162
q14	321	306	288	288
q15	561	486	486	486
q16	509	445	443	443
q17	1845	1534	1526	1526
q18	8147	8119	7660	7660
q19	1700	1547	1613	1547
q20	2037	1863	1813	1813
q21	9180	5004	4852	4852
q22	531	476	479	476
Total cold run time: 76784 ms
Total hot run time: 55215 ms

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-DS: Total hot run time: 185481 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d3ac1af82de89561a984d314fa6caed5cbc6b1a8, data reload: false

query1	891	383	364	364
query2	6189	2726	2429	2429
query3	6649	207	201	201
query4	25457	21267	21300	21267
query5	4149	411	409	409
query6	291	192	173	173
query7	4580	291	284	284
query8	227	185	168	168
query9	8368	2326	2298	2298
query10	413	248	253	248
query11	14661	14170	14231	14170
query12	134	86	82	82
query13	1650	353	347	347
query14	9998	7144	7939	7144
query15	262	179	191	179
query16	8236	261	254	254
query17	2005	592	543	543
query18	2093	273	271	271
query19	327	147	145	145
query20	90	87	82	82
query21	196	117	123	117
query22	5060	4867	4806	4806
query23	33758	33234	33013	33013
query24	11363	3068	3102	3068
query25	627	399	422	399
query26	1521	153	156	153
query27	3097	358	369	358
query28	7586	2082	2076	2076
query29	933	618	611	611
query30	275	191	184	184
query31	1009	756	762	756
query32	93	51	54	51
query33	742	249	263	249
query34	1147	493	496	493
query35	844	690	720	690
query36	1069	955	918	918
query37	137	65	69	65
query38	3480	3320	3341	3320
query39	1650	1603	1599	1599
query40	229	131	124	124
query41	45	44	40	40
query42	99	97	96	96
query43	583	553	538	538
query44	1302	726	733	726
query45	285	281	276	276
query46	1100	761	730	730
query47	2057	1951	2012	1951
query48	372	294	290	290
query49	934	386	378	378
query50	766	394	395	394
query51	6953	6799	6874	6799
query52	100	86	84	84
query53	342	268	272	268
query54	300	228	242	228
query55	78	74	75	74
query56	257	214	222	214
query57	1249	1158	1126	1126
query58	228	198	199	198
query59	3371	3276	3089	3089
query60	241	230	232	230
query61	87	85	101	85
query62	610	446	441	441
query63	301	270	272	270
query64	6064	4050	3919	3919
query65	3117	3060	3023	3023
query66	1280	338	340	338
query67	15479	15258	15262	15258
query68	5899	533	546	533
query69	529	306	313	306
query70	1264	1157	1179	1157
query71	1449	1272	1264	1264
query72	6827	2768	2575	2575
query73	719	320	317	317
query74	6829	6366	6459	6366
query75	3659	2645	2645	2645
query76	3702	996	974	974
query77	553	264	270	264
query78	10922	10251	10223	10223
query79	8995	520	517	517
query80	1950	441	457	441
query81	523	254	242	242
query82	1550	96	97	96
query83	332	170	171	170
query84	268	89	85	85
query85	1519	322	316	316
query86	456	307	304	304
query87	3477	3290	3263	3263
query88	5257	2343	2339	2339
query89	563	360	364	360
query90	1912	181	179	179
query91	131	104	105	104
query92	54	50	51	50
query93	7202	503	498	498
query94	1104	183	179	179
query95	384	300	304	300
query96	595	268	260	260
query97	3200	2999	2918	2918
query98	233	221	216	216
query99	1265	849	881	849
Total cold run time: 302408 ms
Total hot run time: 185481 ms

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

ClickBench: Total hot run time: 30.16 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d3ac1af82de89561a984d314fa6caed5cbc6b1a8, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.67	0.09	0.08
query5	0.50	0.49	0.50
query6	1.48	0.73	0.71
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.48	0.49
query10	0.55	0.56	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.59	0.58
query14	0.76	0.80	0.77
query15	0.83	0.81	0.81
query16	0.35	0.36	0.36
query17	1.02	0.98	1.00
query18	0.20	0.24	0.25
query19	1.88	1.68	1.80
query20	0.01	0.01	0.01
query21	15.41	0.65	0.64
query22	4.78	6.92	1.73
query23	18.26	1.33	1.20
query24	1.58	0.37	0.21
query25	0.15	0.08	0.08
query26	0.26	0.16	0.16
query27	0.08	0.09	0.07
query28	13.34	1.01	0.97
query29	12.59	3.30	3.29
query30	0.26	0.06	0.06
query31	2.86	0.36	0.38
query32	3.32	0.46	0.46
query33	2.80	2.82	2.84
query34	17.04	4.43	4.49
query35	4.50	4.50	4.51
query36	0.64	0.48	0.47
query37	0.18	0.15	0.14
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.17	0.13	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.03	0.03	0.04
Total cold run time: 109.74 s
Total hot run time: 30.16 s

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d3ac1af82de89561a984d314fa6caed5cbc6b1a8 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.6 seconds inserted 10000000 Rows, about 735K ops/s

@dataroaring dataroaring merged commit d16b7ce into apache:master Apr 17, 2024
dataroaring pushed a commit that referenced this pull request Apr 17, 2024
@freemandealer @dataroaring
[fix](conf) make be conf disable_storage_page_cache modifiable (#33773)
4ddb9bf 
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@freemandealer @Doris-Extras
[fix](conf) make be conf disable_storage_page_cache modifiable (#33773)
5045caf 
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@freemandealer @Doris-Extras
[fix](conf) make be conf disable_storage_page_cache modifiable (#33773)
ee3b6fd 
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@feifeifeimoon feifeifeimoon feifeifeimoon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freemandealer @doris-robot @feifeifeimoon @dataroaring