Skip to content

[fix](planner)create view statement should forbid mv rewrite #33784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Apr 18, 2024
Merged

[fix](planner)create view statement should forbid mv rewrite #33784

morrySnow merged 2 commits into from
Apr 18, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Apr 17, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Apr 17, 2024

run buildall

@starocean999 starocean999 mentioned this pull request Apr 17, 2024
Merged
@starocean999
Copy link
Contributor Author

starocean999 commented Apr 17, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-H: Total hot run time: 38766 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a67e10d77e8f3519f281f6c741b7b0ff063c367, data reload: false

------ Round 1 ----------------------------------
q1	17614	4261	4264	4261
q2	2014	202	181	181
q3	10444	1105	1153	1105
q4	10189	912	823	823
q5	7513	2711	2641	2641
q6	220	132	133	132
q7	1004	603	591	591
q8	9231	2052	2041	2041
q9	7359	6550	6557	6550
q10	8671	3540	3524	3524
q11	450	239	234	234
q12	409	225	219	219
q13	17867	2963	2946	2946
q14	259	227	221	221
q15	523	484	496	484
q16	535	384	388	384
q17	957	691	728	691
q18	7484	6879	6822	6822
q19	7094	1558	1536	1536
q20	696	322	308	308
q21	3528	2763	2841	2763
q22	376	315	309	309
Total cold run time: 114437 ms
Total hot run time: 38766 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4362	4252	4232	4232
q2	373	267	268	267
q3	3026	2767	2811	2767
q4	1925	1641	1589	1589
q5	5425	5403	5359	5359
q6	211	126	125	125
q7	2220	1882	1875	1875
q8	3245	3382	3369	3369
q9	8879	8718	8965	8718
q10	4244	4114	4231	4114
q11	630	527	517	517
q12	857	687	662	662
q13	18439	3203	3288	3203
q14	324	291	296	291
q15	567	487	493	487
q16	513	470	470	470
q17	1844	1571	1516	1516
q18	8138	7899	7822	7822
q19	1732	1584	1557	1557
q20	2006	1866	1882	1866
q21	13910	4974	4988	4974
q22	519	500	487	487
Total cold run time: 83389 ms
Total hot run time: 56267 ms

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

TPC-DS: Total hot run time: 185828 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a67e10d77e8f3519f281f6c741b7b0ff063c367, data reload: false

query1	894	372	367	367
query2	6232	2707	2355	2355
query3	6649	211	206	206
query4	22658	21469	21353	21353
query5	4130	414	415	414
query6	274	193	183	183
query7	4601	285	289	285
query8	223	171	174	171
query9	8385	2301	2291	2291
query10	415	245	245	245
query11	14809	14221	14357	14221
query12	137	87	83	83
query13	1622	364	355	355
query14	9529	7698	7996	7698
query15	253	183	181	181
query16	8195	261	265	261
query17	1925	595	569	569
query18	2102	286	276	276
query19	208	156	154	154
query20	100	89	94	89
query21	206	135	132	132
query22	5007	4832	4791	4791
query23	33797	33198	33246	33198
query24	11379	3006	3103	3006
query25	659	411	399	399
query26	1060	166	162	162
query27	2636	381	369	369
query28	7225	2090	2040	2040
query29	890	658	713	658
query30	320	186	188	186
query31	948	778	780	778
query32	95	51	51	51
query33	733	256	242	242
query34	1172	490	497	490
query35	861	746	731	731
query36	1078	924	921	921
query37	133	76	74	74
query38	3567	3255	3436	3255
query39	1087	1044	1043	1043
query40	177	134	133	133
query41	45	44	48	44
query42	100	100	100	100
query43	613	564	557	557
query44	1241	735	746	735
query45	304	292	271	271
query46	1103	756	758	756
query47	1992	1967	1914	1914
query48	375	300	299	299
query49	878	370	382	370
query50	778	402	413	402
query51	6830	6818	6816	6816
query52	95	94	90	90
query53	348	288	286	286
query54	311	236	240	236
query55	92	76	78	76
query56	254	244	256	244
query57	1285	1225	1160	1160
query58	224	198	199	198
query59	3751	3331	3138	3138
query60	252	234	228	228
query61	88	88	83	83
query62	594	430	436	430
query63	314	282	282	282
query64	5013	4115	3933	3933
query65	3066	3042	3038	3038
query66	788	330	325	325
query67	15385	15171	14799	14799
query68	5307	536	536	536
query69	496	309	291	291
query70	1235	1173	1203	1173
query71	1417	1269	1271	1269
query72	6341	2658	2454	2454
query73	701	317	324	317
query74	6906	6466	6380	6380
query75	3593	2694	2602	2602
query76	3398	923	889	889
query77	626	263	262	262
query78	10959	10285	10128	10128
query79	7691	514	517	514
query80	1942	421	427	421
query81	522	249	242	242
query82	1495	92	94	92
query83	339	166	166	166
query84	266	89	129	89
query85	1465	260	262	260
query86	474	306	282	282
query87	3471	3278	3325	3278
query88	5176	2299	2297	2297
query89	489	373	376	373
query90	1972	177	176	176
query91	124	98	95	95
query92	61	47	47	47
query93	6287	504	494	494
query94	1079	179	171	171
query95	1093	1098	1085	1085
query96	617	261	264	261
query97	3148	2947	2902	2902
query98	244	218	218	218
query99	1202	848	838	838
Total cold run time: 292626 ms
Total hot run time: 185828 ms

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

ClickBench: Total hot run time: 29.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a67e10d77e8f3519f281f6c741b7b0ff063c367, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.04
query4	1.67	0.07	0.08
query5	0.51	0.50	0.50
query6	1.48	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.53	0.50	0.49
query10	0.55	0.57	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.58	0.58
query14	0.76	0.76	0.76
query15	0.82	0.80	0.80
query16	0.37	0.36	0.37
query17	1.01	1.04	1.04
query18	0.23	0.23	0.22
query19	1.74	1.70	1.69
query20	0.01	0.01	0.01
query21	15.41	0.66	0.64
query22	5.03	7.54	1.38
query23	18.28	1.34	1.27
query24	2.04	0.22	0.20
query25	0.14	0.07	0.09
query26	0.26	0.17	0.16
query27	0.08	0.08	0.08
query28	13.37	1.00	0.97
query29	12.69	3.27	3.24
query30	0.26	0.07	0.05
query31	2.85	0.38	0.36
query32	3.28	0.46	0.46
query33	2.84	2.81	2.86
query34	16.98	4.37	4.35
query35	4.49	4.46	4.53
query36	0.64	0.45	0.48
query37	0.18	0.16	0.16
query38	0.16	0.14	0.14
query39	0.05	0.03	0.03
query40	0.17	0.13	0.14
query41	0.09	0.04	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 110.38 s
Total hot run time: 29.69 s

@doris-robot
Copy link

doris-robot commented Apr 17, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 3a67e10d77e8f3519f281f6c741b7b0ff063c367 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

@starocean999 starocean999 marked this pull request as ready for review April 18, 2024 01:16
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 1a9d7cc into apache:master Apr 18, 2024
@morrySnow morrySnow added usercase Important user case type label dev/2.0.x labels Apr 18, 2024
yiguolei pushed a commit that referenced this pull request Apr 18, 2024
@starocean999 @Doris-Extras
[fix](planner) create view statement should forbid mv rewrite (#33784)
a05d738
dataroaring pushed a commit that referenced this pull request Apr 24, 2024
@starocean999 @dataroaring
[fix](planner) create view statement should forbid mv rewrite (#33784)
98bee75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.9-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starocean999 @doris-robot @BiteTheDDDDt @morrySnow @wm1581066