Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

Before, analyze_timeout will also affect analyze stmt, which may cause failed to cancel analyze task. This PR change analyze_timeout to only affect timeout value for executing analyze sql.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review April 18, 2024 07:34
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li Jibing-Li force-pushed the timeout branch 2 times, most recently from 115e5f4 to 7dba9d7 Compare April 25, 2024 07:06
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 187704 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2516316cf0b8eccd8a8c843fc248dd18fd1b88fa, data reload: false

query1	894	363	340	340
query2	6269	2519	2436	2436
query3	6634	201	200	200
query4	24531	21942	21881	21881
query5	3903	418	419	418
query6	267	196	190	190
query7	4549	298	297	297
query8	241	202	195	195
query9	8455	2378	2373	2373
query10	401	254	269	254
query11	15245	14864	14863	14863
query12	121	86	89	86
query13	1617	366	354	354
query14	9763	6897	8333	6897
query15	274	177	173	173
query16	8174	250	252	250
query17	1910	545	535	535
query18	2075	272	264	264
query19	310	145	144	144
query20	85	81	80	80
query21	192	123	118	118
query22	5060	4822	4835	4822
query23	34057	33427	33330	33330
query24	10711	2895	2963	2895
query25	602	371	355	355
query26	1152	149	145	145
query27	2441	310	322	310
query28	7127	1982	1980	1980
query29	841	602	584	584
query30	247	147	147	147
query31	930	718	712	712
query32	88	48	49	48
query33	736	241	243	241
query34	1040	457	462	457
query35	842	666	679	666
query36	1030	921	923	921
query37	133	64	62	62
query38	3337	3189	3227	3189
query39	1571	1496	1541	1496
query40	207	122	124	122
query41	39	38	38	38
query42	104	92	92	92
query43	579	557	551	551
query44	1193	706	721	706
query45	270	270	254	254
query46	1065	734	696	696
query47	1937	1841	1881	1841
query48	366	293	288	288
query49	841	389	389	389
query50	756	385	373	373
query51	6928	6687	6681	6681
query52	105	88	85	85
query53	351	277	270	270
query54	309	241	237	237
query55	80	70	72	70
query56	267	228	235	228
query57	1208	1115	1142	1115
query58	223	199	200	199
query59	3658	3390	3285	3285
query60	257	234	236	234
query61	105	106	104	104
query62	635	441	457	441
query63	311	283	282	282
query64	8535	7223	7196	7196
query65	3128	3046	3051	3046
query66	840	352	342	342
query67	15616	14879	14939	14879
query68	8940	527	542	527
query69	549	303	302	302
query70	1146	1136	1075	1075
query71	518	269	261	261
query72	8581	2626	2410	2410
query73	743	313	312	312
query74	6821	6481	6385	6385
query75	4501	2625	2664	2625
query76	5306	1059	1039	1039
query77	742	257	261	257
query78	11044	10217	10227	10217
query79	13057	505	523	505
query80	2360	424	433	424
query81	490	226	215	215
query82	733	89	85	85
query83	213	169	167	167
query84	260	81	81	81
query85	1498	265	256	256
query86	399	289	299	289
query87	3460	3363	3258	3258
query88	5430	2333	2323	2323
query89	526	384	371	371
query90	1991	187	189	187
query91	123	98	96	96
query92	59	49	47	47
query93	7592	500	493	493
query94	1220	181	182	181
query95	392	292	299	292
query96	590	262	265	262
query97	3147	2942	2986	2942
query98	233	219	218	218
query99	1279	850	881	850
Total cold run time: 311711 ms
Total hot run time: 187704 ms

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Jibing-Li Jibing-Li merged commit 4646204 into apache:master Apr 26, 2024
@Jibing-Li Jibing-Li deleted the timeout branch April 28, 2024 03:59
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request May 28, 2024
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request May 28, 2024
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request May 28, 2024
Jibing-Li added a commit that referenced this pull request May 28, 2024
backport #33836

<!--Describe your changes.-->

## Further comments

If this is a relatively large or complex change, kick off the discussion
at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why
you chose the solution you did and what alternatives you considered,
etc...
Jibing-Li added a commit that referenced this pull request May 28, 2024
backport #33836

<!--Describe your changes.-->

## Further comments

If this is a relatively large or complex change, kick off the discussion
at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why
you chose the solution you did and what alternatives you considered,
etc...
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
backport apache#33836

<!--Describe your changes.-->

## Further comments

If this is a relatively large or complex change, kick off the discussion
at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why
you chose the solution you did and what alternatives you considered,
etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants