[fix](memory) Fix BlockCompression memory tracking #33841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
jacktengg
previously approved these changes
Apr 19, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
xinyiZzz
force-pushed
the
20240417_fix_tracker_compression
branch
from
ec3934c to
1c68d65
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return &s_instance; | ||
| } | ||
| ~Lz4BlockCompression() { _ctx_pool.clear(); } | ||
| ~Lz4BlockCompression() { |
Contributor
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Suggested change
| ~Lz4BlockCompression() { | |
| ~Lz4BlockCompression() override { |
| return &s_instance; | ||
| } | ||
| ~Lz4HCBlockCompression() { _ctx_pool.clear(); } | ||
| ~Lz4HCBlockCompression() { |
Contributor
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Suggested change
| ~Lz4HCBlockCompression() { | |
| ~Lz4HCBlockCompression() override { |
TPC-H: Total hot run time: 38963 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 183732 ms |
ClickBench: Total hot run time: 29.91 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
approved these changes
Apr 19, 2024
Gabriel39
approved these changes
Apr 19, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 9, 2024
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 9, 2024
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 10, 2024
yiguolei
pushed a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 10, 2024
yiguolei
pushed a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 11, 2024
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 13, 2024
yiguolei
added a commit
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
BlockCompression memory may be shared between multiple queries.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...