[Fix](compile) Fix gcc compile on master #33864

zclllyybb · 2024-04-18T16:05:04Z

Proposed changes

Issue Number: close #xxx

This is imported by #33511. wrongly used

ColumnStr<T> ();

which violate C++20 standard(see https://wg21.cmeerw.net/cwg/issue2237) but still supported by clang up until now(see llvm/llvm-project#58112)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-04-18T16:05:09Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zclllyybb · 2024-04-18T16:09:00Z

run buildall

github-actions

clang-tidy made some suggestions

be/src/runtime/primitive_type.h

be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.h

be/src/vec/columns/column_string.h

be/src/vec/exec/format/parquet/decoder.h

be/src/vec/exec/format/parquet/parquet_column_convert.h

be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.h

be/src/vec/functions/in.h

doris-robot · 2024-04-18T17:28:36Z

TeamCity be ut coverage result:
Function Coverage: 35.43% (8913/25157)
Line Coverage: 27.11% (73239/270129)
Region Coverage: 26.26% (37843/144127)
Branch Coverage: 23.06% (19276/83604)
Coverage Report: http://coverage.selectdb-in.cc/coverage/680a46f252a16a43a3f236a82f342f652c18e641_680a46f252a16a43a3f236a82f342f652c18e641/report/index.html

doris-robot · 2024-04-18T17:32:06Z

TPC-H: Total hot run time: 38484 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 680a46f252a16a43a3f236a82f342f652c18e641, data reload: false

------ Round 1 ----------------------------------
q1	17619	4420	4268	4268
q2	2002	189	182	182
q3	10480	1166	1168	1166
q4	10187	828	717	717
q5	7532	2714	2605	2605
q6	216	130	134	130
q7	997	593	575	575
q8	9221	2076	2078	2076
q9	7256	6599	6554	6554
q10	8650	3532	3527	3527
q11	431	229	215	215
q12	449	208	209	208
q13	17769	2954	2929	2929
q14	276	234	226	226
q15	532	478	484	478
q16	497	391	380	380
q17	972	667	706	667
q18	7461	6823	6779	6779
q19	6960	1551	1510	1510
q20	649	312	297	297
q21	3430	2839	2695	2695
q22	369	314	300	300
Total cold run time: 113955 ms
Total hot run time: 38484 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4294	4197	4199	4197
q2	375	272	267	267
q3	2996	2771	2730	2730
q4	1873	1589	1571	1571
q5	5298	5324	5290	5290
q6	209	121	121	121
q7	2229	1815	1875	1815
q8	3204	3352	3341	3341
q9	8661	8573	8705	8573
q10	4065	3908	4016	3908
q11	596	486	497	486
q12	795	694	656	656
q13	17453	3195	3139	3139
q14	347	291	298	291
q15	516	496	474	474
q16	494	442	460	442
q17	1852	1546	1501	1501
q18	8269	7985	7879	7879
q19	1685	1572	1572	1572
q20	2026	1850	1815	1815
q21	8570	4991	5016	4991
q22	558	482	473	473
Total cold run time: 76365 ms
Total hot run time: 55532 ms

doris-robot · 2024-04-18T17:43:58Z

TPC-DS: Total hot run time: 185058 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 680a46f252a16a43a3f236a82f342f652c18e641, data reload: false

query1	912	376	358	358
query2	6195	2688	2588	2588
query3	6658	209	202	202
query4	22901	21213	21205	21205
query5	4126	397	396	396
query6	262	218	189	189
query7	4581	289	277	277
query8	261	184	167	167
query9	8484	2273	2268	2268
query10	399	233	243	233
query11	14760	14139	14304	14139
query12	136	92	84	84
query13	1639	363	358	358
query14	9536	7354	7786	7354
query15	278	175	187	175
query16	8082	259	250	250
query17	1927	580	583	580
query18	2107	279	282	279
query19	267	153	152	152
query20	94	84	86	84
query21	200	126	124	124
query22	5167	5035	4908	4908
query23	33623	33035	33186	33035
query24	10838	3044	3066	3044
query25	607	405	398	398
query26	715	160	153	153
query27	2333	355	362	355
query28	5816	2057	2027	2027
query29	900	669	628	628
query30	308	183	183	183
query31	1034	771	776	771
query32	93	55	55	55
query33	666	258	250	250
query34	893	504	487	487
query35	838	722	704	704
query36	1081	917	953	917
query37	112	73	76	73
query38	3453	3337	3353	3337
query39	1642	1564	1609	1564
query40	184	134	128	128
query41	49	45	45	45
query42	109	101	99	99
query43	613	561	556	556
query44	1102	725	748	725
query45	293	290	281	281
query46	1100	748	761	748
query47	2069	1949	1938	1938
query48	386	305	305	305
query49	852	417	420	417
query50	805	391	393	391
query51	6941	6768	6762	6762
query52	100	85	90	85
query53	339	273	265	265
query54	299	228	228	228
query55	73	68	70	68
query56	238	216	214	214
query57	1268	1117	1118	1117
query58	219	214	196	196
query59	3361	3224	3180	3180
query60	247	239	225	225
query61	85	84	86	84
query62	615	427	432	427
query63	303	275	270	270
query64	4849	4065	3852	3852
query65	3070	3009	3009	3009
query66	750	321	330	321
query67	15516	15249	14871	14871
query68	10116	544	531	531
query69	588	322	296	296
query70	1363	1181	1162	1162
query71	1512	1258	1261	1258
query72	6914	2615	2418	2418
query73	1605	314	310	310
query74	6875	6448	6455	6448
query75	5048	2596	2570	2570
query76	5861	1062	951	951
query77	613	291	254	254
query78	11094	10194	10335	10194
query79	11445	507	502	502
query80	2392	420	420	420
query81	540	239	238	238
query82	229	95	91	91
query83	219	162	163	162
query84	264	86	83	83
query85	956	256	258	256
query86	338	280	309	280
query87	3496	3292	3295	3292
query88	5709	2319	2319	2319
query89	507	376	368	368
query90	2407	174	173	173
query91	121	92	94	92
query92	61	46	45	45
query93	7081	488	501	488
query94	1543	170	175	170
query95	390	283	283	283
query96	603	256	257	256
query97	3129	2919	2920	2919
query98	237	206	214	206
query99	1074	886	865	865
Total cold run time: 304089 ms
Total hot run time: 185058 ms

doris-robot · 2024-04-18T17:49:29Z

ClickBench: Total hot run time: 30.35 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 680a46f252a16a43a3f236a82f342f652c18e641, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.49	0.49	0.51
query6	1.41	0.73	0.71
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.56	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.59	0.59
query14	0.75	0.78	0.76
query15	0.83	0.79	0.78
query16	0.37	0.36	0.35
query17	0.97	0.98	0.96
query18	0.21	0.23	0.24
query19	1.74	1.67	1.70
query20	0.02	0.01	0.01
query21	15.40	0.66	0.65
query22	4.44	6.96	1.95
query23	18.23	1.35	1.28
query24	1.34	0.27	0.31
query25	0.15	0.09	0.09
query26	0.23	0.16	0.16
query27	0.07	0.08	0.08
query28	13.54	1.00	0.97
query29	12.60	3.29	3.25
query30	0.26	0.06	0.05
query31	2.84	0.37	0.38
query32	3.29	0.46	0.46
query33	2.86	2.78	2.86
query34	16.87	4.43	4.39
query35	4.44	4.48	4.51
query36	0.65	0.46	0.46
query37	0.18	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.03
query40	0.19	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.84 s
Total hot run time: 30.35 s

doris-robot · 2024-04-18T17:52:37Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 680a46f252a16a43a3f236a82f342f652c18e641 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.3 seconds inserted 10000000 Rows, about 751K ops/s

zclllyybb · 2024-04-19T02:48:21Z

run buildall

doris-robot · 2024-04-19T04:19:14Z

TPC-H: Total hot run time: 38693 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 517aa90f29a930dfa23dbe1229e08b9a8f749ea8, data reload: false

------ Round 1 ----------------------------------
q1	17606	4664	4478	4478
q2	1999	178	180	178
q3	10469	1138	1229	1138
q4	10194	691	752	691
q5	7504	2689	2665	2665
q6	215	138	141	138
q7	1049	608	580	580
q8	9210	2125	2058	2058
q9	7459	6620	6554	6554
q10	8573	3544	3514	3514
q11	456	223	229	223
q12	516	230	225	225
q13	18766	2961	2964	2961
q14	273	235	230	230
q15	532	483	469	469
q16	547	390	385	385
q17	977	637	629	629
q18	7407	6864	6654	6654
q19	8715	1531	1547	1531
q20	656	315	310	310
q21	3578	2779	2820	2779
q22	360	303	310	303
Total cold run time: 117061 ms
Total hot run time: 38693 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4380	4302	4318	4302
q2	371	278	275	275
q3	2998	2713	2748	2713
q4	1866	1580	1615	1580
q5	5386	5360	5343	5343
q6	213	126	127	126
q7	2283	1891	1873	1873
q8	3259	3403	3367	3367
q9	8614	8634	8646	8634
q10	3899	3660	3697	3660
q11	583	490	477	477
q12	772	608	575	575
q13	17238	3018	2937	2937
q14	319	289	267	267
q15	520	483	468	468
q16	481	412	447	412
q17	1787	1490	1559	1490
q18	8121	7969	8052	7969
q19	1695	1628	1555	1555
q20	2120	1811	1824	1811
q21	10787	5098	4970	4970
q22	560	493	486	486
Total cold run time: 78252 ms
Total hot run time: 55290 ms

doris-robot · 2024-04-19T04:20:44Z

TeamCity be ut coverage result:
Function Coverage: 35.43% (8919/25174)
Line Coverage: 27.12% (73303/270275)
Region Coverage: 26.25% (37853/144204)
Branch Coverage: 23.06% (19288/83648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/517aa90f29a930dfa23dbe1229e08b9a8f749ea8_517aa90f29a930dfa23dbe1229e08b9a8f749ea8/report/index.html

HappenLee

LGTM

github-actions · 2024-04-19T07:12:24Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-04-19T07:12:27Z

PR approved by anyone and no changes requested.

This is imported by #33511. wrongly used ColumnStr<T> (); which violate C++20 standard(see https://wg21.cmeerw.net/cwg/issue2237) but still supported by clang up until now(see llvm/llvm-project#58112)

zclllyybb force-pushed the fix_gcc branch from 5efae7e to 680a46f Compare April 18, 2024 16:06

github-actions bot reviewed Apr 18, 2024

View reviewed changes

1

517aa90

zclllyybb force-pushed the fix_gcc branch from 680a46f to 517aa90 Compare April 19, 2024 02:47

HappenLee approved these changes Apr 19, 2024

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 19, 2024

BiteTheDDDDt approved these changes Apr 19, 2024

View reviewed changes

BiteTheDDDDt merged commit dd470f3 into apache:master Apr 19, 2024

zclllyybb deleted the fix_gcc branch April 19, 2024 08:34

[Fix](compile) Fix gcc compile on master #33864

[Fix](compile) Fix gcc compile on master #33864

Uh oh!

Conversation

zclllyybb commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

zclllyybb commented Apr 18, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

doris-robot commented Apr 18, 2024

Uh oh!

zclllyybb commented Apr 19, 2024

Uh oh!

doris-robot commented Apr 19, 2024

Uh oh!

doris-robot commented Apr 19, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 19, 2024

Uh oh!

github-actions bot commented Apr 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zclllyybb commented Apr 18, 2024 •

edited

Loading