[Enhancement](hdfs-file-system) Change fs_handler ptr to shared_ptr and remove ref count operations. #34049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void dec_ref() { | ||
| _ref_cnt--; | ||
| _last_access_time = _now(); | ||
| void update_last_access_time() { |
Contributor
There was a problem hiding this comment.
warning: method 'update_last_access_time' can be made const [readability-make-member-function-const]
Suggested change
| void update_last_access_time() { | |
| void update_last_access_time() const { |
kaka11chen
force-pushed
the
cherry-pick-33959-to-2.1
branch
from
d42b954 to
f67a14b
Compare
kaka11chen
force-pushed
the
cherry-pick-33959-to-2.1
branch
from
f67a14b to
f6ab82c
Compare
…nd remove ref count operations.
kaka11chen
force-pushed
the
cherry-pick-33959-to-2.1
branch
from
f6ab82c to
cf1ab98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Backport #33959.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...