Skip to content

Conversation

@xzj7019
Copy link
Contributor

@xzj7019 xzj7019 commented Apr 24, 2024

Proposed changes

Expand bucket shuffle downgrade condition, which originally requiring a single partition after pruning, basic table and bucket number < para number. Currently, we expect this option can be used for disabling bucket shuffle more efficiently, without above restrictions.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xzj7019 xzj7019 marked this pull request as draft April 24, 2024 13:49
@xzj7019
Copy link
Contributor Author

xzj7019 commented Apr 24, 2024

run buildall

@xzj7019 xzj7019 force-pushed the simplify_bs_downgrade branch from 2c4d982 to 90d6d8b Compare April 25, 2024 03:00
@xzj7019 xzj7019 force-pushed the simplify_bs_downgrade branch from 90d6d8b to 6a3f567 Compare April 25, 2024 03:00
@xzj7019
Copy link
Contributor Author

xzj7019 commented Apr 25, 2024

run buildall

@xzj7019 xzj7019 marked this pull request as ready for review April 25, 2024 03:01
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow
Copy link
Contributor

run cloud_p1

@morrySnow morrySnow merged commit 6771589 into apache:master Apr 26, 2024
yiguolei pushed a commit that referenced this pull request Apr 26, 2024
Expand bucket shuffle downgrade condition, which originally requiring a single partition after pruning, basic table and bucket number < para number. Currently, we expect this option can be used for disabling bucket shuffle more efficiently, without above restrictions.

Co-authored-by: zhongjian.xzj <zhongjian.xzj@zhongjianxzjdeMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants