Update doris_main.cpp #34128
Update doris_main.cpp #34128
Conversation
Log(FATAL) introduces a core dump, which is confusing for users. We should print error msg and exit without a core dump.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
zclllyybb
left a comment
zclllyybb
left a comment
There was a problem hiding this comment.
you should make it exit here. and no __builtin_unreachable since LOG(ERROR) make it reachable
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
TeamCity be ut coverage result: |
* Update doris_main.cpp Log(FATAL) introduces a core dump, which is confusing for users. We should print error msg and exit without a core dump. * Update doris_main.cpp
5 participants
Log(FATAL) introduces a core dump, which is confusing for users. We should print error msg and exit without a core dump.
Proposed changes
Issue Number: open #31441
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...