Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Apr 26, 2024

Proposed changes

The LocalExchangeChannelIds is designed to handle hash values with the type of uint64_t.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mrhhsg
Copy link
Member Author

mrhhsg commented Apr 26, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39454 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7262ccf386b0205fd6c9a9730262aefbcc7b33fe, data reload: false

------ Round 1 ----------------------------------
q1	17583	4301	4208	4208
q2	2016	177	176	176
q3	10480	1158	1210	1158
q4	10197	870	720	720
q5	7494	2795	2551	2551
q6	212	132	131	131
q7	991	578	575	575
q8	9262	2078	2023	2023
q9	8945	6600	6529	6529
q10	8717	3732	3676	3676
q11	452	230	237	230
q12	436	217	213	213
q13	17760	2894	2940	2894
q14	270	233	225	225
q15	509	488	489	488
q16	509	371	372	371
q17	957	631	688	631
q18	8005	7435	7387	7387
q19	6311	1523	1525	1523
q20	651	319	302	302
q21	4887	3178	3191	3178
q22	324	265	266	265
Total cold run time: 116968 ms
Total hot run time: 39454 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4271	4196	4200	4196
q2	363	269	261	261
q3	2952	2693	2709	2693
q4	1839	1537	1600	1537
q5	5258	5268	5278	5268
q6	210	119	123	119
q7	2251	1898	1883	1883
q8	3427	3298	3324	3298
q9	8479	8493	8778	8493
q10	4024	3881	3882	3881
q11	600	481	507	481
q12	791	610	666	610
q13	16368	3180	3138	3138
q14	312	288	304	288
q15	519	479	497	479
q16	512	449	444	444
q17	1788	1532	1569	1532
q18	8220	7969	7537	7537
q19	1674	1614	1548	1548
q20	2064	1839	1828	1828
q21	5141	4947	4895	4895
q22	559	494	475	475
Total cold run time: 71622 ms
Total hot run time: 54884 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187194 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7262ccf386b0205fd6c9a9730262aefbcc7b33fe, data reload: false

query1	902	369	345	345
query2	6159	2475	2322	2322
query3	6664	199	194	194
query4	24088	21077	21157	21077
query5	4156	418	427	418
query6	281	186	177	177
query7	4594	282	282	282
query8	250	181	186	181
query9	8602	2333	2327	2327
query10	397	245	241	241
query11	14620	14057	14151	14057
query12	136	85	89	85
query13	1623	350	341	341
query14	10520	8350	8395	8350
query15	256	177	170	170
query16	8228	254	260	254
query17	1977	551	583	551
query18	2100	276	270	270
query19	327	152	140	140
query20	88	80	85	80
query21	195	119	119	119
query22	5043	4869	4893	4869
query23	33926	33038	33423	33038
query24	11008	3077	3084	3077
query25	618	376	384	376
query26	1162	161	160	160
query27	2442	362	372	362
query28	7000	2097	2035	2035
query29	869	611	603	603
query30	246	160	156	156
query31	982	740	769	740
query32	97	53	53	53
query33	770	246	263	246
query34	1210	494	495	494
query35	814	681	698	681
query36	1091	932	941	932
query37	127	68	71	68
query38	3297	3186	3131	3131
query39	1632	1619	1586	1586
query40	179	122	124	122
query41	40	36	36	36
query42	98	91	96	91
query43	565	514	541	514
query44	1185	736	737	736
query45	294	260	271	260
query46	1108	769	761	761
query47	2070	1974	1981	1974
query48	368	301	309	301
query49	855	394	399	394
query50	840	400	393	393
query51	6891	6958	6751	6751
query52	100	89	87	87
query53	339	273	270	270
query54	311	234	232	232
query55	78	72	72	72
query56	242	230	233	230
query57	1212	1146	1159	1146
query58	232	204	196	196
query59	3236	3137	3017	3017
query60	263	232	239	232
query61	105	101	101	101
query62	614	433	431	431
query63	306	273	278	273
query64	8499	7173	7177	7173
query65	3055	3032	3023	3023
query66	757	335	359	335
query67	15512	15045	15104	15045
query68	6601	517	518	517
query69	530	307	306	306
query70	1195	1124	1160	1124
query71	495	258	268	258
query72	7839	2624	2448	2448
query73	726	309	310	309
query74	6552	6102	6140	6102
query75	3986	2651	2653	2651
query76	5035	917	988	917
query77	600	257	256	256
query78	10944	10334	10294	10294
query79	8549	516	507	507
query80	1724	421	431	421
query81	524	223	218	218
query82	893	96	94	94
query83	204	161	166	161
query84	256	85	82	82
query85	1343	254	251	251
query86	470	278	272	272
query87	3308	3074	3129	3074
query88	5245	2315	2299	2299
query89	559	363	365	363
query90	1946	175	173	173
query91	120	95	91	91
query92	59	46	45	45
query93	7240	494	486	486
query94	996	169	171	169
query95	390	285	292	285
query96	584	258	263	258
query97	3126	2938	2939	2938
query98	236	224	208	208
query99	1223	866	833	833
Total cold run time: 301349 ms
Total hot run time: 187194 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.19% (8919/25342)
Line Coverage: 26.98% (73339/271875)
Region Coverage: 26.15% (37889/144889)
Branch Coverage: 22.97% (19295/83994)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7262ccf386b0205fd6c9a9730262aefbcc7b33fe_7262ccf386b0205fd6c9a9730262aefbcc7b33fe/report/index.html

@mrhhsg mrhhsg merged commit 7a26e07 into apache:master Apr 26, 2024
@mrhhsg mrhhsg deleted the fix_partitioner branch April 26, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants