Skip to content

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Apr 26, 2024

Proposed changes

Record increase refersh version more accurately.
The refreshVersion in the memo will increase when mv rewrite successfully.
In query rewrite, if refresh version is different from the current struct info map in group , will refresh the group struct info or not.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@seawinde
Copy link
Contributor Author

run buildall

@seawinde
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40184 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 993f5989739519447874fe153aae4a3d93114878, data reload: false

------ Round 1 ----------------------------------
q1	17612	4355	4271	4271
q2	2005	199	188	188
q3	10663	1241	1263	1241
q4	10549	791	818	791
q5	7544	2777	2640	2640
q6	219	134	135	134
q7	1036	620	625	620
q8	9347	2116	2079	2079
q9	9334	6792	6569	6569
q10	8779	3794	3718	3718
q11	447	246	244	244
q12	390	222	222	222
q13	17762	2980	2933	2933
q14	286	229	228	228
q15	510	473	480	473
q16	495	390	386	386
q17	964	718	751	718
q18	8149	7503	7368	7368
q19	1627	1529	1526	1526
q20	647	301	297	297
q21	5198	3262	4053	3262
q22	340	277	276	276
Total cold run time: 113903 ms
Total hot run time: 40184 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4283	4258	4181	4181
q2	363	282	271	271
q3	3055	2781	2784	2781
q4	1941	1628	1557	1557
q5	5331	5303	5336	5303
q6	217	123	124	123
q7	2284	1895	1844	1844
q8	3198	3347	3379	3347
q9	8469	8599	8593	8593
q10	3958	3691	3690	3690
q11	593	494	491	491
q12	778	620	583	583
q13	17166	2974	2992	2974
q14	304	279	281	279
q15	514	473	478	473
q16	460	416	424	416
q17	1760	1470	1465	1465
q18	7468	7539	7386	7386
q19	1636	1504	1583	1504
q20	1978	1775	1798	1775
q21	4973	4913	4919	4913
q22	573	514	515	514
Total cold run time: 71302 ms
Total hot run time: 54463 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186363 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 993f5989739519447874fe153aae4a3d93114878, data reload: false

query1	900	377	347	347
query2	6478	2573	2475	2475
query3	6733	219	217	217
query4	24911	21355	21784	21355
query5	4285	431	457	431
query6	280	200	191	191
query7	4669	301	311	301
query8	276	217	205	205
query9	10761	2333	2346	2333
query10	423	248	254	248
query11	15019	14198	14431	14198
query12	137	87	86	86
query13	1640	361	357	357
query14	10846	8385	7469	7469
query15	267	167	174	167
query16	8222	254	253	253
query17	2068	582	540	540
query18	2116	281	272	272
query19	339	148	149	148
query20	93	84	85	84
query21	197	131	131	131
query22	4937	4787	4775	4775
query23	34081	33293	33127	33127
query24	10671	2976	2973	2973
query25	593	383	365	365
query26	1125	156	151	151
query27	2886	316	316	316
query28	7310	1994	1982	1982
query29	856	609	602	602
query30	295	147	152	147
query31	991	725	729	725
query32	96	58	54	54
query33	752	247	245	245
query34	1069	475	484	475
query35	809	693	662	662
query36	1080	875	914	875
query37	126	68	67	67
query38	3132	3037	2987	2987
query39	1578	1535	1530	1530
query40	208	129	122	122
query41	41	39	41	39
query42	101	100	96	96
query43	585	554	564	554
query44	1239	723	747	723
query45	289	265	271	265
query46	1089	737	734	734
query47	1928	1853	1846	1846
query48	380	303	300	300
query49	1044	407	425	407
query50	754	377	380	377
query51	6967	6723	6819	6723
query52	102	97	91	91
query53	351	274	274	274
query54	304	263	250	250
query55	81	73	73	73
query56	248	224	230	224
query57	1208	1119	1144	1119
query58	249	209	208	208
query59	3515	3160	3096	3096
query60	270	243	243	243
query61	109	108	110	108
query62	648	446	425	425
query63	310	281	278	278
query64	8651	7239	7181	7181
query65	3107	3050	3036	3036
query66	1416	349	352	349
query67	15539	14959	14970	14959
query68	6029	531	520	520
query69	544	313	309	309
query70	1108	1088	1063	1063
query71	484	287	269	269
query72	8558	2616	2420	2420
query73	728	313	317	313
query74	6519	6120	6055	6055
query75	4142	2714	2665	2665
query76	4412	946	1003	946
query77	666	265	262	262
query78	11074	10213	10235	10213
query79	10980	515	508	508
query80	1741	446	435	435
query81	531	220	218	218
query82	866	96	93	93
query83	204	167	172	167
query84	264	87	85	85
query85	1482	305	258	258
query86	455	288	292	288
query87	3284	3053	3132	3053
query88	5446	2323	2346	2323
query89	534	380	362	362
query90	1976	188	187	187
query91	124	97	94	94
query92	58	48	46	46
query93	7890	519	499	499
query94	1264	184	180	180
query95	388	302	293	293
query96	591	264	269	264
query97	3166	2946	2957	2946
query98	242	223	215	215
query99	1284	862	848	848
Total cold run time: 310814 ms
Total hot run time: 186363 ms

}
// TODO Support sync materialized view in the future
if (plan instanceof CatalogRelation && ((CatalogRelation) plan).getTable() instanceof MTMV) {
if (plan instanceof LogicalPlan && plan instanceof CatalogRelation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please use LogicalCatalogRelation in next pr

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 935f613 into apache:master Apr 26, 2024
seawinde added a commit to seawinde/doris that referenced this pull request Apr 26, 2024
…apache#34163)

Record increase refersh version more accurately.
The refreshVersion in the memo will increase when mv rewrite successfully.
In query rewrite, if refresh version is different from the current struct info map in group,
will refresh the group struct info or not.
yiguolei pushed a commit that referenced this pull request Apr 26, 2024
…#34163)

Record increase refersh version more accurately.
The refreshVersion in the memo will increase when mv rewrite successfully.
In query rewrite, if refresh version is different from the current struct info map in group,
will refresh the group struct info or not.
yiguolei pushed a commit that referenced this pull request Apr 27, 2024
…#34163) (#34192)

Record increase refersh version more accurately.
The refreshVersion in the memo will increase when mv rewrite successfully.
In query rewrite, if refresh version is different from the current struct info map in group,
will refresh the group struct info or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants